mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

typeTypeName() must return a pstrdup'd copy of the type name, not a

Browse Source 
direct pointer into the syscache entry for the type.  In some cases
the syscache entry might get flushed before we are done using the
returned type name.  This bug accounts for difficult-to-repeat
failures seen when INSERTs into columns of certain data types are
run in parallel with VACUUMs of system tables.  There may be related
problems elsewhere --- we need to take a harder look at uses of
syscache data.
This commit is contained in:
Tom Lane 2000-06-06 16:50:37 +00:00
parent 4032a515d2
commit 05cd91a582
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/parser/parse_type.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/parser/parse_type.c,v 1.30 2000/05/30 04:24:49 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/parser/parse_type.c,v 1.31 2000/06/06 16:50:37 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -48,7 +48,8 @@ typeidTypeName(Oid id)
return NULL; return NULL;
} }
typetuple = (Form_pg_type) GETSTRUCT(tup); typetuple = (Form_pg_type) GETSTRUCT(tup);
return NameStr(typetuple->typname); /* pstrdup here because result may need to outlive the syscache entry */
return pstrdup(NameStr(typetuple->typname));
} }
/* return a Type structure, given a type id */ /* return a Type structure, given a type id */
@ -119,7 +120,8 @@ typeTypeName(Type t)
Form_pg_type typ; Form_pg_type typ;
typ = (Form_pg_type) GETSTRUCT(t); typ = (Form_pg_type) GETSTRUCT(t);
return NameStr(typ->typname); /* pstrdup here because result may need to outlive the syscache entry */
return pstrdup(NameStr(typ->typname));
} }
/* given a type, return its typetype ('c' for 'c'atalog types) */ /* given a type, return its typetype ('c' for 'c'atalog types) */