mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

logical decoding: beware of an unset specinsert change

Browse Source 
Coverity complains that there is no protection in the code (at least in
non-assertion-enabled builds) against speculative insertion failing to
follow the expected protocol.  Add an elog(ERROR) for the case.
This commit is contained in:
Alvaro Herrera 2018-07-05 17:42:37 -04:00
parent d5176fa1e3
commit 05c7426bac
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/replication/logical/reorderbuffer.c
View File

@ -1474,6 +1474,8 @@ ReorderBufferCommit(ReorderBuffer *rb, TransactionId xid,
* use as a normal record. It'll be cleaned up at the end * use as a normal record. It'll be cleaned up at the end
* of INSERT processing. * of INSERT processing.
*/ */
if (specinsert == NULL)
elog(ERROR, "invalid ordering of speculative insertion changes");
Assert(specinsert->data.tp.oldtuple == NULL); Assert(specinsert->data.tp.oldtuple == NULL);
change = specinsert; change = specinsert;
change->action = REORDER_BUFFER_CHANGE_INSERT; change->action = REORDER_BUFFER_CHANGE_INSERT;