mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Allow for yet another crash symptom in 013_crash_restart.pl.

Browse Source 
Given the right timing, psql could emit "connection to server was lost"
rather than one of the other messages that this test script checked for.
It looks like commit 4247db625 may have made this more likely, but
I don't really believe it was impossible before then.  Rather than
stress about it, just add that spelling as one of the crash-successfully-
detected cases.

Discussion: https://postgr.es/m/19344.1548554028@sss.pgh.pa.us
This commit is contained in:
Tom Lane 2019-01-26 22:12:49 -05:00
parent 2c50c9f23d
commit 04bbefcc30
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/recovery/t/013_crash_restart.pl
View File

@ -115,7 +115,7 @@ SELECT 1;
ok( pump_until( ok( pump_until(
$killme, $killme,
\$killme_stderr, \$killme_stderr,
qr/WARNING: terminating connection because of crash of another server process|server closed the connection unexpectedly/m qr/WARNING: terminating connection because of crash of another server process|server closed the connection unexpectedly|connection to server was lost/m
), ),
"psql query died successfully after SIGQUIT"); "psql query died successfully after SIGQUIT");
$killme_stderr = ''; $killme_stderr = '';
@ -128,7 +128,7 @@ $killme->finish;
ok( pump_until( ok( pump_until(
$monitor, $monitor,
\$monitor_stderr, \$monitor_stderr,
qr/WARNING: terminating connection because of crash of another server process|server closed the connection unexpectedly/m qr/WARNING: terminating connection because of crash of another server process|server closed the connection unexpectedly|connection to server was lost/m
), ),
"psql monitor died successfully after SIGQUIT"); "psql monitor died successfully after SIGQUIT");
$monitor->finish; $monitor->finish;
@ -197,7 +197,7 @@ SELECT 1;
]; ];
ok( pump_until( ok( pump_until(
$killme, \$killme_stderr, $killme, \$killme_stderr,
qr/server closed the connection unexpectedly/m), qr/server closed the connection unexpectedly|connection to server was lost/m),
"psql query died successfully after SIGKILL"); "psql query died successfully after SIGKILL");
$killme->finish; $killme->finish;
@ -207,7 +207,7 @@ $killme->finish;
ok( pump_until( ok( pump_until(
$monitor, $monitor,
\$monitor_stderr, \$monitor_stderr,
qr/WARNING: terminating connection because of crash of another server process|server closed the connection unexpectedly/m qr/WARNING: terminating connection because of crash of another server process|server closed the connection unexpectedly|connection to server was lost/m
), ),
"psql monitor died successfully after SIGKILL"); "psql monitor died successfully after SIGKILL");
$monitor->finish; $monitor->finish;