mirrors/postgres
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Clean up test_ifaddrs a bit.

Browse Source 
We customarily #include <netinet/in.h> before <arpa/inet.h>; according
to our git history (cf commit 527f8babc) there used to be platform(s)
where <arpa/inet.h> didn't compile otherwise.  That's probably not
really an issue anymore, but since test_ifaddrs.c is the one and only
place in our code that's not following that rule, bring it into line.
Also remove #include <sys/socket.h>, as that's duplicative given that
libpq/ifaddr.h does so (via pqcomm.h).

In passing, add a .gitignore file so nobody accidentally commits the
test_ifaddrs executable, as I nearly did.

I see no particular need to back-patch this, as it's just neatnik-ism
considering we don't build test_ifaddrs by default, or even document
it anywhere.
This commit is contained in:
Tom Lane 2017-03-07 12:05:57 -05:00
parent 95c1dbcdff
commit 03cf221934
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/tools/ifaddrs/.gitignore vendored Normal file
View File

@ -0,0 +1 @@
/test_ifaddrs

3
src/tools/ifaddrs/test_ifaddrs.c
View File

@ -8,9 +8,8 @@
#include "postgres.h" #include "postgres.h"
#include <arpa/inet.h>
#include <netinet/in.h> #include <netinet/in.h>
#include <sys/socket.h> #include <arpa/inet.h>
#include "libpq/ifaddr.h" #include "libpq/ifaddr.h"