mirror of
https://github.com/netsurf-browser/netsurf
synced 2024-12-27 22:39:43 +03:00
23fb72ea6b
Do not change the locale globally, else things will break in weird and
wonderful ways.
Introduce utils/locale.[ch], which provide locale-specific wrappers for various
functions (currently just the <ctype.h> ones).
Fix up the few places I can see that actually require that the underlying
locale is paid attention to.
Some notes:
1) The GTK frontend code has not been touched. It is possible that reading of
numeric values (e.g. from the preferences dialogue) may break with this
change, particularly in locales that use something other than '.' as their
decimal separator.
2) The search code is left unchanged (i.e. assuming a locale of "C").
This may break case insensitive matching of non-ASCII characters.
I doubt that ever actually worked, anyway. In future, it should use
Unicode case conversion to achieve the same effect.
3) The text input handling in the core makes use of isspace() to detect
word boundaries. This is fine for western languages (even in the C locale,
which it's currently assuming). It will, however, break for CJK et. al.
(this has always been the case, rather than being a new issue)
4) text-transform uses locale-specific variants of to{lower,upper}. In future
this should probably be performing Unicode case conversion. This is the
only part of the core code that makes use of locale information.
In future, if you require locale-specific behaviour, do the following:
setlocale(LC_<whatever>, "");
<your operation(s) here>
setlocale(LC_<whatever>, "C");
The first setlocale will change the current locale to the native environment.
The second setlocale will reset the current locale to "C".
Any value other than "" or "C" is probably a bug, unless there's a really
good reason for it.
In the long term, it is expected that all locale-dependent code will reside in
platform frontends -- the core being wholly locale agnostic (though assuming
"C" for things like decimal separators).
svn path=/trunk/netsurf/; revision=4153
54 lines
1.3 KiB
C
54 lines
1.3 KiB
C
/*
|
|
* Copyright 2008 John-Mark Bell <jmb@netsurf-browser.org>
|
|
*
|
|
* This file is part of NetSurf, http://www.netsurf-browser.org/
|
|
*
|
|
* NetSurf is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; version 2 of the License.
|
|
*
|
|
* NetSurf is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
/** \file
|
|
* Locale-specific variants of various routines (implementation)
|
|
*/
|
|
|
|
#include <ctype.h>
|
|
#include <locale.h>
|
|
|
|
#include "utils/locale.h"
|
|
|
|
/* <ctype.h> functions */
|
|
#define MAKELSCTYPE(x) int ls_##x(int c) \
|
|
{ \
|
|
int ret; \
|
|
setlocale(LC_ALL, ""); \
|
|
ret = x(c); \
|
|
setlocale(LC_ALL, "C"); \
|
|
return ret; \
|
|
}
|
|
|
|
MAKELSCTYPE(isalpha)
|
|
MAKELSCTYPE(isalnum)
|
|
MAKELSCTYPE(iscntrl)
|
|
MAKELSCTYPE(isdigit)
|
|
MAKELSCTYPE(isgraph)
|
|
MAKELSCTYPE(islower)
|
|
MAKELSCTYPE(isprint)
|
|
MAKELSCTYPE(ispunct)
|
|
MAKELSCTYPE(isspace)
|
|
MAKELSCTYPE(isupper)
|
|
MAKELSCTYPE(isxdigit)
|
|
MAKELSCTYPE(tolower)
|
|
MAKELSCTYPE(toupper)
|
|
|
|
#undef MAKELSCTYPE
|
|
|