Michael Drake
ce117d140e
Remove dead code and variables.
2014-05-30 23:59:17 +01:00
Michael Drake
910efb0156
Scope reduce several variables.
2014-05-30 23:57:04 +01:00
Michael Drake
c01e168d64
Scope reduce a couple of variables.
2014-05-30 23:35:38 +01:00
Michael Drake
dcf9eca7b3
Visits is unsigned, so can't be less than 0.
2014-05-30 23:33:13 +01:00
Michael Drake
8ee941a7a5
Scope reduce several variables.
2014-05-30 23:30:44 +01:00
Michael Drake
bbb002ee1d
Scope reduce some variables.
2014-05-30 23:24:56 +01:00
Michael Drake
ecee6ffad8
Remove dead code.
2014-05-30 23:22:50 +01:00
Michael Drake
33513e65ea
Fix toolbar width calculation.
...
+ has greater precedence than ?:, so wrap :? part in ().
2014-05-30 23:18:29 +01:00
Michael Drake
2f02d0785a
Scope reduce a variable.
2014-05-30 23:13:42 +01:00
Michael Drake
55b3163520
Reduce scope of a variable.
2014-05-30 23:11:09 +01:00
Michael Drake
259a02a72a
Scope reduce some variables.
2014-05-30 23:06:30 +01:00
Michael Drake
f313635e21
Reduce scope of a variable.
2014-05-30 23:04:10 +01:00
Michael Drake
0b39a3750c
Reduce scope of a few variables.
2014-05-30 23:02:02 +01:00
Michael Drake
ef8b0e8204
Reduce scope of several variables.
2014-05-30 22:59:12 +01:00
Michael Drake
dca506dfe4
Remove unused variables, and dead code.
2014-05-30 22:54:27 +01:00
Michael Drake
ae0e1316b7
Remove unused struct search_static_data members.
2014-05-30 22:52:22 +01:00
Michael Drake
bab90eddda
Use angle brackets instead of quotes for include of external headers.
2014-05-30 22:29:04 +01:00
Michael Drake
4fbe86bc5a
Scope reduce some variables.
2014-05-30 22:27:07 +01:00
Michael Drake
3ce61d6950
Reduce scope of a couple of variables.
2014-05-30 22:18:29 +01:00
Michael Drake
4ea90d2dca
Check correct variable for NULL.
2014-05-30 22:16:15 +01:00
Michael Drake
d0e67542f5
Reduce scope of a variable.
2014-05-30 22:12:18 +01:00
Michael Drake
d25b62f1c2
Avoid redundant assignement of name to name.
2014-05-30 21:59:12 +01:00
Vincent Sanders
7d02ae916a
make launch_url core operation use nsurl
2014-05-27 23:52:35 +01:00
Vincent Sanders
688f60d963
fix errors with path_to_url conversion
2014-05-27 00:08:04 +01:00
Vincent Sanders
00b6cfc57e
rework path to url mapping functions to convert from and to nsurl
2014-05-26 23:52:36 +01:00
Michael Drake
2aeec1a18c
Scope reduce a few variables.
2014-05-26 12:00:36 +01:00
Michael Drake
587c0229c3
Reduce scope of a couple of variables.
2014-05-26 11:57:40 +01:00
Michael Drake
c8099aef3f
Scope reduce some variables.
2014-05-26 11:55:29 +01:00
Michael Drake
2e79a8ee7a
Scope reduce a couple of variables.
2014-05-26 11:50:11 +01:00
Michael Drake
41e5f68d2c
Scope reduce some variables.
2014-05-26 11:48:07 +01:00
Michael Drake
508fc30ab9
Scope reduce a variable.
2014-05-26 11:42:25 +01:00
Michael Drake
6503757698
Scope reduce a variable.
2014-05-26 11:40:58 +01:00
Michael Drake
18fb6461f9
Reduce scope of some variables.
2014-05-26 11:39:49 +01:00
Michael Drake
a1cca5d127
Remove unused variable.
2014-05-26 11:37:16 +01:00
Michael Drake
cb0ae22949
Improve error handling.
2014-05-26 11:29:03 +01:00
Michael Drake
82bc40350a
Reuce scope of several variables.
2014-05-26 11:24:14 +01:00
Michael Drake
609eb8377b
Handle error.
2014-05-26 11:20:37 +01:00
Michael Drake
4a28b2b170
Scopre reduce some variables.
2014-05-26 11:14:18 +01:00
Michael Drake
02ac6b1976
Remove a couple of unused variables.
2014-05-26 11:05:03 +01:00
Michael Drake
8b9f2e7ee6
Fix warnings about redundant statements when building without RO types.
2014-05-26 10:51:46 +01:00
Michael Drake
cd89779831
Remove unused variable and assignements to it.
2014-05-26 10:42:43 +01:00
Michael Drake
423a934e0b
Scope reduce some variables.
2014-05-26 10:40:54 +01:00
Michael Drake
97e379083d
Scope reduce a variable.
2014-05-26 10:29:01 +01:00
Michael Drake
a64e0c4eaf
Fix failure to return NSERROR_NOMEM when malloc failed.
...
Was using return without any value.
2014-05-26 10:23:04 +01:00
Michael Drake
e105b15bf6
Fix completely broken handling of file: paths.
...
Was treating lwc_string* as char*.
2014-05-26 10:19:18 +01:00
Michael Drake
e39f0ff2f1
Scope reduce some variables.
2014-05-26 10:15:54 +01:00
Michael Drake
994caa34cb
Remove unused variable.
2014-05-26 10:12:34 +01:00
Michael Drake
ba2f3c1cb8
Scope reduce a couple of variables.
2014-05-26 10:09:55 +01:00
Michael Drake
f19bfa8f8d
Remove unneeded forward declaration.
2014-05-26 10:08:18 +01:00
Michael Drake
9cb9f638c4
Scope reduce a couple of variables.
2014-05-26 10:06:41 +01:00
Michael Drake
59e9caf8a1
Scope reduce some variables.
2014-05-26 10:02:30 +01:00
Michael Drake
6fe8e7ad53
Scope reduce some variables.
2014-05-26 10:00:09 +01:00
Michael Drake
290e4c5bf7
Report OSLib error message.
2014-05-26 09:59:37 +01:00
Vincent Sanders
966ed9449c
fix riscos mkpath and error reporting in save complete
2014-05-17 23:14:43 +01:00
Vincent Sanders
0a2082d777
ensure all vmkpath implementations check their parameters
2014-05-17 22:28:32 +01:00
Vincent Sanders
64f607760b
add backing store storage path to browser initialisation
2014-05-13 15:53:06 +01:00
Vincent Sanders
39b0393d31
cleanup utils header, remove cruft and add documentation
2014-05-11 21:31:14 +01:00
Vincent Sanders
16b11e7238
ensure operations tables are registered as early as possible.
2014-05-10 10:22:10 +01:00
Vincent Sanders
2326d3c503
remove unecessary utils/url.h includes
2014-05-09 10:15:42 +01:00
Vincent Sanders
1556055d91
fix nsurl references
2014-05-08 18:03:27 +01:00
Vincent Sanders
cd7f1eceea
make download_context_get_url() return an nsurl and adapt callers to cope
2014-05-08 17:54:44 +01:00
Vincent Sanders
096bd47ab0
refactor url utility functions to use standard nserror codes and have appropriate documentation.
2014-05-08 00:16:50 +01:00
Vincent Sanders
c56642819e
add file operations table and make all frontends use it.
...
This rationalises the path construction and basename file
operations. The default implementation is POSIX which works for all
frontends except windows, riscos and amiga which have differeing path
separators and rules.
These implementations are significantly more robust than the previous
nine implementations and also do not use unsafe strncpy or buffers
with arbitrary length limits.
These implementations also carry full documentation comments.
2014-05-07 16:24:51 +01:00
Michael Drake
2c4825cb38
Remove excessive logging.
2014-04-18 17:30:28 +01:00
Michael Drake
898ff4b821
Add logging to view-source filename generation.
2014-04-18 16:35:46 +01:00
Steve Fryatt
99c47eb99b
Allow mouse tracking events to terminate without a PointerLeaving event being received.
...
This change should handle the situation where a PointerEntering event is received without a corresponding PointerLeaving event, which appears to be caused by some third-party OS addons. This could cause unexpected consequences, so all such terminations are currently logged.
2014-04-05 19:59:07 +01:00
Michael Drake
b91c28b8d1
Fix logic error found by cppcheck.
2014-04-02 21:59:24 +01:00
Michael Drake
88a99d9722
Fix logic error found by cppcheck.
2014-04-02 21:56:34 +01:00
Michael Drake
527bc23bdb
Avoid potential NULL ptr deref found by cppcheck.
2014-04-02 21:10:26 +01:00
Michael Drake
979b59887f
Fix leak of url found by cppcheck.
2014-04-02 21:04:00 +01:00
Michael Drake
a9fb42e71b
Fix leak of filename found by cppcheck.
2014-04-02 21:03:13 +01:00
Michael Drake
442d1cb3cf
Fix out of bounds array accesses for Cyrillic2 found by cppcheck.
2014-04-02 21:00:48 +01:00
Vincent Sanders
6f9a93e332
fix formatting of defaults makefiles
2014-03-20 11:05:39 +00:00
Vincent Sanders
4d4d74c8cd
move page search gui callbacks to their own operations table
2014-03-18 22:32:52 +00:00
Vincent Sanders
87f6314dab
move scheduleing into browser operation table
2014-03-09 15:37:40 +00:00
Michael Drake
a38a63a37e
Make history internal to browser_window module.
2014-02-15 18:44:50 +00:00
Michael Drake
49bed056dd
Make browser_window_navigate (un)verifiable flag match browser_window_create.
2014-02-10 22:40:04 +00:00
Michael Drake
af014bce99
Allow tab creation without history clone. Changes browser_window_create and browser_window_navigate flags.
2014-02-10 14:08:45 +00:00
Michael Drake
ea79e85fcd
Clean up gui_window creation API.
2014-02-09 13:07:39 +00:00
Michael Drake
3d7cd77982
Simplify local history interface.
2014-02-08 22:43:54 +00:00
Michael Drake
6ccf13839b
Use API to get extents.
2014-02-08 20:07:00 +00:00
Michael Drake
11b152c915
Remove unused variable.
2014-02-08 17:16:32 +00:00
Michael Drake
8deb9ec25c
Native select menu interface shouldn't force front end to dig inside bw struct.
2014-02-08 17:11:55 +00:00
Vincent Sanders
abb37ba148
fix remaining include errors
2014-02-03 18:23:02 +00:00
Vincent Sanders
59eaaf3015
fixup missing includes
2014-02-03 18:12:44 +00:00
Vincent Sanders
236e135d63
fix missing stdlib include
2014-02-01 22:56:23 +00:00
Vincent Sanders
7798dae86a
fix missing includes
2014-02-01 22:44:43 +00:00
Vincent Sanders
886a3106db
move utf8 local conversion operations to table
2014-02-01 22:17:36 +00:00
Vincent Sanders
1f62b5a980
make the clipboard operation table and members static to textselection module and cleanup unnecessary includes
2014-02-01 10:45:20 +00:00
Vincent Sanders
356461244e
Merge remote-tracking branch 'origin/stevef/menus'
2014-01-31 18:46:45 +00:00
Vincent Sanders
f99b17ae89
bump the maximum number of nodes in the doxygen documentation and fix a couple of small documentation errors
2014-01-29 23:58:41 +00:00
Vincent Sanders
aaecf9e1af
add missing include for neturf_quit symbol
2014-01-29 23:36:59 +00:00
Vincent Sanders
e353973518
fix missing includes
2014-01-29 21:58:46 +00:00
Steve Fryatt
0114cc825d
Provide a dedicated interface for destroying open menus.
...
Add ro_gui_menu_destroy(), so that this specific task does not share the same code as the more general task of tidying up after menus have been closed by other means.
The original ro_gui_menu_closed() now simply cleans up from a known (or assumed) closure, without forcing a closure itself.
2014-01-29 16:54:34 +00:00
Steve Fryatt
849bb5911c
Don't poll when converting a menu to a dialogue, as the resulting Message_MenusDeleted no longer kills any newly-opened menus.
2014-01-28 23:59:51 +00:00
Steve Fryatt
654b25ffa1
Improve handling of Message_MenusDeleted so that we don't close whatever menu tree is open at the time.
2014-01-28 23:58:42 +00:00
Vincent Sanders
7cb0619fe8
fix dumb typos from utf8 error return refactor
2014-01-28 22:39:25 +00:00
Vincent Sanders
654da2ffb5
move utf8 conversion routines to use nserror instead of their own error enum
2014-01-28 21:40:13 +00:00
Steve Fryatt
27fdcb90f2
Update copyright dates in modified files.
2014-01-26 16:28:56 +00:00
Steve Fryatt
cdc4041942
Add belt and braces to ensure that URL Bar content is always cleanly terminated.
2014-01-26 15:15:49 +00:00
Steve Fryatt
def97156d3
Make Open URL dialogue allocate memory for the URL field.
...
Add global constant for URL length, to manage both URL Bar and Open URL.
2014-01-26 14:35:57 +00:00
Steve Fryatt
89992958d2
Increase maximum size of a URL in the URL Bar to 2047 characters plus terminator.
2014-01-26 13:41:41 +00:00
Steve Fryatt
0ab5fe7c02
Improve URL handling in URL Bar.
...
Rationalise handling of UTF8, so that URLs are always converted into local encoding even if there is no URL icon present.
In addition, make preliminary hotlist test in set_url() use local encoding, in line with all subsequent checks.
Make handling of over-length URLs more sensible: warn user and completely blank the URL bar.
2014-01-26 13:30:08 +00:00
Vincent Sanders
dc074042e9
fix errors in url_to_path tfetch table changes
2014-01-25 23:21:28 +00:00
Vincent Sanders
8ce0a10670
move path_to_url and url_to_path to fetch operation table
2014-01-25 23:01:32 +00:00
Vincent Sanders
0475693394
create table for fetcher operations and move all operations into it
2014-01-23 00:00:18 +00:00
Vincent Sanders
54b7482f78
fix up riscos build errors
2014-01-16 14:28:25 +00:00
Vincent Sanders
a1361f22b4
Merge branch 'vince/guivtable'
2014-01-16 13:37:14 +00:00
Vincent Sanders
a2247a75a3
cleanup copyright headers and some doc comments
2014-01-16 13:24:14 +00:00
John-Mark Bell
444d3ac94a
Silence warning
2014-01-16 01:35:51 +00:00
Vincent Sanders
d47fed4524
move 401 login into operation table
2014-01-16 00:52:17 +00:00
Vincent Sanders
38cb39339a
move filename_from_path and path_add_part into gui operation tables
2014-01-16 00:01:25 +00:00
Vincent Sanders
bd065d4a43
split browser gui operations up
2014-01-15 19:37:05 +00:00
Vincent Sanders
0075eab194
move remaining gui operations to table
2014-01-14 23:31:54 +00:00
Vincent Sanders
8dfe225153
move download operations to download table
2014-01-14 16:04:02 +00:00
Vincent Sanders
d18c8ed452
move teh final optional window operations into the table
2014-01-13 22:54:19 +00:00
Vincent Sanders
e82d83f184
move four more optional window operations to table
2014-01-13 14:51:27 +00:00
Vincent Sanders
d70e371cd9
move two more mandantory window operations to table
2014-01-13 11:38:35 +00:00
Vincent Sanders
7227c29bba
move window scroll getter and setter into operations table
2014-01-13 01:08:15 +00:00
Vincent Sanders
5a962586fb
move mandantory window update and redraw operations into table
2014-01-12 23:50:54 +00:00
Vincent Sanders
4b49b4ac77
move more optional window operations into table including removing unused hide_pointer operation altogether
2014-01-12 22:55:26 +00:00
Vincent Sanders
b7736bae2f
split gui operations into core and window and move more operations into tables
2014-01-12 17:07:34 +00:00
Vincent Sanders
56bb9582b1
move set title, set url, start and stop throbber window operations to gui table
2014-01-12 10:27:41 +00:00
Vincent Sanders
c8496df3df
move window creation and destruction into table
2014-01-11 22:34:12 +00:00
Vincent Sanders
d3c392c3d3
Initial conversion of netsurf gui to callback vtable
2014-01-11 14:20:30 +00:00
Daniel Silverstone
692d4a328c
Fix some log statements
2014-01-05 17:22:30 +00:00
Rob Kendrick
550c8cd73c
Change gui_file_gadget_interface to pass gui_window not browser_window, add GTK implementation that of course does not work.
2014-01-05 16:45:32 +00:00
Rob Kendrick
d8ad3b8e78
Add new gui entry point for file open dialogue requests
2014-01-05 16:01:03 +00:00
Rob Kendrick
1bd4a34a27
Remove asserts for default cases from all content message handlers; this is laborious and is no longer useful for catching bugs.
2014-01-05 14:39:08 +00:00
Vincent Sanders
a1725caf86
fix mngectony makefiles
2014-01-04 18:08:08 +00:00
Vincent Sanders
f7916866e3
remove all references to using libMNG
2014-01-04 17:07:11 +00:00
Steve Fryatt
bf8c88dbec
Update copyright header dates for recent commits.
2014-01-02 22:25:23 +00:00
Steve Fryatt
286ee3834c
In framesets, F8 views source for frame under pointer if applicable.
2014-01-02 22:22:18 +00:00
Steve Fryatt
ea28b07cae
Add confirm_hotlist_remove option to allow users to turn URL removal query off.
2013-12-31 16:57:47 +00:00
Steve Fryatt
6041089169
Implement user confirmation before removing hotlist entries from the URL bar.
2013-12-31 16:45:32 +00:00
Steve Fryatt
56b0465e88
Add default clause to squash compiler warning.
2013-12-31 15:10:10 +00:00
Steve Fryatt
2506471b34
Fix broken dragging mouse pointer introduced in mouse tracking changes.
2013-12-30 17:29:46 +00:00
Steve Fryatt
20b3d960e5
Remove excessive logging from hotlist code.
2013-12-30 17:04:54 +00:00
Steve Fryatt
5c25b2e47d
Provide some interactive help for the URL Bar's favicon and hotlist indicator.
2013-12-30 16:38:27 +00:00
Steve Fryatt
f64c8ed9ef
Update the URL hotlist icon when entries are deleted from the hotlist.
...
This does not currently spot entries which are edited.
2013-12-30 16:20:37 +00:00
Steve Fryatt
6300c7ed90
Tidy up hotlist icon interfaces and make consistant with rest of toolbar.
2013-12-30 15:41:38 +00:00
Steve Fryatt
1019692b88
Fix indentation.
2013-12-30 12:44:07 +00:00
Steve Fryatt
b8dd4f282b
Bring hotlist icon event handling in line with other toolbar actions.
...
- Make hotlist icon return click events to clients.
- Move URL add and remove code into browser window toolbar event handler.
- Pass hotlist icon URL add/remove via RISC OS hotlist interface.
2013-12-30 12:36:24 +00:00
Steve Fryatt
f825521072
Fix hotlist icon in browser URL bar.
...
- Change URL container to Double/Click/Drag so that mouse actions get passed on.
- Correctly parse return code from hotlist_add_url() to identify successful adds.
2013-12-29 21:39:23 +00:00
Michael Drake
d5062bd9f9
Make view source menu option open the frame source, rather than frameset.
2013-12-19 13:53:33 +00:00
Michael Drake
eea3492266
Update hotlist indicator when current page is added to hotlist.
2013-11-23 15:30:26 +00:00
Michael Drake
24d0916778
Make RO hotlist add function take nsurl.
2013-11-22 18:19:20 +00:00
Michael Drake
68a4fe32d0
Remove forward declarations.
2013-11-22 13:02:45 +00:00
Michael Drake
dbd70b1e47
Flag a TODO.
2013-11-22 12:04:46 +00:00
Michael Drake
d13b91b247
Always show hotlist indicator.
2013-11-22 11:58:53 +00:00