Commit Graph

12231 Commits

Author SHA1 Message Date
Vincent Sanders
7d4d500c1d Revert "Fix memory leak in error handling"
This reverts commit c53be10892.

Issue tracked in bug 2443
2016-03-16 08:36:36 +00:00
Michael Drake
6f2fe0af47 Remove unused #includes. 2016-03-15 13:48:31 +00:00
Vincent Sanders
c53be10892 Fix memory leak in error handling
error handling during form gadget construction could leak, this fixes
the leak on error. Fixes coverity CID 1109875
2016-03-14 15:54:10 +00:00
Dave Higton
fdbb413403 Fix RISC OS relocatable module checks
Several relocatable modules are distributed with the RISC OS
version. The !Run file checks for their presence and version
number. However, if the check fails, the user is referred to dead
links.

This fixes this to requested an update to the !System folder from the
NS archive, using the Configure app.

Closes: 2441
2016-03-14 15:24:37 +00:00
Vincent Sanders
3dca38cf98 Avoid null dereference in gtk resource handling
Ensure the error handling in gtk pixmap resource handling does not
cause a null pointer dereference. Fixes coverity CID 1307743
2016-03-14 15:03:39 +00:00
Vincent Sanders
1ace8538d1 Fix possible dereference of NULL
The return of calloc was not being checked and could have lead to a
NULL pointer dereference. This fixes coverity CID 1316337

Additionally the functions documentation comments were cleaned up.
2016-03-14 14:19:43 +00:00
Vincent Sanders
c45afb6a29 Clean up gtk login window
This fixes coverity ID 1316338 by dealing with memory and window
creation errors properly.

Previously such errors could seg fault or leave the browser navigation
logic "stuck" waiting for user input to a window that never existed.

The code was also refactored to remove forward declarations and add
documentation comments.
2016-03-14 14:02:48 +00:00
Vincent Sanders
1d7b305db9 fixup nsurl handling to avoid locale specific character type implementation 2016-03-14 13:01:06 +00:00
Vincent Sanders
875fc5381e Merge branch 'vince/themectomy'
Remove broken GTK theme code
2016-03-10 13:30:44 +00:00
Vincent Sanders
571af764a5 completely remove remaining GTK theme code
Removes the theme code from GTK by moving the small remaining parts to
being implementation details within the toolbar implementation.
2016-03-09 11:37:09 +00:00
Vincent Sanders
8ee04cf68f remove unused theme ui elements from preferances dialog 2016-03-09 09:07:33 +00:00
Vincent Sanders
4e59843040 remove unrequired path globals 2016-03-09 09:04:50 +00:00
Vincent Sanders
68b1d2da55 remove theme option 2016-03-08 17:48:16 +00:00
Vincent Sanders
1e2584aa14 add missing arrow down pixmap resource 2016-03-08 15:58:48 +00:00
Vincent Sanders
5e604235e4 Initial pass removing gtk frontend theme code 2016-03-08 15:45:28 +00:00
Chris Young
6991a42cdd Remove excess debug 2016-03-02 23:57:44 +00:00
Chris Young
37c0dcc1c5 Tweak #ifdefs so that OS3 build mostly works on OS4, to aid debugging. 2016-03-02 23:53:25 +00:00
Chris Young
da8d9885d5 debug 2016-03-02 23:47:49 +00:00
Chris Young
cd1800187e Set OS version to the disk-based version, as Installer by default reads the ROM version... which is v40 and indistinguishable between 3.1 and 3.5/9. 2016-03-02 23:44:00 +00:00
Chris Young
3a962a84c5 Fix OS4 build 2016-03-02 23:35:06 +00:00
Chris Young
2e958f4a4d Fix OS3 button disabling
Testing reveals OS3's button.gadget doesn't support OM_GET for GA_Disabled.
In addition, we fix OS4's boolean comparisons to ensure we only check against FALSE and !FALSE
2016-02-29 23:06:10 +00:00
Chris Young
64575f2aed Avoid some crashing by disabling the update of the hotlist menu
This will be fixed properly when the menu code is re-written to use menuclass, as that supports dynamic updates.
2016-02-29 18:10:45 +00:00
Michael Drake
618e4570ef Fix copyrights. 2016-02-29 11:28:31 +00:00
Chris Young
3e9fe9b8ae Add our own NewObject() function for OS3 and enable optimisations 2016-02-29 00:11:38 +00:00
Chris Young
2108697533 Fix copying of the wrong .readme during installation.
Abort with a message if the archive doesn't match the OS version.
2016-02-28 11:26:19 +00:00
Chris Young
55b9a12785 Add a warning for OS3 for a non-working function 2016-02-25 19:50:53 +00:00
Chris Young
829642e8f7 Comment all of bitmap_render out for OS3 to see if it resolves a crash
This function doesn't work on OS3 anyway!
2016-02-25 19:48:28 +00:00
Michael Drake
924e35af08 RISC OS: Run git date setter over distributed files for merging. 2016-02-21 22:17:36 +00:00
Michael Drake
5d0a6b8f1d RISC OS: Updated SharedUnixLibrary.
New version from here:
  http://www.riscos.info/downloads/gccsdk/gcc-4.7.4-release-2/
2016-02-21 22:03:17 +00:00
Vincent Sanders
6a4efa35f8 update gtk resource path setting to use makefile variable 2016-02-20 18:37:50 +00:00
Michael Drake
592ff0ef76 Spidermonkey isn't needed. 2016-02-19 20:18:51 +00:00
Chris Young
1828079518 Fix a critical bug in the Amiga frontend which causes NetSurf to never exit.
Avoids looping trying to close a screen for which we are not the owner.
Moves the screen close to the very end of the code so if our own screen doesn't close we can still re-launch NetSurf.
2016-02-19 18:41:04 +00:00
Michael Drake
ebfcc6d9a9 Add script for setting files to git last touched date.
This may help with whatever issue is causing a problem with RISC OS
!Boot and !System distributions.

From the base of the netsurf repo, you can run it like this:

  $ ./utils/git-date.sh riscos/distribution/
2016-02-19 15:25:06 +00:00
Chris Young
00a0be2698 Update some Amiga-specific version numbers for post-3.4 2016-02-17 23:19:30 +00:00
Vincent Sanders
df28737bff update version info for next development cycle 2016-02-16 13:38:33 +00:00
Vincent Sanders
f34d815872 Merge branch 'heads/release/3.4' 2016-02-16 13:37:48 +00:00
Vincent Sanders
334873cb80 Update version for 3.4 release 2016-02-16 13:30:38 +00:00
Vincent Sanders
f077e81fcb Update copyright year 2016-02-16 13:24:47 +00:00
Vincent Sanders
8915a49b3f setup flags for building monkey on RISC OS 2016-02-15 15:16:23 +00:00
Vincent Sanders
eaed6b1dda Use compiler environment to control riscos header usage
Instead of relying on building the RISC OS frontend to determine correct
include compatability use the compiler __riscos__ macro.
2016-02-15 15:00:57 +00:00
Vincent Sanders
b9f58cdf77 allow passing of CFLAGS into make from environment 2016-02-15 14:59:23 +00:00
Michael Drake
d39531ff55 Ensure fetch attempts is not reduced to less than 1. 2016-02-15 11:06:37 +00:00
Michael Drake
6b57c94012 Return to original timeouts for now: One 30s attempt. 2016-02-15 09:58:52 +00:00
Michael Drake
c207216fa2 Fix constraints on curl_fetch_timeout option.
5 <= n <= 60 seconds.
2016-02-15 09:55:57 +00:00
Chris Young
3b57ce1013 Free shared_pens list on tree destroy 2016-02-14 15:42:58 +00:00
Chris Young
86247eea59 Don't re-use freed shared_pens list 2016-02-14 15:08:12 +00:00
Chris Young
097da50977 Remove old #define 2016-02-14 15:02:46 +00:00
Chris Young
df7bd6e07d Limit hotlist menu entries to 100 chars 2016-02-14 15:02:04 +00:00
Chris Young
a1beeda9da Make hotlist buttons show the URL as a HelpHint 2016-02-14 14:48:41 +00:00
Chris Young
bb4b602148 Limit hotlist buttons to 20 chars 2016-02-14 14:45:28 +00:00