Commit Graph

14002 Commits

Author SHA1 Message Date
Vincent Sanders
92fff918cc fix "may be used uninitialised" warning 2019-11-06 08:23:27 +00:00
Vincent Sanders
cbb0c05258 remove unecessary user warning calls and improve error propogation in html box 2019-11-05 23:05:42 +00:00
Vincent Sanders
78aa34e5d7 remove user warnings from hotlist load and curl poll 2019-11-05 00:07:06 +00:00
Vincent Sanders
7c63f5f66b improve error returns throughout complete save and remove user warnings 2019-11-04 23:39:13 +00:00
Vincent Sanders
44574d800f remove spurious whitespace in fetch error pages 2019-11-04 11:47:30 +00:00
Vincent Sanders
4eb06ad2cf move the fallback text for about handler into messages handler 2019-10-30 21:33:27 +00:00
Vincent Sanders
4b0c3f0efe add internal query handler for fetch errors
Any errors from the fetch which are not already handled are
  reported with an internal query page instead of a modal
  dialog.

This is much less invasive for the user and much more in
  keeping with how this is handled by other browsers.

The handler is similar to the timeout handler but the
  functionality is kept separate as it is intended timeout
  handling be extended in future.
2019-10-30 18:56:38 +00:00
Vincent Sanders
76eac19227 add internal query page for request timeouts 2019-10-29 22:29:22 +00:00
Vincent Sanders
1176ce4271 Improve timeout error messaging 2019-10-28 23:50:01 +00:00
Michael Drake
5aeca580f4 save complete: Change de-duplication to compare URLs, rather than contents.
We seem to have more than one content for the same resource.

For example:

* save `<img src="about:logo"><img src="about:logo">` as img-test.html
* run `rm -rf test-save && make && ./nsgtk img-test.html`
* ctrl+s
* save as "test-save" in the current netsurf dir.
* run `md5sum test-save/*`

before and after this commit.  The de-duplication works with URLs,
where it wasn't working with hlcache_handles or contents.
2019-10-26 12:51:17 +01:00
Michael Drake
044ddd5d43 save complete: ctx_find_content: compare contents, not hlcache_handles
There can be multiple hlcache_handles per sharable content.
2019-10-26 12:42:38 +01:00
Vincent Sanders
6e7f98787a ensure all error messages have text if not provided by caller 2019-10-25 21:43:19 +01:00
Vincent Sanders
da7c750efd fix some formatting in save complete 2019-10-24 22:21:43 +01:00
Vincent Sanders
699cc7deee ensure save_complete resources are correctly finalised before quit 2019-10-24 22:20:57 +01:00
Vincent Sanders
bb60859535 resolve leak of attribute value lwc string in complete save 2019-10-24 22:19:52 +01:00
Vincent Sanders
d0359bc957 fix save_complete usage of posix regex so it does not run off the end of strings 2019-10-21 23:44:01 +01:00
Daniel Silverstone
a5766db2b9 fetchers/curl: Restrict AUTH to BASIC
cURL will prevent channel reuse if NTLM auth is enabled because
NTLM authenticates a channel not a request.  As such we were
unable to reuse curl handles since we handed off connection
reuse to curl instead of our own handle cache.  This mitigates
the effect, though curl authors are looking at fixing it upstream
too.

Fixes: #2707

Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
2019-10-21 10:03:46 +01:00
Vincent Sanders
813d0c70fe another attempt to provide strtoull on amiga os 3 2019-10-20 16:45:00 +01:00
Vincent Sanders
640ee36cff add missing include for amiga os 3 strtoull 2019-10-20 15:36:53 +01:00
Vincent Sanders
67c1c65bf2 attempt a different fix for amiga os 3 strtoull 2019-10-20 09:48:24 +01:00
Vincent Sanders
51c2d48096 amiga os 3 does not have strtoull so use strtoul as next best thing 2019-10-20 09:34:39 +01:00
Vincent Sanders
69d31afcde fix gtk download window to cope with files larger than 2 gibibytes 2019-10-19 23:01:08 +01:00
Vincent Sanders
f64b37b29f make download core store size in at least 64bits to allow for large files 2019-10-19 19:43:00 +01:00
Vincent Sanders
e01c24cef7 improve human_friendly_bytesize to cope with sizes up to 16 exibytes 2019-10-19 18:20:00 +01:00
Vincent Sanders
a54cbb5aea commit a neatness on the gtk download window code 2019-10-16 21:51:01 +01:00
Vincent Sanders
1f0dc9dd6e fix gtk download window dereferencing boolean as pointer 2019-10-15 20:09:26 +01:00
Vincent Sanders
6e31dcaec4 ensure gtk scaffolding destruction does not create memory errors 2019-10-13 01:52:22 +01:00
Vincent Sanders
c82049eb84 improve brackets in fallback timeval macros 2019-10-12 15:41:19 +01:00
Vincent Sanders
4745fcf1c7 add regex compatability to utils and enable it for serenity OS 2019-10-12 14:50:49 +01:00
Vincent Sanders
4372104e0e fix utils configuration header ordering 2019-10-11 17:39:33 +01:00
Vincent Sanders
872c3f5ef6 Update utils configuration header to cope with serenity OS 2019-10-11 17:24:07 +01:00
Vincent Sanders
3232c85269 add timer cmp,isset and clear to fallback macros and improve file documentation 2019-10-11 17:12:53 +01:00
Vincent Sanders
5c9c1a7025 update clang format style for version 7
format i sstill not quite right. cannot get function declarations
 to split as we currently have them.
2019-10-10 18:22:23 +01:00
Vincent Sanders
8e986ae214 ensure menu resources are released
this ensures all the menu resources are freed when the containing
 window receives the destroy signal. Previously these resources
 were leaked.
2019-10-10 18:04:32 +01:00
Vincent Sanders
fed47dc35b make throbber visible in tab icon while active 2019-10-08 23:06:01 +01:00
Vincent Sanders
972e13ca3f remove unused external declaration and unecessary header use 2019-10-06 18:02:17 +01:00
Vincent Sanders
4230366818 fix toolbar visibility checkboxes initial state 2019-10-03 00:39:08 +01:00
Vincent Sanders
d2391b2dfd make the use of libutf8proc coditional
allow the browser to be compiled without libutf8proc. Without this
  library safe utf8 conversion and verification is not possible
  so the browser will loose the ability to navigate to adresses
  using the idna punycode scheme.
2019-10-03 00:28:08 +01:00
Vincent Sanders
79e406d951 alter some library defaults to rely on automatic pkg-config detection 2019-10-01 21:28:26 +01:00
Vincent Sanders
c9296f79a8 Use curl API (versions after 7.56.0) to determine if openssl is in use 2019-10-01 21:23:35 +01:00
Vincent Sanders
0a3786fed2 Allow the curl fetcher to be built without openssl.
The curl fetcher can operate without openssl library being
 available, additionaly curl itself may be compiled with a
 different TLS library.

In either case this will simply cause the "unknown" error to be
 reported for all TLS failiures and page information to lack any
 certificate information.
2019-09-30 23:57:49 +01:00
Vincent Sanders
1dd9f4f2e4 update ingored directories in gource helper 2019-09-29 22:14:05 +01:00
Vincent Sanders
ff7dd5419f clear the favicon at the beginning of navigation 2019-09-29 22:07:08 +01:00
Vincent Sanders
b37fdcd7e2 re-indent browser window and cleanup comments
no functional change
2019-09-29 21:46:23 +01:00
Vincent Sanders
ca20dab9cf fix toolbar visibility checkboxes initial state 2019-09-22 11:58:23 +01:00
Vincent Sanders
f3cb3188c6 fix gtk install target 2019-09-21 22:16:45 +01:00
Vincent Sanders
40aa44e4f5 make options test use build directory for temporary files rather than /tmp 2019-09-21 13:25:45 +01:00
Vincent Sanders
737a09d53e make the temporary file names unique so other tests do not overwrite them 2019-09-21 13:12:31 +01:00
Vincent Sanders
d5490be98a fix options test 2019-09-21 13:11:53 +01:00
Vincent Sanders
6c470679ee fix menu signal handler prototype 2019-09-21 10:53:41 +01:00