Commit Graph

12501 Commits

Author SHA1 Message Date
Chris Young
281fe7674c Skip setting the pen in the RastPort if it is already set to that pen
This captures the scenario when the RGBA value has changed but graphics.library has picked the same pen.
2016-03-23 23:18:05 +00:00
Chris Young
0368935cd3 Avoid nsurl NULL access 2016-03-23 00:01:45 +00:00
Chris Young
7a7d99e004 Ensure we are only accessing pixel data using amiga_bitmap_get_buffer() 2016-03-22 22:55:31 +00:00
Chris Young
8a7d030af7 Ensure we don't access invalid pointers 2016-03-22 19:45:15 +00:00
Chris Young
215d1bec58 Document new bitmap functions 2016-03-22 19:39:33 +00:00
Chris Young
4b2ac84233 Make struct bitmap private to bitmap.c 2016-03-22 19:26:36 +00:00
Chris Young
bd663be927 Apparently setting pens is a strangely complex process, so avoid it. 2016-03-22 18:45:20 +00:00
Vincent Sanders
9faef114ec Update font interface documentation to include parameter direction 2016-03-22 17:52:24 +00:00
Vincent Sanders
afc1d2c3c7 fix broken windows frontend font handling 2016-03-22 17:51:31 +00:00
Michael Drake
719dc37b22 Fix obvious bug in nsfont_split.
Was using nsfont_position_in_string instead of nsfont_width, resulting
in returning nonsense actual_x and char_offset values.
2016-03-21 14:44:01 +00:00
Michael Drake
af4d72416b Log nsfont_width failure. 2016-03-21 14:43:47 +00:00
Michael Drake
3c8e522c25 Remove printf logging. 2016-03-21 14:43:46 +00:00
Vincent Sanders
57c9034f31 Add missing resources to windows frontend 2016-03-20 21:59:16 +00:00
Vincent Sanders
78fd5ccbf6 fix new creating new window assert 2016-03-20 20:28:20 +00:00
Vincent Sanders
c2f321010a add certificate authority bundle handling to windows
The curl certificate handling on windows does not have a compiled in
default location so it is necessary to attempt to find a default
bundle.

This provides a bundle in the install and code to set it as the
default bundle location.
2016-03-20 10:24:18 +00:00
Vincent Sanders
d15ab96a51 Fix size_t printf formatting
The printf formatting for size_t is set in c99 as %zu but in windows
it is %Iu this is solved by adding and inttypes style PRI macro for size_t

This also uses this macro everywhere size_t is formatted.
2016-03-17 22:00:54 +00:00
Vincent Sanders
232cda5317 Update CA bundle 2016-03-17 22:00:54 +00:00
Chris Young
876a472454 OS3 compatible language mappings 2016-03-16 23:27:33 +00:00
Vincent Sanders
69d9d5dd22 frontends should not call the reformat API directly
The reformat API locking semantics are challenging to understand,
efectiveky browser_window_reformat should never be called by frontend
code directly except explicitly on the reformat callback. Otherwise
the content may already be locked and the system winds up asserting.
2016-03-16 21:07:14 +00:00
Vincent Sanders
06c84a26e9 remove unecessary header inclusion 2016-03-16 09:31:19 +00:00
Vincent Sanders
7d4d500c1d Revert "Fix memory leak in error handling"
This reverts commit c53be10892.

Issue tracked in bug 2443
2016-03-16 08:36:36 +00:00
Michael Drake
6f2fe0af47 Remove unused #includes. 2016-03-15 13:48:31 +00:00
Vincent Sanders
c53be10892 Fix memory leak in error handling
error handling during form gadget construction could leak, this fixes
the leak on error. Fixes coverity CID 1109875
2016-03-14 15:54:10 +00:00
Dave Higton
fdbb413403 Fix RISC OS relocatable module checks
Several relocatable modules are distributed with the RISC OS
version. The !Run file checks for their presence and version
number. However, if the check fails, the user is referred to dead
links.

This fixes this to requested an update to the !System folder from the
NS archive, using the Configure app.

Closes: 2441
2016-03-14 15:24:37 +00:00
Vincent Sanders
3dca38cf98 Avoid null dereference in gtk resource handling
Ensure the error handling in gtk pixmap resource handling does not
cause a null pointer dereference. Fixes coverity CID 1307743
2016-03-14 15:03:39 +00:00
Vincent Sanders
1ace8538d1 Fix possible dereference of NULL
The return of calloc was not being checked and could have lead to a
NULL pointer dereference. This fixes coverity CID 1316337

Additionally the functions documentation comments were cleaned up.
2016-03-14 14:19:43 +00:00
Vincent Sanders
c45afb6a29 Clean up gtk login window
This fixes coverity ID 1316338 by dealing with memory and window
creation errors properly.

Previously such errors could seg fault or leave the browser navigation
logic "stuck" waiting for user input to a window that never existed.

The code was also refactored to remove forward declarations and add
documentation comments.
2016-03-14 14:02:48 +00:00
Vincent Sanders
1d7b305db9 fixup nsurl handling to avoid locale specific character type implementation 2016-03-14 13:01:06 +00:00
Vincent Sanders
875fc5381e Merge branch 'vince/themectomy'
Remove broken GTK theme code
2016-03-10 13:30:44 +00:00
Vincent Sanders
571af764a5 completely remove remaining GTK theme code
Removes the theme code from GTK by moving the small remaining parts to
being implementation details within the toolbar implementation.
2016-03-09 11:37:09 +00:00
Vincent Sanders
8ee04cf68f remove unused theme ui elements from preferances dialog 2016-03-09 09:07:33 +00:00
Vincent Sanders
4e59843040 remove unrequired path globals 2016-03-09 09:04:50 +00:00
Vincent Sanders
68b1d2da55 remove theme option 2016-03-08 17:48:16 +00:00
Vincent Sanders
1e2584aa14 add missing arrow down pixmap resource 2016-03-08 15:58:48 +00:00
Vincent Sanders
5e604235e4 Initial pass removing gtk frontend theme code 2016-03-08 15:45:28 +00:00
Chris Young
6991a42cdd Remove excess debug 2016-03-02 23:57:44 +00:00
Chris Young
37c0dcc1c5 Tweak #ifdefs so that OS3 build mostly works on OS4, to aid debugging. 2016-03-02 23:53:25 +00:00
Chris Young
da8d9885d5 debug 2016-03-02 23:47:49 +00:00
Chris Young
cd1800187e Set OS version to the disk-based version, as Installer by default reads the ROM version... which is v40 and indistinguishable between 3.1 and 3.5/9. 2016-03-02 23:44:00 +00:00
Chris Young
3a962a84c5 Fix OS4 build 2016-03-02 23:35:06 +00:00
Chris Young
2e958f4a4d Fix OS3 button disabling
Testing reveals OS3's button.gadget doesn't support OM_GET for GA_Disabled.
In addition, we fix OS4's boolean comparisons to ensure we only check against FALSE and !FALSE
2016-02-29 23:06:10 +00:00
Chris Young
64575f2aed Avoid some crashing by disabling the update of the hotlist menu
This will be fixed properly when the menu code is re-written to use menuclass, as that supports dynamic updates.
2016-02-29 18:10:45 +00:00
Michael Drake
618e4570ef Fix copyrights. 2016-02-29 11:28:31 +00:00
Chris Young
3e9fe9b8ae Add our own NewObject() function for OS3 and enable optimisations 2016-02-29 00:11:38 +00:00
Chris Young
2108697533 Fix copying of the wrong .readme during installation.
Abort with a message if the archive doesn't match the OS version.
2016-02-28 11:26:19 +00:00
Chris Young
55b9a12785 Add a warning for OS3 for a non-working function 2016-02-25 19:50:53 +00:00
Chris Young
829642e8f7 Comment all of bitmap_render out for OS3 to see if it resolves a crash
This function doesn't work on OS3 anyway!
2016-02-25 19:48:28 +00:00
Michael Drake
924e35af08 RISC OS: Run git date setter over distributed files for merging. 2016-02-21 22:17:36 +00:00
Michael Drake
5d0a6b8f1d RISC OS: Updated SharedUnixLibrary.
New version from here:
  http://www.riscos.info/downloads/gccsdk/gcc-4.7.4-release-2/
2016-02-21 22:03:17 +00:00
Vincent Sanders
6a4efa35f8 update gtk resource path setting to use makefile variable 2016-02-20 18:37:50 +00:00