mirrors
/
netsurf
mirror of https://github.com/netsurf-browser/netsurf
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Some more asserts to try and help spot multiple-release of llcache handles 

svn path=/trunk/netsurf/; revision=10327
This commit is contained in:
Daniel Silverstone 2010-04-09 00:06:36 +00:00
parent dc3ce6372f
commit dfae5c33d2
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
content/llcache.c
View File

@ -474,7 +474,10 @@ nserror llcache_object_user_destroy(llcache_object_user *user)
#ifdef LLCACHE_TRACE #ifdef LLCACHE_TRACE
LOG(("Destroyed user %p", user)); LOG(("Destroyed user %p", user));
#endif #endif
assert(user->next == NULL);
assert(user->prev == NULL);
free(user); free(user);
return NSERROR_OK; return NSERROR_OK;
@ -996,6 +999,9 @@ nserror llcache_object_destroy(llcache_object *object)
nserror llcache_object_add_user(llcache_object *object, nserror llcache_object_add_user(llcache_object *object,
llcache_object_user *user) llcache_object_user *user)
{ {
assert(user->next == NULL);
assert(user->prev == NULL);
user->handle.object = object; user->handle.object = object;
user->prev = NULL; user->prev = NULL;
@ -1022,7 +1028,9 @@ nserror llcache_object_add_user(llcache_object *object,
nserror llcache_object_remove_user(llcache_object *object, nserror llcache_object_remove_user(llcache_object *object,
llcache_object_user *user) llcache_object_user *user)
{ {
assert(object->users); assert(object->users != NULL);
assert(user->handle.object = object);
assert((user->next != NULL) || (user->prev != NULL) || (object->users == user));
if (user == object->users) if (user == object->users)
object->users = user->next; object->users = user->next;
@ -1031,7 +1039,11 @@ nserror llcache_object_remove_user(llcache_object *object,
if (user->next != NULL) if (user->next != NULL)
user->next->prev = user->prev; user->next->prev = user->prev;
#ifndef NDEBUG
user->next = user->prev = NULL;
#endif
#ifdef LLCACHE_TRACE #ifdef LLCACHE_TRACE
LOG(("Removing user %p from %p", user, object)); LOG(("Removing user %p from %p", user, object));
#endif #endif
@ -1084,7 +1096,7 @@ nserror llcache_object_remove_from_list(llcache_object *object,
* Determine if a low-level cache object resides in a given list * Determine if a low-level cache object resides in a given list
* *
* \param object Object to search for * \param object Object to search for
* \param list List to search in * \param list List to search in
* \return True if object resides in list, false otherwise * \return True if object resides in list, false otherwise
*/ */
bool llcache_object_in_list(const llcache_object *object, bool llcache_object_in_list(const llcache_object *object,