mirrors/netsurf
1
0
Fork 0
mirror of https://github.com/netsurf-browser/netsurf synced 2024-12-23 20:46:50 +03:00
Code Issues Packages Projects Releases Wiki Activity

use ascii processing when determining form charset

Browse Source
This commit is contained in:
Vincent Sanders 2016-09-12 22:43:39 +01:00
parent 9d858085c3
commit ca12878c2f
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
render/form.c
View File

@ -26,7 +26,6 @@
*/ */
#include <assert.h> #include <assert.h>
#include <ctype.h>
#include <limits.h> #include <limits.h>
#include <stdbool.h> #include <stdbool.h>
#include <stdio.h> #include <stdio.h>
@ -40,6 +39,7 @@
#include "utils/url.h" #include "utils/url.h"
#include "utils/utf8.h" #include "utils/utf8.h"
#include "utils/utils.h" #include "utils/utils.h"
#include "utils/ascii.h"
#include "content/fetch.h" #include "content/fetch.h"
#include "content/hlcache.h" #include "content/hlcache.h"
#include "css/utils.h" #include "css/utils.h"
@ -980,8 +980,9 @@ char *form_acceptable_charset(struct form *form)
return NULL; return NULL;
/* make it upper case */ /* make it upper case */
for (c = temp; *c; c++) for (c = temp; *c; c++) {
*c = toupper(*c); *c = ascii_to_upper(*c);
}
/* is UTF-8 specified? */ /* is UTF-8 specified? */
c = strstr(temp, "UTF-8"); c = strstr(temp, "UTF-8");
@ -997,14 +998,14 @@ char *form_acceptable_charset(struct form *form)
* form element contains a space and/or comma separated list */ * form element contains a space and/or comma separated list */
c = form->accept_charsets; c = form->accept_charsets;
/* What would be an improvement would be to choose an encoding /** \todo an improvement would be to choose an encoding
* acceptable to the server which covers as much of the input * acceptable to the server which covers as much of the input
* values as possible. Additionally, we need to handle the case * values as possible. Additionally, we need to handle the
* where none of the acceptable encodings cover all the textual * case where none of the acceptable encodings cover all the
* input values. * textual input values. For now, we just extract the first
* For now, we just extract the first element of the charset list * element of the charset list
*/ */
while (*c && !isspace(*c)) { while (*c && !ascii_is_space(*c)) {
if (*c == ',') if (*c == ',')
break; break;
c++; c++;