mirrors/netsurf
1
0
Fork 0
mirror of https://github.com/netsurf-browser/netsurf synced 2024-11-26 16:29:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

page-info: Provide support to indicate if action did something

Browse Source 
Some mouse actions perform a positive action (such as opening
the SSL certificate viewer).  As such, provide an out param
which will be set to true if the action did something.  This
parameter is not touched in the case of nothing happening in
case it is used in alternating logic in the caller.

Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
This commit is contained in:
Daniel Silverstone 2020-05-08 20:39:53 +01:00
parent b39db1dac4
commit b426623258
No known key found for this signature in database
GPG Key ID: C30DF439F2987D74
2 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
desktop/page-info.c
View File

@ -664,12 +664,14 @@ cleanup:
* \param[in] pi The page info window handle.
* \param[in] mouse The current mouse state.
* \param[in] clicked The page info window entry to consider clicks on.
* \param[out] did_something Set to true if this click did something
* \return NSERROR_OK on success, appropriate error code otherwise.
*/
static nserror page_info__handle_item_click(
struct page_info *pi,
enum browser_mouse_state mouse,
enum pi_entry clicked)
enum pi_entry clicked,
bool *did_something)
{
nserror err;
@ -680,9 +682,11 @@ static nserror page_info__handle_item_click(
switch (clicked) {
case PI_ENTRY_CERT:
err = browser_window_show_certificates(pi->bw);
*did_something = true;
break;
case PI_ENTRY_COOKIES:
err = browser_window_show_cookies(pi->bw);
*did_something = true;
break;
default:
err = NSERROR_OK;
@ -697,7 +701,8 @@ nserror page_info_mouse_action(
struct page_info *pi,
enum browser_mouse_state mouse,
int x,
int y)
int y,
bool *did_something)
{
int cur_y = 0;
nserror err;
@ -722,7 +727,7 @@ nserror page_info_mouse_action(
if (y >= cur_y && y < cur_y + height) {
hovering = true;
err = page_info__handle_item_click(
pi, mouse, i);
pi, mouse, i, did_something);
if (err != NSERROR_OK) {
return err;
}

4
desktop/page-info.h
View File

@ -106,13 +106,15 @@ nserror page_info_redraw(
* \param[in] mouse The current mouse state
* \param[in] x The current mouse X coordinate
* \param[in] y The current mouse Y coordinate
* \param[out] did_something Set to true if this resulted in some action
* \return NSERROR_OK on success, appropriate error code otherwise.
*/
nserror page_info_mouse_action(
struct page_info *pi,
enum browser_mouse_state mouse,
int x,
int y);
int y,
bool *did_something);
/**
* Key press handling.