mirror of
https://github.com/netsurf-browser/netsurf
synced 2024-12-22 20:16:54 +03:00
Improve 401 response handling
svn path=/trunk/netsurf/; revision=10407
This commit is contained in:
parent
b5b280dc96
commit
b008327de1
@ -29,6 +29,7 @@
|
||||
|
||||
#include "content/fetch.h"
|
||||
#include "content/llcache.h"
|
||||
#include "content/urldb.h"
|
||||
#include "desktop/options.h"
|
||||
#include "utils/log.h"
|
||||
#include "utils/messages.h"
|
||||
@ -82,7 +83,9 @@ typedef struct {
|
||||
|
||||
llcache_fetch_state state; /**< Current state of object fetch */
|
||||
|
||||
uint32_t redirect_count; /** Count of redirects followed */
|
||||
uint32_t redirect_count; /**< Count of redirects followed */
|
||||
|
||||
bool tried_with_auth; /**< Whether we've tried with auth */
|
||||
} llcache_fetch_ctx;
|
||||
|
||||
/** Cache control data */
|
||||
@ -2067,15 +2070,13 @@ nserror llcache_fetch_process_data(llcache_object *object, const uint8_t *data,
|
||||
*/
|
||||
nserror llcache_fetch_auth(llcache_object *object, const char *realm)
|
||||
{
|
||||
const char *auth;
|
||||
nserror error = NSERROR_OK;
|
||||
|
||||
/* Abort fetch for this object */
|
||||
fetch_abort(object->fetch.fetch);
|
||||
object->fetch.fetch = NULL;
|
||||
|
||||
if (query_cb != NULL) {
|
||||
llcache_query query;
|
||||
|
||||
/* Destroy headers */
|
||||
while (object->num_headers > 0) {
|
||||
object->num_headers--;
|
||||
@ -2086,6 +2087,20 @@ nserror llcache_fetch_auth(llcache_object *object, const char *realm)
|
||||
free(object->headers);
|
||||
object->headers = NULL;
|
||||
|
||||
/* If there was no realm, then default to the URL */
|
||||
/** \todo If there was no WWW-Authenticate header, use response body */
|
||||
if (realm == NULL)
|
||||
realm = object->url;
|
||||
|
||||
auth = urldb_get_auth_details(object->url, realm);
|
||||
|
||||
if (auth == NULL || object->fetch.tried_with_auth == true) {
|
||||
/* No authentication details, or tried what we had, so ask */
|
||||
object->fetch.tried_with_auth = false;
|
||||
|
||||
if (query_cb != NULL) {
|
||||
llcache_query query;
|
||||
|
||||
/* Emit query for authentication details */
|
||||
query.type = LLCACHE_QUERY_AUTH;
|
||||
query.url = object->url;
|
||||
@ -2097,7 +2112,8 @@ nserror llcache_fetch_auth(llcache_object *object, const char *realm)
|
||||
llcache_event event;
|
||||
|
||||
/* Invalidate cache-control data */
|
||||
memset(&object->cache, 0, sizeof(llcache_cache_control));
|
||||
memset(&object->cache, 0,
|
||||
sizeof(llcache_cache_control));
|
||||
/* Mark it complete */
|
||||
object->fetch.state = LLCACHE_FETCH_COMPLETE;
|
||||
|
||||
@ -2108,6 +2124,12 @@ nserror llcache_fetch_auth(llcache_object *object, const char *realm)
|
||||
|
||||
error = llcache_send_event_to_users(object, &event);
|
||||
}
|
||||
} else {
|
||||
/* Flag that we've tried to refetch with credentials, so
|
||||
* that if the fetch fails again, we ask the user again */
|
||||
object->fetch.tried_with_auth = true;
|
||||
error = llcache_object_refetch(object);
|
||||
}
|
||||
|
||||
return error;
|
||||
}
|
||||
|
Loading…
Reference in New Issue
Block a user