mirrors
/
netsurf
mirror of https://github.com/netsurf-browser/netsurf
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix visited support for libdom. (Still disabled.)

This commit is contained in:
Michael Drake 2013-05-16 18:18:06 +01:00
parent 023c014ac4
commit abebc6ae2b
1 changed files with 48 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
css/select.c
View File

@ -1552,30 +1552,52 @@ css_error node_is_visited(void *pw, void *node, bool *match)
*match = false;
/** \todo Implement visted check in a more performant way */
#ifdef SUPPORT_VISITED
nscss_select_ctx *ctx = pw;
xmlNode *n = node;
if (strcasecmp((const char *) n->name, "a") == 0) {
nscss_select_ctx *ctx = pw;
nsurl *url;
nserror error;
const struct url_data *data;
xmlChar *href = xmlGetProp(n, (const xmlChar *) "href");
if (href == NULL)
return CSS_OK;
dom_exception exc;
dom_node *n = node;
dom_string *s = NULL;
/* Make href absolute */
/* TODO: this duplicates what we do for box->href */
error = nsurl_join(ctx->base_url, (const char *)href, &url);
xmlFree(href);
if (error != NSERROR_OK) {
exc = dom_node_get_node_name(n, &s);
if ((exc != DOM_NO_ERR) || (s == NULL)) {
return CSS_NOMEM;
}
data = urldb_get_url_data(nsurl_access(url));
if (!dom_string_caseless_lwc_isequal(s, corestring_lwc_a)) {
/* Can't be visited; not ancher element */
dom_string_unref(s);
return CSS_OK;
}
/* Finished with node name string */
dom_string_unref(s);
s = NULL;
exc = dom_element_get_attribute(n, corestring_dom_href, &s);
if ((exc != DOM_NO_ERR) || (s == NULL)) {
/* Can't be visited; not got a URL */
return CSS_OK;
}
/* Make href absolute */
/* TODO: this duplicates what we do for box->href
* should we put the absolute URL on the dom node? */
error = nsurl_join(ctx->base_url, dom_string_data(s), &url);
/* Finished with href string */
dom_string_unref(s);
if (error != NSERROR_OK) {
/* Couldn't make nsurl object */
return CSS_NOMEM;
}
data = urldb_get_url_data(url);
/* Visited if in the db and has
* non-zero visit count */
@ -1583,7 +1605,6 @@ css_error node_is_visited(void *pw, void *node, bool *match)
*match = true;
nsurl_unref(url);
}
#endif
return CSS_OK;