mirrors/netsurf
1
0
Fork 0
mirror of https://github.com/netsurf-browser/netsurf synced 2025-03-12 18:13:10 +03:00
Code Issues Packages Projects Releases Wiki Activity

Canvas: Do not overrun destination bitmap during creation

Browse Source 
Signed-off-by: Daniel Silverstone <dsilvers@digital-scurf.org>
This commit is contained in:
Daniel Silverstone 2020-05-24 16:20:49 +01:00
parent 1c4025e92c
commit 74b8767ee2
No known key found for this signature in database
GPG Key ID: C30DF439F2987D74
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
content/handlers/javascript/duktape/CanvasRenderingContext2D.bnd
View File

@ -428,7 +428,7 @@ method CanvasRenderingContext2D::getImageData()
int width = duk_get_int(ctx, 2);
int height = duk_get_int(ctx, 3);
image_data_private_t *idpriv;
uint8_t *bitmap_base;
uint8_t *src_base, *dst_base;
if (priv->bitmap == NULL)
return duk_generic_error(ctx, "Canvas in bad state, sorry");
@ -456,11 +456,12 @@ method CanvasRenderingContext2D::getImageData()
/* We now have access to the imagedata private, so we need to copy
* the pixel range out of ourselves
*/
bitmap_base = guit->bitmap->get_buffer(priv->bitmap);
src_base = guit->bitmap->get_buffer(priv->bitmap);
dst_base = idpriv->data;
for (int yy = y; yy < (y+height); ++yy) {
uint8_t *src_base = bitmap_base + (priv->stride * yy);
uint8_t *dst_base = idpriv->data + (width * 4);
memcpy(dst_base + (x * 4), src_base + (x * 4), width * 4);
memcpy(dst_base, src_base + (x * 4), width * 4);
src_base += priv->stride;
dst_base += (width * 4);
}
return 1;
%}