From 6a1c64ff7b45dd830bfdb5e1295830b75c531f61 Mon Sep 17 00:00:00 2001
From: Vincent Sanders <vince@kyllikki.org>
Date: Tue, 6 Aug 2019 10:07:02 +0100
Subject: [PATCH] improve css formatting in about scheme query handlers

---
 content/fetchers/about.c |  7 ++++---
 resources/internal.css   | 29 +++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+), 3 deletions(-)

diff --git a/content/fetchers/about.c b/content/fetchers/about.c
index b922708a9..2cbb60407 100644
--- a/content/fetchers/about.c
+++ b/content/fetchers/about.c
@@ -737,6 +737,9 @@ static bool fetch_about_query_auth_handler(struct fetch_about_context *ctx)
 			"<h1>%s</h1>\n",
 			title, title);
 
+	slen += snprintf(buffer + slen, sizeof(buffer) - slen,
+			 "<form method=\"post\" enctype=\"multipart/form-data\">");
+
 	res = get_login_description(siteurl,
 				    realm,
 				    username,
@@ -749,8 +752,6 @@ static bool fetch_about_query_auth_handler(struct fetch_about_context *ctx)
 		free(description);
 	}
 
-	slen += snprintf(buffer + slen, sizeof(buffer) - slen,
-			 "<form method=\"post\" enctype=\"multipart/form-data\">");
 
 	slen += snprintf(buffer + slen, sizeof(buffer) - slen,
 			 "<div>"
@@ -769,7 +770,7 @@ static bool fetch_about_query_auth_handler(struct fetch_about_context *ctx)
 			 messages_get("Password"), password);
 
 	slen += snprintf(buffer + slen, sizeof(buffer) - slen,
-			 "<div>"
+			 "<div align=\"right\">"
 			 "<input type=\"submit\" id=\"cancel\" name=\"cancel\" "
 			 "value=\"%s\">"
 			 "<input type=\"submit\" id=\"login\" name=\"login\" "
diff --git a/resources/internal.css b/resources/internal.css
index c72dfac06..f49f1bbfb 100644
--- a/resources/internal.css
+++ b/resources/internal.css
@@ -237,3 +237,32 @@ p.imagecachelist span {
 	display: table-cell;
 }
 
+/*
+ * authentication styling
+ */
+
+body#authentication form {
+  /* Just to center the form on the page */
+  margin: 0 auto;
+  width: 400px;
+  /* To see the outline of the form */
+  padding: 1em;
+  border: 1px solid #CCC;
+  border-radius: 1em;
+}
+
+body#authentication label {
+  /* To make sure that all labels have the same size and are properly aligned */
+  display: inline-block;
+  width: 90px;
+  text-align: right;
+}
+
+body#authentication input#username, body#authentication input#password {
+/* To give the same size to all text fields */
+  width: 300px;
+  box-sizing: border-box;
+
+  /* To harmonize the look & feel of text field border */
+  border: 1px solid #999;
+}