mirrors/netsurf
1
0
Fork 0
mirror of https://github.com/netsurf-browser/netsurf synced 2024-11-26 08:19:55 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix resource leak on error in local history initialisation

Browse Source
This commit is contained in:
Vincent Sanders 2017-06-12 22:58:43 +01:00
parent c4c2c22e87
commit 2b2bbbe765
1 changed files with 15 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
desktop/local_history.c
View File

@ -259,24 +259,15 @@ find_entry_position(struct history_entry *entry, int x, int y)
/* exported interface documented in desktop/local_history.h */
nserror local_history_init(struct core_window_callback_table *cw_t,
void *core_window_handle,
struct browser_window *bw,
struct local_history_session **session)
nserror
local_history_init(struct core_window_callback_table *cw_t,
void *core_window_handle,
struct browser_window *bw,
struct local_history_session **session)
{
nserror res;
struct local_history_session *nses;
nses = calloc(1, sizeof(struct local_history_session));
if (nses == NULL) {
return NSERROR_NOMEM;
}
nses->cw_t = cw_t;
nses->core_window_handle = core_window_handle;
local_history_set(nses, bw);
res = ns_system_colour_char("Window", &pstyle_bg.fill_colour);
if (res != NSERROR_OK) {
return res;
@ -297,8 +288,18 @@ nserror local_history_init(struct core_window_callback_table *cw_t,
}
pfstyle_node_sel.foreground = pstyle_rect_sel.stroke_colour;
nses = calloc(1, sizeof(struct local_history_session));
if (nses == NULL) {
return NSERROR_NOMEM;
}
nses->cw_t = cw_t;
nses->core_window_handle = core_window_handle;
local_history_set(nses, bw);
*session = nses;
return NSERROR_OK;
}