Merge branch 'dev' into dev-slice

.gitattributes

@@ -9,3 +9,4 @@
 *.patch binary
 *.dll binary
 *.lib binary
+*.exe binary

CMakeLists.txt

@@ -337,6 +337,7 @@ if (MI_BUILD_STATIC)
   endif()
 
   install(TARGETS mimalloc-static EXPORT mimalloc DESTINATION ${mi_install_objdir} LIBRARY)
+  install(EXPORT mimalloc DESTINATION ${mi_install_cmakedir})
 endif()
 
 # install include files

include/mimalloc-types.h

@@ -447,9 +447,15 @@ struct mi_heap_s {
 // Debug
 // ------------------------------------------------------
 
+#if !defined(MI_DEBUG_UNINIT)
 #define MI_DEBUG_UNINIT     (0xD0)
+#endif
+#if !defined(MI_DEBUG_FREED)
 #define MI_DEBUG_FREED      (0xDF)
+#endif
+#if !defined(MI_DEBUG_PADDING)
 #define MI_DEBUG_PADDING    (0xDE)
+#endif
 
 #if (MI_DEBUG)
 // use our own assertion to print without memory allocation

src/init.c

@@ -520,14 +520,14 @@ void mi_process_init(void) mi_attr_noexcept {
   #endif
   _mi_verbose_message("secure level: %d\n", MI_SECURE);
   mi_thread_init();
+
   #if defined(_WIN32) && !defined(MI_SHARED_LIB)
-  /* When building as a static lib the FLS cleanup happens to early for the main thread.
+  // When building as a static lib the FLS cleanup happens to early for the main thread.
-   * To avoid that set the FLS value for the main thread to NULL; the eventual
+  // To avoid this, set the FLS value for the main thread to NULL so the fls cleanup
-   * mi_fls_done() execution won't call _mi_thread_done().
+  // will not call _mi_thread_done on the (still executing) main thread. See issue #508.
-   * The latter function is later called explicitly from mi_process_done(). 
-   * See GitHub issue #508 for more background and explanation. */
   FlsSetValue(mi_fls_key, NULL);
   #endif
+
   mi_stats_reset();  // only call stat reset *after* thread init (or the heap tld == NULL)
 
   if (mi_option_is_enabled(mi_option_reserve_huge_os_pages)) {
@@ -557,9 +557,7 @@ static void mi_process_done(void) {
   process_done = true;
 
   #if defined(_WIN32) && !defined(MI_SHARED_LIB)
-  // Explicitly clean up main thread. See comment in mi_process_init() for reason
+  FlsFree(mi_fls_key);  // call thread-done on all threads (except the main thread) to prevent dangling callback pointer if statically linked with a DLL; Issue #208
-  _mi_thread_done(_mi_heap_default);
-  FlsFree(mi_fls_key);            // call thread-done on all threads to prevent dangling callback pointer if statically linked with a DLL; Issue #208
   #endif
   
   #if (MI_DEBUG != 0) || !defined(MI_SHARED_LIB)  
@@ -600,7 +598,7 @@ static void mi_process_done(void) {
     mi_process_load();
     return 0;
   }
-  typedef int(*_crt_cb)(void);
+  typedef int(*_mi_crt_callback_t)(void);
   #if defined(_M_X64) || defined(_M_ARM64)
     __pragma(comment(linker, "/include:" "_mi_msvc_initu"))
     #pragma section(".CRT$XIU", long, read)
@@ -608,7 +606,7 @@ static void mi_process_done(void) {
     __pragma(comment(linker, "/include:" "__mi_msvc_initu"))
   #endif
   #pragma data_seg(".CRT$XIU")
-  extern "C" _crt_cb _mi_msvc_initu[] = { &_mi_process_init };
+  extern "C" _mi_crt_callback_t _mi_msvc_initu[] = { &_mi_process_init };
   #pragma data_seg()
 
 #elif defined(__cplusplus)

src/region.c

@@ -94,7 +94,7 @@ typedef struct mem_region_s {
   mi_bitmap_field_t         commit;      // track if committed per block
   mi_bitmap_field_t         reset;       // track if reset per block
   _Atomic(size_t)           arena_memid; // if allocated from a (huge page) arena
-  size_t                    padding;     // round to 8 fields
+  _Atomic(size_t)           padding;     // round to 8 fields (needs to be atomic for msvc, see issue #508)
 } mem_region_t;
 
 // The region map

test/main-override.cpp

@@ -50,7 +50,7 @@ int main() {
    tsan_numa_test();
    strdup_test();
 
-  //test_mt_shutdown();
+  test_mt_shutdown();
   //fail_aslr();
   bench_alloc_large();
   mi_stats_print(NULL);
@@ -76,7 +76,7 @@ public:
 static void various_tests() {
   atexit(free_p);
   void* p1 = malloc(78);
-  void* p2 = mi_malloc_aligned(16, 24);
+  void* p2 = mi_malloc_aligned(24, 16);
   free(p1);
   p1 = malloc(8);
   char* s = mi_strdup("hello\n");