mirrors/micropython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

py/compile: Adjust c_assign_atom_expr() to use return instead of goto.

Browse Source 
Makes the flow of the function a little more obvious, and allows to reach
100% coverage of compile.c when using gcov.
This commit is contained in:
Damien George 2018-02-24 23:03:17 +11:00
parent 2ad555bc76
commit 7dfa56e40e
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
py/compile.c
View File

@ -376,6 +376,7 @@ STATIC void c_assign_atom_expr(compiler_t *comp, mp_parse_node_struct_t *pns, as
EMIT(store_subscr); EMIT(store_subscr);
} }
} }
return;
} else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) { } else if (MP_PARSE_NODE_STRUCT_KIND(pns1) == PN_trailer_period) {
assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0])); assert(MP_PARSE_NODE_IS_ID(pns1->nodes[0]));
if (assign_kind == ASSIGN_AUG_LOAD) { if (assign_kind == ASSIGN_AUG_LOAD) {
@ -387,16 +388,10 @@ STATIC void c_assign_atom_expr(compiler_t *comp, mp_parse_node_struct_t *pns, as
} }
EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0])); EMIT_ARG(store_attr, MP_PARSE_NODE_LEAF_ARG(pns1->nodes[0]));
} }
} else {
goto cannot_assign;
}
} else {
goto cannot_assign;
}
return; return;
}
}
cannot_assign:
compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression"); compile_syntax_error(comp, (mp_parse_node_t)pns, "can't assign to expression");
} }