mirrors/micropython
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

py/objmodule: Remove TODO about checking store attr to a module.

Browse Source 
The code implements correct behaviour, as tested by basics/module1.py.
This commit is contained in:
Damien George 2018-09-27 15:16:24 +10:00
parent cc5c3c64ca
commit 04f7da78db
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
py/objmodule.c
View File

@ -84,7 +84,6 @@ STATIC void module_attr(mp_obj_t self_in, qstr attr, mp_obj_t *dest) {
mp_obj_dict_delete(MP_OBJ_FROM_PTR(dict), MP_OBJ_NEW_QSTR(attr)); mp_obj_dict_delete(MP_OBJ_FROM_PTR(dict), MP_OBJ_NEW_QSTR(attr));
} else { } else {
// store attribute // store attribute
// TODO CPython allows STORE_ATTR to a module, but is this the correct implementation?
mp_obj_dict_store(MP_OBJ_FROM_PTR(dict), MP_OBJ_NEW_QSTR(attr), dest[1]); mp_obj_dict_store(MP_OBJ_FROM_PTR(dict), MP_OBJ_NEW_QSTR(attr), dest[1]);
} }
dest[0] = MP_OBJ_NULL; // indicate success dest[0] = MP_OBJ_NULL; // indicate success