mirrors/memtest86plus
1
0
Fork 0
mirror of https://github.com/memtest86plus/memtest86plus synced 2025-02-17 05:44:00 +03:00
Code Issues Packages Projects Releases Wiki Activity

efisetup: Ignore Unicode byte-order mark in command line (#421)

Browse Source 
* efisetup: Ignore Unicode byte-order mark in command line

References #418

Signed-off-by: Tormod Volden <debian.tormod@gmail.com>

* doc: Command line parameters for QEMU auto-start

The use of 0x0 instead of 0 is because of a bug in the TianoCore EDK-II
bcfg tool. Also the need to escape the " quotes with ^ seems like
another bug.

Signed-off-by: Tormod Volden <debian.tormod@gmail.com>

---------

Signed-off-by: Tormod Volden <debian.tormod@gmail.com>
This commit is contained in:
Tormod Volden 2024-11-03 14:53:24 +01:00 committed by GitHub
parent 3ce7c3fb39
commit 0736cf2112
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
boot/efisetup.c
View File

@ -179,6 +179,11 @@ static int get_cmd_line_length(efi_loaded_image_t *image)
efi_char16_t *cmd_line = (efi_char16_t *)image->load_options;
int max_length = image->load_options_size / sizeof(efi_char16_t);
int length = 0;
// Skip Unicode byte order mark if present
if (cmd_line[0] == u'\uFEFF') {
cmd_line = &cmd_line[1];
max_length--;
}
while (length < max_length && cmd_line[length] > 0x00 && cmd_line[length] < 0x80) {
length++;
}
@ -188,6 +193,9 @@ static int get_cmd_line_length(efi_loaded_image_t *image)
static void get_cmd_line(efi_loaded_image_t *image, int num_chars, char *buffer)
{
efi_char16_t *cmd_line = (efi_char16_t *)image->load_options;
if (cmd_line[0] == u'\uFEFF') {
cmd_line = &cmd_line[1];
}
for (int i = 0; i < num_chars; i++) {
buffer[i] = cmd_line[i];
}

5
doc/HOW_TO_DEBUG_WITH_GDB.md
View File

@ -46,6 +46,11 @@ and confirm with Enter.
The directory "\EFI\boot" and the file "BOOT_X64.efi" are automatically
created by the debug-script.
You can add memtest command line parameters as "optional data" to the boot entry created above, e.g. for `usbdebug`:
`bcfg boot -opt 0x0 ^"usbdebug^"`
Note the UEFI-shell escaped quotes. Alternatively you can create a UTF-16 file with the parameters, e.g. with `edit params.txt` and add its contents:
`bcfg boot -opt 0x0 FS0:\params.txt`
When you run the script the next time, memtest.efi should run without
previous user interaction.