mc/vfs
Denys Vlasenko e064bd60df De-inline a few functions which are large
...or not-so-large but nevertheless
contain more than one function call,
or contain loops, or contain if's and at least one
function call, or contain largish objects on stack.

In my experience, in those cases the code size
growth is big enough to not inline stuff.

I guess some of the really big functions
are defined inline because they have, or had in the past,
just one callsite.

But for a few years gcc already does it automatically,
no need to do it by hand and risk code size explosion
when later during code evolution another callsite
is created. This optimization by hand is simply
no longer needed.

Anyway, here is the code size difference:

   text    data     bss     dec     hex filename
 572337   17944  177820  768101   bb865 mc.t5/.obj/src/mc
 567697   17944  177820  763461   ba645 mc.t6/.obj/src/mc

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Signed-off-by: Sergei Trofimovich <slyfox@inbox.ru>
2009-08-31 07:12:59 +03:00
..
extfs Ticket #1477: incorrect detection of compressed patchfs 2009-08-24 17:41:36 +03:00
samba further include file fixups 2009-06-18 21:02:29 +04:00
.gitignore Added .svnignore files (same as .cvsignore) 2008-12-28 23:27:03 +02:00
COPYING.LGPL Update postal address of Free Software Foundation. 2005-05-27 03:35:10 +00:00
cpio.c VFS: removed unnedeed includes of tty/tty.h header. 2009-08-12 21:23:55 +04:00
direntry.c Use TTY function names instead of #define's. 2009-08-12 21:23:12 +04:00
extfs.c VFS: removed unnedeed includes of tty/tty.h header. 2009-08-12 21:23:55 +04:00
fish.c vfs/fish.c: removed unused variable 2009-08-24 09:31:26 +04:00
fish.h Simple doxygen description for files in vfs (not subdirs) directory. 2009-02-10 16:18:55 +02:00
ftpfs.c Ticket #1414: small refactoring before major modifications. 2009-08-17 15:54:39 +04:00
ftpfs.h Ticket #121 (support IPv6). 2009-08-13 00:32:26 +03:00
gc.c VFS: removed unnedeed includes of tty/tty.h header. 2009-08-12 21:23:55 +04:00
gc.h Simple doxygen description for files in vfs (not subdirs) directory. 2009-02-10 16:18:55 +02:00
HACKING Initial version of technical documentation for VFS. 2003-10-30 05:52:35 +00:00
local.c VFS: removed unnedeed includes of tty/tty.h header. 2009-08-12 21:23:55 +04:00
local.h Simple doxygen description for files in vfs (not subdirs) directory. 2009-02-10 16:18:55 +02:00
Makefile.am Fix compile mcserv helper 2009-05-27 21:50:02 +03:00
mcfs.c VFS: removed unnedeed includes of tty/tty.h header. 2009-08-12 21:23:55 +04:00
mcfs.h Simple doxygen description for files in vfs (not subdirs) directory. 2009-02-10 16:18:55 +02:00
mcfsutil.c VFS: removed unnedeed includes of tty/tty.h header. 2009-08-12 21:23:55 +04:00
mcfsutil.h Simple doxygen description for files in vfs (not subdirs) directory. 2009-02-10 16:18:55 +02:00
mcserv.c VFS: removed unnedeed includes of tty/tty.h header. 2009-08-12 21:23:55 +04:00
README remove ChangeLog files from mc tree 2009-05-27 14:53:23 +03:00
README.fish Typos. 2003-06-02 19:47:30 +00:00
sfs.c VFS: removed unnedeed includes of tty/tty.h header. 2009-08-12 21:23:55 +04:00
smbfs.c VFS: removed unnedeed includes of tty/tty.h header. 2009-08-12 21:23:55 +04:00
smbfs.h Simple doxygen description for files in vfs (not subdirs) directory. 2009-02-10 16:18:55 +02:00
tar.c VFS: removed unnedeed includes of tty/tty.h header. 2009-08-12 21:23:55 +04:00
tcputil.c Simple doxygen description for files in vfs (not subdirs) directory. 2009-02-10 16:18:55 +02:00
tcputil.h Simple doxygen description for files in vfs (not subdirs) directory. 2009-02-10 16:18:55 +02:00
undelfs.c VFS: removed unnedeed includes of tty/tty.h header. 2009-08-12 21:23:55 +04:00
utilvfs.c Ticket #121 (support IPv6). 2009-08-13 00:32:26 +03:00
utilvfs.h Simple doxygen description for files in vfs (not subdirs) directory. 2009-02-10 16:18:55 +02:00
vfs-impl.h VFS: moved vfs_translate_url() declaration to the public scope. 2009-08-24 09:31:26 +04:00
vfs.c De-inline a few functions which are large 2009-08-31 07:12:59 +03:00
vfs.h VFS: moved vfs_translate_url() declaration to the public scope. 2009-08-24 09:31:26 +04:00
xdirentry.h Simple doxygen description for files in vfs (not subdirs) directory. 2009-02-10 16:18:55 +02:00

NOTE: Although vfs has been meant to be implemented as a separate
entity redistributable under the LGPL in its current implementation it
uses GPLed code from src/. So there are two possibilities if you want
to use vfs:

1. Distribute your copy of vfs under the GPL. Then you can freely
include the GPLed functions from the rest of the mc source code.

2. Distribute your copy of vfs under the LGPL. Then you cannot include
the functions outside the vfs subdirectory. You must then either
rewrite them or work around them in other ways.

========================================================================

Hi!

I'm midnight commander's vfs layer. Before you start hacking me,
please read this file. I'm integral part of midnight commander, but I
try to go out and live my life myself as a shared library, too. That
means that I should try to use as little functions from midnight as
possible (so I'm tiny, nice and people like me), that I should not
pollute name space by unnecessary symbols (so I do not crash fellow
programs) and that I should have a clean interface between myself and
midnight.

Because I'm rather close to midnight, try to:

* Keep the indentation as the rest of the code. Following could help
you with your friend emacs:

(defun mc-c-mode ()
	"C mode with adjusted defaults for use with the Midnight commander."
	(interactive)
	(c-mode)
	(c-set-style "K&R")
	(setq	c-indent-level 4
		c-continued-statement-offset 4
		c-brace-offset 0
		c-argdecl-indent 4
		c-label-offset -4
		c-brace-imaginary-offset 0
		c-continued-brace-offset 0
		c-tab-always-indent nil
		c-basic-offset 4
		tab-width 8
		comment-column 60))

(setq auto-mode-alist (cons '(".*/mc/.*\\.[ch]$" . mc-c-mode)
                       auto-mode-alist))

And because I'm trying to live life on my own as libvfs.so, try to:

* Make sure all exported symbols are defined in vfs.h and begin with
'vfs_'.

* Do not make any references from midnight into modules like tar. It
would probably pollute name space and midnight would depend on concrete
configuration of libvfs. mc_setctl() and mc_ctl() are your
friends. (And mine too :-).

							 Pavel Machek
							 pavel@ucw.cz

PS: If you'd like to use my features in whole operating system, you
might want to link me to rpc.nfsd. On
http://atrey.karlin.mff.cuni.cz/~pavel/podfuk/podfuk.html you'll find
how to do it.

PPS: I have a friend, shared library called avfs, which is LD_PRELOAD
capable. You can reach her at http://www.inf.bme.hu/~mszeredi/avfs.