mirrors/mc
1
0
Fork 0
mirror of https://github.com/MidnightCommander/mc synced 2024-12-23 12:56:51 +03:00
Code Issues Packages Projects Releases Wiki Activity
15,743 Commits 47 Branches 83 Tags 91 MiB
f29c5a35f7
Commit Graph

507 Commits

Author SHA1 Message Date
Andrew Borodin
018687b12f Fix comments of history and panels.ini files location. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-11-06 21:06:15 +03:00
Andrew Borodin
f1cf92f435 Indentation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:55 +03:00
Andrew Borodin
ee5bf223fb (hotkey_draw): constify argument. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:55 +03:00
Andrew Borodin
d243d467a8 (widget_selectcolor): constify argument. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:55 +03:00
Andrew Borodin
afaa3f075a lib/widget/quick.h: remove unneeded #include. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:54 +03:00
Andrew Borodin
702c3634e5 Move the some stuff from dialog.[ch] to dialog-switch.[ch]: 
* variables: top_dlg, fast_refresh;
  * function: do_refresh().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:54 +03:00
Andrew Borodin
fc6cc7bfc3 lib/widget/widget-common.h: rename include guard. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:54 +03:00
Andrew Borodin
ea40129743 Menu: renames: 
WMenuBar::selected -> WMenuBar::current
  menu_t::selected -> menu_t::current

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:54 +03:00
Andrew Borodin
35b5d8e2f2 WListbox: renames: 
WListbox::pos -> WListbox::current
  listbox_select_entry() -> listbox_set_current()
  listbox_get_nth_item() -> listbox_get_nth_entry()

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:54 +03:00
Andrew Borodin
e6cb6591b3 (dlg_close): rename from dlg_stop(). 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:11 +03:00
Andrew Borodin
c157b048e5 Listbox window: rename functions. 
create_listbox_window -> listbox_window_new
create_listbox_window_centered -> listbox_window_new_centered
run_listbox -> listbox_run
run_listbox_with_data -> listbox_run_with_data

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:24 +03:00
Andrew Borodin
d9383ba8b3 (buttonbar_find): rename from find_buttonbar. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:24 +03:00
Andrew Borodin
fd2d5b49ac Menu: rename functions. 
menu_entry_create -> menu_entry_new
menu_separator_create -> menu_separator_new
create_menu -> menu_new
destroy_menu -> menu_free
find_menubar -> menubar_find

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:24 +03:00
Andrew Borodin
47da3a764a (dlg_default_destroy): send MSG_DESTROY to the dialog itself 
...to avoid various memory leaks.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:24 +03:00
Andrew Borodin
7257f794d2 Update template for .c files. 
Add section for forward declarations of local functions. This section is
located before file scope variables because functions can be used in
strucutres (see find.c for example):

/*** forward declarations (file scope functions) *************************************************/

/* button callbacks */
static int start_stop (WButton * button, int action);
static int find_do_view_file (WButton * button, int action);
static int find_do_edit_file (WButton * button, int action);

/*** file scope variables ************************************************************************/

static struct
{
    ...
    bcback_fn callback;
} fbuts[] =
{
    ...
    { B_STOP, NORMAL_BUTTON, N_("S&uspend"), 0, 0, NULL, start_stop },
    ...
    { B_VIEW, NORMAL_BUTTON, N_("&View - F3"), 0, 0, NULL, find_do_view_file },
    { B_VIEW, NORMAL_BUTTON, N_("&Edit - F4"), 0, 0, NULL, find_do_edit_file }
};

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:24 +03:00
Andrew Borodin
584fb9815c Change WDialog::data from void* to union{void*, int} 
...to use data of type other than pointer w/o extra type cast.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:23 +03:00
Andrew Borodin
c5466cd494 Don't create an empty string in WLabel objects. 
* (simple_status_msg_init_cb): pass NULL instead of "" to label_new()
    to get rid of an empty string duplication.
  * (advanced_chown_dlg_create): likewise.
  * (chown_dlg_create): likewise.
  * (dirsize_status_init_cb): likewise.
  * (file_op_context_create_ui): likewise.
  * (setup_gui): likewise.
  * (init_hotlist): likewise.
  * (init_learn): likewise.
  * (file_progress_show_source): pass NULL instead of "" to
    label_set_text() to get rid of an empty string duplication.
  * (file_progress_show_target): likewise.
  * (create_file_manager): pass NULL instead of 0 to label_new().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:23 +03:00
Kian-Meng Ang
5001232704 Fix various typos in the source code (closes MidnightCommander/mc#177). 
Found via `codespell -S
po,doc,./misc/syntax,./src/vfs/extfs/helpers/README.it -L
parm,rouge,sav,ect,vie,te,dum,clen,wee,dynamc,childs,ths,fo,nin,unx,nd,iif,iterm,ser,makrs,wil`

Co-authored-by: Yury V. Zaytsev <yury@shurup.com>
Signed-off-by: Kian-Meng Ang <kianmeng@cpan.org>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2023-01-28 21:38:05 +03:00
Andrew Borodin
57c61b7681 Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:05 +03:00
Andrew Borodin
b3fb596040 (dlg_init): get rid of extra dialog draws. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:04 +03:00
Andrew Borodin
3a3171c990 (widget_default_set_state): clarify set of widget state's exclusive bits. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:04 +03:00
Andrew Borodin
fbfb4f565c (menubar_new): do not reset WOP_SELECTABLE options 
...because widget is not selectable by default.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:04 +03:00
Andrew Borodin
1e9f0d6d69 (buttonbar_new): set options directly. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:04 +03:00
Andrew Borodin
2a80ea54dd (widget_init): remove double assignments. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:04 +03:00
Andrew Borodin
7031508550 (command_completion_function): don't call canonicalize_pathname() 
...because mc_build_filename() makes that.

(etags_set_definition_hash): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:04 +03:00
Andreas Mohr
1431d8b692 (ins_from_clip): fix maybe-uninitialized warning. 
../../../lib/widget/input.c:573:8: error: 'event_data.ret' may be used uninitialized [-Werror=maybe-uninitialized]
  573 |     if (event_data.ret)
      |        ^
../../../lib/widget/input.c:566:35: note: 'event_data.ret' was declared here
  566 |     ev_clipboard_text_from_file_t event_data;

Found by gcc-11.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-10-10 21:07:40 +03:00
Andrew Borodin
79645187c6 (input_get_ctext): mew API. 
Use it instead of direct access to WInput's buffer.

(handle_cmdline_enter): additional minor refactoring.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-08-04 11:17:29 +03:00
Andrew Borodin
28154dc520 (input_destroy): remove check if WInput object is NULL. This object must exist. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-08-04 11:11:50 +03:00
Andrew Borodin
589155f6bf WInput: make one-line APIs inline. 
* (input_get_text): make inline.
  * (input_is_empty): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-08-04 11:11:33 +03:00
Andrew Borodin
4e245291b4 (input_is_empty): remove checks. WInput object must exist. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-08-04 11:09:49 +03:00
Andrew Borodin
318315399b Ticket #4397: sort in editor without arguments stopped working. 
* (input_get_text): never return NULL. If buffer is empty, return an
empty allocated string.
  * (input_push_history): use new input_get_text.
  * (find_parameters): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-08-04 11:09:42 +03:00
Andrew Borodin
6c45208744 Fix indentation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 20:12:46 +03:00
Andrew Borodin
101714e39b (query_default_callback): clarify widget position. 
If dialog should be placed too high (in the upper half of the screen
closer to the screen top), show it centered.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 12:19:47 +03:00
Andrew Borodin
caf41457c6 (widget_adjust_position): change argument for coordinates. 
Use WRect instead of four values.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:55:06 +03:00
Andrew Borodin
390d614b5e (group_init): change argument for coordinates. 
Use WRect instead of four values.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:55:06 +03:00
Andrew Borodin
ccdc909105 (widget_init): change argument for coordinates. 
Use WRect instead of four values.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:55:03 +03:00
Andrew Borodin
aac258e44e (rect_grow): new API. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:50:19 +03:00
Andrew Borodin
5fae2313f3 Widget: use WRect to hold position and size. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:49:20 +03:00
Andrew Borodin
ed65694caa quick_dlg: use WRect to hold dialog position and size. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:37:04 +03:00
Andrew Borodin
3978dee37c (widget_set_size_rect): reimplement 
...to pass given WRect object directly to widget callback withowt
constuction/deconstuction of intermediate WRect object.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:32:47 +03:00
Andrew Borodin
b265b388aa (input_push_history): join checks. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:29:21 +03:00
Andrew Borodin
6aeeb7ffb1 (push history): refactoring. 
Rename to input_push_history().

Use input's buffer.

Don't duplicate an empty string, use current one.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:29:21 +03:00
Andrew Borodin
6639c4f070 (delete_region): use move_buffer_backward(). 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:29:21 +03:00
Andrew Borodin
84ec30d05a lib/widget/input.c: reorder routines. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:29:21 +03:00
Andrew Borodin
bf0dd8efb1 WInput: use GString for buffer. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:28:51 +03:00
Andrew Borodin
f91d894f9b (input_get_text): new API. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:26:37 +03:00
Andrew Borodin
f4a3112d5e (input_is_empty): refactoring. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 11:23:37 +03:00
Andrew Borodin
2c205c5928 Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-03-13 13:17:26 +03:00
Andrew Borodin
13df437ba1 Ticket #4323: fix segfault on change panel mode. 
How to reproduce:
1. Set left panel to list mode.
2. Make left panel active.
3. Change left panel to info mode.
Result: segmentation fault.

(widget_replace): fix search of the next focusable widget.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-12-24 16:36:38 +03:00
Andrew Borodin
9149a6d132 (delete_region, copy_region): rename arguments. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-11-21 15:00:39 +03:00