Commit Graph

907 Commits

Author SHA1 Message Date
Andrew Borodin
fa421e065a Indentation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 13:41:11 +04:00
Andrew Borodin
f262bf62b7 Portability: rename some str_class members
...to avoid conflict with global names.

On HP-UX, inttypes.h includes ctype.h through other dependencies, ctype.h
defines macros for various functions and these macros clash with entries
of "struct str_class".

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:32 +04:00
Mikulas Patocka
9332f1d1c5 Portability: ESC_CHAR is defined in /usr/include/langinfo.h in some systems
...so undefine it to avoid warning.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:32 +04:00
Andrew Borodin
272e2adabd Cleanup code related to GLib < 2.12.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:32 +04:00
Andrew Borodin
bcb8c376ef Portability: use g_ascii_strtoll instead of strtoll, atoll and atof.
Set minimal version of GLib up to 2.12 because of g_ascii_strtoll.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:32 +04:00
Andrew Borodin
3b6f3697f9 Fix crash when user menu is called in editor with no filename.
(mc_search): immediately return FALSE if str is NULL.
(mc_search_run): immediately return FALSE if user_data is NULL.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:32 +04:00
Andrew Borodin
89f59bb12b Optimization of SIGWINCH handling.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:32 +04:00
Andrew Borodin
71bae55f12 Parenthesis around some -1.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:32 +04:00
Pavel Vasilyev
9678bdc3ef vfs_s_subclass::linear_read: return ssize_t instead of int.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:32 +04:00
Pavel Vasilyev
48c3be0a72 lib/vfs/direntry.c: types accuracy.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:32 +04:00
Andrew Borodin
fd24e32c7c lib/vfs/vfs.h: indentation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:31 +04:00
Andrew Borodin
1567395ce7 lib/tty/color.c: use unsigned type for conversion between integer and pointer.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:31 +04:00
Andrew Borodin
080ab4fb11 (str_iscombiningmark): return gboolean instead of int
...and related changes.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:31 +04:00
Andrew Borodin
a341971441 Clarify of sig_atomic_t usage (got from Mutt).
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:31 +04:00
Andrew Borodin
1463d550b0 Define winch_flag as volatile sig_atomic_t.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:31 +04:00
Andrew Borodin
6cbe12d968 Don't exit after migration of configuration files.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:31 +04:00
Andrew Borodin
855887c633 lib/strutil/strverscmp.c: add missing include of config.h.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:31 +04:00
Andrew Borodin
0e7d534529 Fix of sys/ioctl.h includes: use HAVE_SYS_IOCTL_H guard.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:30 +04:00
Andrew Borodin
1ec1fbe35b (mc_mkstemps): use g_mkstemp() to generate name of temporary file.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-21 12:50:30 +04:00
Andrew Borodin
a8030670b7 Clarify usage of AM_CPPFLAGS.
Use AM_CPPFLAGS not AM_CFLAGS for includes. GLIB_CFLAGS are CPPFLAGS, actually.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-18 16:33:25 +04:00
Andrew Borodin
d557ade7f6 PCRE_CFLAGS are CPPFLAGS, actually.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-12-18 16:32:52 +04:00
Andrew Borodin
0da7057cba Remove unused AM_CPPFLAGS.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-10-13 11:35:03 +04:00
Andrew Borodin
ec0defe60d Ticket #2917: Makefile.ams cleanup.
Set defines via CPPFLAGS variable not via CFLAGS one.
Use AM_CPPFLAGS and AM_CFLAGS variables instead of per-target ones.

Cherry-picked b37af47023.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-10-13 11:27:52 +04:00
Andrew Borodin
4d82b671f1 Ticket #2898: fix broken path completion on paths starting with ~/.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-10-04 11:06:34 +04:00
Andrew Borodin
149cd8ea96 (str_utf8_normalize): ret rid of extra memory allocation.
(str_utf8_casefold_normalize): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-09-06 13:25:34 +04:00
Andrew Borodin
f9aacdaf05 Use g_strndup() instead of g_strdup()
...to ret rid of extra calculation of string length.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-09-06 13:25:34 +04:00
Andrew Borodin
d6f1728fff Ticket #2874: enter on directory named '~' goes to the home one.
Revert "Support of use ~ as home directory in hotlist."
This partially reverts commit dd9c7516a3.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-09-06 10:33:13 +04:00
Andrew Borodin
260bd9742d Optimization of ini files load.
Some ini files (keymaps, skins) are loaded in read-only mode. For those
files, we don't need load and keep comments.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-08-30 13:18:34 +04:00
Andrew Borodin
d1f465680e lib/widget/input.c: indentation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-08-30 13:11:50 +04:00
Andrew Borodin
a3a1d0a41a Handle history of input line.
Added pointer to the current history item and use to walk in history.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-08-29 17:26:04 +04:00
Slava Zanko
a1719d12cd Ticket #2791: Fixed: cannot Copy/Move files with filename encoding change
Steps to reproduce:
 * run mc
 * change encoding one of panels to any different from system encoding
 * try to copy any file to panel with changed encoding

Expected result: files should be copied.

Actual result: error box here.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-08-29 13:33:49 +03:00
Andrew Borodin
01088ce453 Revert "Try fix of compile warnings about assigned but unused variables"
This reverts commit 3d1a4ecaf7.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-07-18 09:43:19 +04:00
Slava Zanko
149c29f80c Indent files.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-07-17 17:07:32 +04:00
Slava Zanko
3d1a4ecaf7 Try fix of compile warnings about assigned but unused variables
...as returned values of functions declared with attribute
warn_unused_result [-Wunused-result].

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-07-17 17:07:32 +04:00
Andrew Borodin
7e6c92d893 Code cleanup: removed unused variables amd removed unnedeed code.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-07-17 17:07:32 +04:00
Andrew Borodin
498ee253da Menubar: ignore GPM_UP event.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-07-17 17:07:31 +04:00
Andrew Borodin
04883518fd Accuracy use of arguments of dlg_move and widget_move macros.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-07-17 17:07:31 +04:00
Andrew Borodin
ad1f1b56e7 Ticket #2842: change hotkey for Normal search mode.
In Search dialog in mcedit M-n hotkey was used for normal search mode.
Therefore, M-n as HistoryPrev in the input line was in accessible.

Change hotkey for normal seach mode to M-r. Use this hotkey for normal diff
mode in mcdiffviewer to unify i18n resources.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-07-10 21:01:16 +04:00
Slava Zanko
5ee099d8c5 Ticket #2834: Fixed bug 'FTBFS with --disable-vfs'
Steps to reproduce:
 * ./configure --disable-vfs
 * make

Expected result: project should be builded successfully.

Actual result:
build stopped with errors:
lib/vfs/interface.c: In function 'mc_chdir':
lib/vfs/interface.c:714: error: 'struct vfs_s_super' has no member named 'path_element'
lib/vfs/interface.c:716: error: 'struct vfs_s_super' has no member named 'path_element'
lib/vfs/interface.c:717: error: 'struct vfs_s_super' has no member named 'path_element'

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-06-29 12:55:25 +03:00
Andrew Borodin
8598f5c599 Core, mceditor, mcviewer and mcdiffviewer code tweak and cleanup
...in case of build with --disable-charset option.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-06-25 17:07:47 +04:00
Andrew Borodin
057a762e9f Ticket #2827: tweak and cleanup of code in case of --disable-charset option usage.
First step: tweak vfs-related code.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-06-25 17:06:48 +04:00
Andrew Borodin
6f0eacee73 Ticket #2833: url with port was stored wrong in history.
"sh://admin@192.168.1.119:55522" was stored as
"sh://admin@192.168.1.119@192.168.1.119".

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-06-20 15:59:07 +04:00
Andrew Borodin
948753be0f Don't mix mc_search_cb_ret_t and int as result of search callback.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-06-11 15:59:54 +04:00
Andrew Borodin
13398647ed Ticket #2795: hex search: can't find 00 (zeroes) in patterns.
Don't interpret the '0' character as end of search pattern.
Use pattern length for that.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-06-11 15:59:45 +04:00
Slava Zanko
15a9a74040 Ticket #2821: Fixed defect: ftp to a second site does not work
Steps to reproduce:

 * cd  ftp://ftp.gnome.org/
 * Run "cd" in the panel where the remote site is open
 * cd  ftp://ftp.kernel.org/

Actual result: The directory content from ftp.gnome.org FTP-server.
Expected results: The directory content from kernel.org FTP-server.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-06-06 12:13:12 +03:00
Slava Zanko
e9f3b4dfd0 Ticket #2800: Garbage directory listing in ftpfs
Just open any non-anonymous FTP connection.
2012-05-18 12:37:17 +03:00
Andrew Borodin
ce529dc409 Ticket #2787: crash when creating relative symlink.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-04-25 14:58:24 +04:00
Ilia Maslakov
08bebd6569 Ticket #2757 (mcedit not record input chars)
fixed trouble with internal editor macro engine introduced by commit #68a8745f6dd7ded9437317a694225d599745e983
    now record input char and commands.

Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
2012-04-22 15:34:20 +04:00
Andrew Borodin
8f1e5db996 (input_history_strip_password): actually url is not the pointer to constant. 2012-04-22 14:08:53 +04:00
Andrew Borodin
807dd268e9 (vfs_expare): changed argument type from int to gboolean.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-04-22 12:31:24 +03:00