Found by GCC 7.1.0.
boxes.c:431:22: error: comparison between pointer and zero character constant [-Werror=pointer-compare]
if (state_str[0] == '\0')
^~
boxes.c:431:9: note: did you mean to dereference the pointer?
if (state_str[0] == '\0')
^
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
../../../../src/vfs/tar/tar.c: In function 'tar_open_archive':
../../../../src/vfs/tar/tar.c:805:69: error: 'h_size' may be used uninitialized in this function [-Werror=uninitialized]
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
In mcedit user menu the %f macro should match the file name opened in
mcedit not the file name is selected in the panel.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Broken in 178628e67f.
(mcview_do_search): do search in last chunk if data source is the
growing buffer only.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
When content of a large directory is being sorted by file names, a
significant amount of CPU time is spent in str_utf8_normalize() that is
called from str_utf8_create_key_gen().
For example, /usr/bin/ contains 5437 files on my Archlinux box. Running
mc /usr/bin/ /usr/bin/ takes approx. 75 000 000 CPU instructions to sort
file names, or 25% of total program run time. From these 75 000 000
instructions, 42 500 000 instruction are spent in str_utf8_normalize().
str_utf8_normalize() uses g_utf8_normalize() to do the work.
g_utf8_normalize() is a heavyweight function, that converts UTF-8 into
UCS-4, does the normalization and then converts UCS-4 back into UTF-8.
Since file names are composed of ASCII characters in most cases, we can
speed up str_utf8_normalize() by checking if the heavyweight Unicode
normalization is actually needed. Normalization of ASCII string is
no-op, so it is effectively "normalized" by just strdup().
With this patch, running mc /usr/bin/ /usr/bin/ requires just 37 000 000
instructions to sort the file names (down from 75 000 000) and 4 500 000
instuctions to do str_utf8_normalize() (down from 42 500 000).
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
If the file is not compressed and DECOMP is empty, it should be replaced
by *nothing*, not an empty argument. Broken in the following commit:
becc0d01d0
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
* (mcview_dialog_goto): do read data from pipe in case of
MC_VIEW_GOTO_OFFSET_DEC and MC_VIEW_GOTO_OFFSET_HEX.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Goto decimal/hexadecimal offset doesn't grow the file if necessary,
rather stops at an earlier offset.
Goto percent doesn't work either. It's trickier because no matter what
the percent value is, it'd need to read the entire contents.
Goto line number works as expected.
* (mcview_dialog_goto): read all data from pipe in case of
MC_VIEW_GOTO_PERCENT.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
