Cleanup following cppcheck warnings:
[lib/utilunix.c:1109]: (style) Unused variable: link_path.
[lib/utilunix.c:1113]: (style) Variable 'readlinks' is assigned a value that is never used.
[lib/utilunix.c:1114]: (style) Unused variable: n.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Cleanup following cppcheck warnings:
[src/filemanager/layout.c:231]: (style) Clarify calculation precedence for '&' and '?'.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Cleanup following cppcheck warnings:
[lib/vfs/direntry.c:121]: (style) Clarify calculation precedence for '&' and '?'.
[lib/vfs/direntry.c:386]: (style) Clarify calculation precedence for '&' and '?'.
[lib/vfs/direntry.c:391]: (style) Clarify calculation precedence for '&' and '?'.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
On glibc-2.23 link fails as
$ mc-9999/src/filemanager/mountlist.c:750: undefined reference to `makedev'
Reported-by: Thomas D.
Bug: https://bugs.gentoo.org/579858
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Cleanup uninitialized warning with gcc compiler (gcc-4.4.7-4.el6).
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
When using slang, 'configure' prints blank in the "Screen library" name:
...
File system: Midnight Commander Virtual Filesystem
cpio, extfs, fish, ftp, sfs, sftp, smb, tar
Screen library:
Mouse support: gpm and xterm
X11 events support: yes
...
This occurs when slang is found using pkg-config (as opposed to explicit path
search). The patch fixes this by moving the 'screen_msg' assignment one level
up, to the controlling function (mc_WITH_SLANG) so that it's effective for
however method the library was found.
The problem was mentioned on our mailing list:
https://mail.gnome.org/archives/mc-devel/2016-March/msg00021.html
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Make Solaris Studio 12.4 happy.
"dialog.c", line 1029: warning: argument #2 is incompatible with prototype:
prototype: pointer to const void
argument : pointer to function (...) returning enum (...)
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Make Solaris Studio 12.4 & 12.5 happy.
"args.c", line 180: warning: initialization type mismatch
"args.c", line 188: warning: initialization type mismatch
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Calling tty_change_screen_size() causes a switch to the alternate screen:
* Resizing the window causes a SIGWINCH sent to the mc process.
* sigwinch_handler() sets the flag mc_global.tty.winch_flag to 1.
* The select() call in feed_subshell() is interrupted.
* feed_subshell() notices the winch_flag and calls tty_change_screen_size().
* tty_change_screen_size() calls SLsmg_reinit_smg().
* SLsmg_reinit_smg() sees that Smg_Mode is currently SMG_MODE_NONE
(because it was set that way back in reset_smg() that was called
when panels were hidden).
* SLsmg_reinit_smg() calls SLsmg_init_smg().
* SLsmg_init_smg() calls init_smg_for_mode(SMG_MODE_FULLSCREEN).
* init_smg_for_mode() calls SLtt_init_video().
* SLtt_init_video() sends the smcup terminfo sequence to the terminal.
* SLtt_init_video() calls SLtt_init_keypad().
* SLtt_init_keypad() sends the smkx terminfo sequence to the terminal
and flushes the output buffer. (If $TERM starts with xterm or exactly
matches screen, this function returns immediately without flushing the
buffer, so the issue will not be visible.) The terminal switches to
alternate screen and clears it.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
By default, on Unix systems, unzip gets compiled with MDY date order. Debian
based distros compile it with YMD order, for which this patch adds support.
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
Save space and fix rpmlint warning found by OBS Framework
(build.opensuse.org).
mc.x86_64: W: files-duplicate /etc/mc/mc.keymap /etc/mc/mc.default.keymap
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
