Roland Illig
d7e7ec48dd
* *.c: Declared unused variables with (void) to avoid the gcc
...
warnings.
* extfs.c (extfs_get_path_mangle, extfs_get_path): Removed unused
parameter.
* ftpfs.c (ftpfs_netrc_bad_mode): Likewise.
* vfs.c (mc_def_getlocalcopy): Likewise.
2005-02-22 18:35:22 +00:00
Roland Illig
54cccec688
* utilvfs.h: Removed unneeded #includes.
...
* *.c: Added the #includes that have been removed from utilvfs.h.
* tcputil.c: Just removed the unneeded #include "utilvfs.h".
2005-02-19 16:36:38 +00:00
Andrew V. Samoilov
0fdf2a6e6d
* direntry.c (vfs_s_readlink): Correctly calculate link length.
2004-11-29 18:44:49 +00:00
Andrew V. Samoilov
09180a901a
* direntry.c (vfs_s_open): Fix memory leak.
...
(vfs_s_retrieve_file): Check write() return more carefully.
2004-11-26 12:00:36 +00:00
Andrew V. Samoilov
c060826178
* direntry.c (vfs_s_free_entry): g_free handles NULL argument too,
...
no need for the comparison.
* extfs.c (extfs_free_archive): Likewise.
(extfs_open_archive): Likewise.
(extfs_read_archive): Likewise.
(extfs_remove_entry): Likewise.
(extfs_free_entry): Likewise.
* fish.c (fish_open_archive): Likewise.
(fish_archive_same): Likewise.
* ftpfs.c (ftpfs_split_url): Likewise.
* local.c (local_closedir): Likewise.
* mcserv.c (close_handle): Likewise.
* smbfs.c (smbfs_free_bucket): Likewise.
* tar.c (tar_read_header): Likewise.
* undelfs.c (undelfs_shutdown): Likewise.
* vfs.c (vfs_shut): Likewise.
2004-09-24 23:00:18 +00:00
Roland Illig
4bc786735e
* cpio.c: Replaced NULL with (char *) NULL. Likewise for 0, where
...
NULL was meant.
* direntry.c: Likewise.
* extfs.c: Likewise.
* fish.c: Likewise.
* ftpfs.c: Likewise.
* mcfs.c: Likewise.
* tar.c: Likewise.
* undelfs.c: Likewise.
* vfs.c: Likewise.
2004-09-24 15:08:21 +00:00
Roland Illig
a3cf3b2d5f
* direntry.c (vfs_s_new_entry): see 2004-09-19. Additionally followed the advice
...
concerning g_strdup in /HACKING.
(vfs_s_generate_entry): Likewise.
(vfs_s_find_entry_linear): Likewise.
(vfs_s_find_inode): Likewise.
* xdirentry.h: Likewise.
2004-09-22 11:28:14 +00:00
Andrew V. Samoilov
c524515308
* direnty.c (vfs_s_new_entry): Revert last changes.
...
(vfs_s_generate_entry): Likewise.
(vfs_s_find_entry_linear): Likewise.
(vfs_s_find_inode): Likewise.
* xdirentry.h: likewise.
2004-09-22 05:50:45 +00:00
Roland Illig
a9f9db7b6b
* direntry.c: Added const qualifier to function declarations and
...
variables. Introduced local modifiable strings where necessary.
* xdirentry.h: likewise.
2004-09-19 16:07:17 +00:00
Andrew V. Samoilov
c9f834b501
* vfs.c (vfs_cmp_handle): Fixing warnings on on 64-bit
...
platforms.
(vfs_op):Likewise.
(vfs_info):Likewise.
(vfs_free_handle):Likewise.
* extfs/rpm (mcrpmfs_run): Quote parameters to calls
to system/open that spawn a shell.
* direntry.c (vfs_s_find_entry_tree): Make "size"
size_t.
2004-09-03 21:23:05 +00:00
Andrew V. Samoilov
fc3bf048e9
* local.c (local_readlink): Make "size" size_t.
...
* direntry.c (vfs_s_readlink): Revert last changes. Make "size"
size_t.
* sfs.c (sfs_readlink): Reformat function.
* smbfs.c (smbfs_readlink): Reformat function.
2004-09-02 14:12:21 +00:00
Andrew V. Samoilov
15c6e5cae6
* direntry.c (vfs_s_readlink): Use g_strlcpy instead strncpy.
...
* ftpfs.c (ftpfs_get_reply): Use g_strlcpy instead strncpy.
* extfs.c (extfs_readlink): Fix return value. Use g_strlcpy
instead strncpy.
* mcfs.c (mcfs_readlink): Fix return value. Use g_strlcpy
instead strncpy.
* tar.c (tar_read_header): Add additional check for consistency.
Fix memory leak.
* cpio.c (cpio_defer_find): Remove recursion.
(cpio_free_archive): Fix memory leak.
(cpio_read_bin_head): Use union for simplicity using of header
structure. Add additional check for consistency.
(cpio_read_oldc_head): Add additional check for consistency.
2004-09-02 00:09:02 +00:00
Andrew V. Samoilov
a2d1d4e8dc
* direntry.c: Use g_strlcpy instead strncpy for fix buffer overrun
...
* extfs.c: Likewise.
* mcfs.c: Likewise.
* smbfs.c: Likewise.
* utilvfs.c: Likewise.
2004-08-26 08:47:50 +00:00
Roland Illig
34a8088483
Splittet the vfs.h header into a user's part (vfs.h) and an implementor's part (vfs-impl.h).
2004-08-16 23:18:42 +00:00
Roland Illig
b17b1ac213
Const-ified the rest of the vfs_class methods.
2004-08-16 22:15:28 +00:00
Roland Illig
dc70d154db
Made the buf argument to vfs->write constant.
2004-08-16 21:16:54 +00:00
Roland Illig
789e5e9bcb
Made the path argument to vfs->[l]stat constant. Created a new memory leak, which will be fixed soon.
2004-08-16 20:26:42 +00:00
Roland Illig
db3f21b702
Added a typedef for a function. Added more const-ness to the function arguments.
2004-08-16 16:34:11 +00:00
Andrew V. Samoilov
02db8a9660
* direntry.c (vfs_s_resolve_symlink): Check vfs_s_fullpath()
...
return value to avoid NULL dereference.
Reported by wwp <subscript@free.fr>.
2004-03-07 06:12:49 +00:00
Pavel Roskin
6ffd35bf07
* gc.c: Eliminate all code for timestamping parent filesystems.
...
It's broken and undocumented. Adjust all dependencies.
2003-11-26 21:10:42 +00:00
Pavel Roskin
8ed2cc4594
* direntry.c (vfs_s_resolve_symlink): Eliminate
...
g_strdup_printf().
(vfs_s_fullpath): Likewise.
2003-11-24 20:30:30 +00:00
Pavel Roskin
54b8c9aaad
* vfs.c (vfs_split): Deconstify.
...
* direntry.c (vfs_s_get_path_mangle): Likewise. "mangle" is in
the name for a reason. Use vfs_s_get_path() instead where the
path should be preserved.
* extfs.c (extfs_get_path_mangle): Likewise.
* sfs.c (sfs_vfmake): Protect against changes in vfs_split().
2003-11-14 08:25:50 +00:00
Pavel Roskin
30c4bd1b6d
* vfs.h: Constify chdir() and opendir() methods. Adjust all
...
dependencies.
* vfs.c (mc_chdir): Constify, eliminate protection against
broken implementations of chdir() method.
(mc_opendir): Constify.
2003-11-13 08:29:37 +00:00
Pavel Roskin
4b5a2a0b62
* direntry.c (vfs_s_stamp_me): Generalize and move ...
...
* gc.c (vfs_stamp_create): ... here. Use whenever possible.
2003-11-13 08:03:03 +00:00
Pavel Roskin
de12104436
* gc.c: Use NULL instead of -1 for empty vfsid. Adjust all
...
dependencies.
* undelfs.c (undelfs_get_path): Don't shadow static ext2_fname.
(undelfs_getid): Likewise. Use fs for non-empty vfsid.
2003-11-12 23:00:16 +00:00
Pavel Roskin
4eab382dba
* gc.c: Make getid(), nothingisopen() and free() methods
...
optional. Eliminate trivial implementations.
(vfs_getid): New function - safe wrapper around getid(). Use
it everywhere.
(vfs_ncs_getid): Remove dead code, inprove readability.
2003-11-08 23:53:00 +00:00
Pavel Roskin
b33f2cbb47
* vfs.c: Split garbage collection code into ...
...
* gc.c: ... this.
* vfs.h: Corresponding code moved ...
* gc.h: ... here.
* Makefile.am: Adjustments for the above.
2003-11-07 23:43:55 +00:00
Pavel Roskin
0318ed5d0b
* vfs.c: Move all parsing code, vfs_die() and vfs_get_password()
...
to utilvfs.c, vfs_print_stats() to direntry.c.
* utilvfs.c (vfs_parse_ls_lga): Disable caching current date,
it's done incorrectly.
2003-11-05 06:08:16 +00:00
Pavel Roskin
edce41facd
* utilvfs.c (vfs_mkstemps): New function - create temporary file
...
with the name resembling the original, but safe for scripts.
* direntry.c (vfs_s_open): Use it.
(vfs_s_retrieve_file): Likewise.
* extfs.c (extfs_open): Likewise.
* sfs.c (sfs_redirect): Likewise.
2003-10-29 00:50:36 +00:00
Pavel Roskin
77bcdc8127
* vfs.c (mc_ungetlocalcopy): Free local path here, not in class
...
implementations.
* vfs.h (struct vfs_s_class): Constify "local" argument for
ungetlocalcopy. Adjust all implementations.
2003-10-28 21:52:06 +00:00
Pavel Roskin
bb184c9c8b
Typo in the last commit.
2003-10-28 08:47:04 +00:00
Pavel Roskin
67cd859ea3
* direntry.c (vfs_s_init_class): Use our getlocalcopy for remote
...
filesystems that cache files, not for archives.
(vfs_s_getlocalcopy): Corresponding changes.
2003-10-28 08:20:30 +00:00
Pavel Roskin
8e3a0c9d65
* direntry.c (vfs_s_init_class): Improve interface to allow more
...
code reuse. Change all callers.
(vfs_s_getlocalcopy): New implementation. Don't use
mc_def_getlocalcopy(). Use vfs_s_open() to create local copy.
(vfs_s_ungetlocalcopy): New function.
* xdirentry.h: Add new field "flags" to struct vfs_s_subclass.
* extfs.c (extfs_ungetlocalcopy): Don't use
mc_def_ungetlocalcopy() in the dead branch.
* vfs.c (mc_def_getlocalcopy): Make static.
(mc_def_ungetlocalcopy): Likewise.
2003-10-28 07:09:39 +00:00
Pavel Roskin
7d16d65e35
* vfs.h: Constify some arguments for many functions.
...
* xdirentry.h: Likewise. Adjust all dependencies.
2003-10-28 02:10:33 +00:00
Pavel Roskin
bc455d5840
* direntry.c (vfs_s_find_inode): Only allow search from root.
...
Change second argument to superblock to prevent abuse.
2003-10-27 03:09:40 +00:00
Pavel Roskin
ad670bade6
* direntry.c (vfs_s_find_entry_tree): Eliminate buffer of fixed
...
size. Don't prepare path for vfs_s_resolve_symlink().
(vfs_s_resolve_symlink): Remove unused argument "path".
2003-10-27 02:54:59 +00:00
Pavel Roskin
511321bcfd
* direntry.c (vfs_s_add_dots): Remove. Fix all callers.
...
(vfs_s_free_inode): Remove support for "." and ".." entries.
* ftpfs.c (dir_load): Likewise.
Support for "." and ".." entries was a hack that could make the
cache non-traversible from inodes to the root and cause infinite
loop in vfs_s_fullpath().
Reported by Frédéric L. W. Meunier <lists1@pervalidus.net>
2003-10-27 01:26:18 +00:00
Pavel Roskin
211ce16fac
* wtools.c: Merge mc_message() and message() into one background
...
safe function message(). Fix all callers.
2003-10-26 04:47:20 +00:00
Pavel Roskin
50045218ab
Remove unneeded includes in ../src
2003-10-25 21:34:57 +00:00
Pavel Roskin
2d33b5047e
* background.c: Replace all message stubs with a new function
...
mc_message(). Protect against strlen(MSG_ERROR). Adjust all
dependencies.
2003-10-25 19:54:24 +00:00
Pavel Roskin
274a5a1c41
* direntry.c (vfs_s_find_entry_tree): Canonicalize path.
2003-10-17 03:25:43 +00:00
Pavel Roskin
e09739368e
* direntry.c (vfs_s_resolve_symlink): Don't use buffers of fixed
...
size. This fixes a security hole. Always start from the root.
Remove broken code for making symlinks relative.
(vfs_s_find_entry_tree): Protect against long path, since this
function uses a buffer of fixed size.
(vfs_s_fullpath): Implement support for archives (real trees).
2003-10-16 23:58:43 +00:00
Pavel Roskin
7c4fc715da
* direntry.c (vfs_s_setctl): Implement VFS_SETCTL_FLUSH.
...
* ftpfs.c: Remove ftpfs_flushdir. Use MEDATA->flush.
* fish.c: Use MEDATA->flush.
2003-10-16 18:51:41 +00:00
Pavel Roskin
e9ffcceae5
* direntry.c (vfs_s_setctl): Add support to VFS_SETCTL_LOGFILE.
...
* ftpfs.c (ftpfs_set_debug): Remove.
2003-10-16 17:08:38 +00:00
Pavel Roskin
52844a3092
* vfs.h: Rename commands for mc_ctl() and mc_setctl() to make it
...
clear which function they are used with.
* vfs.c (mc_ctl): Change last argument to (void*).
(mc_set): Likewise.
Adjust all dependencies.
2003-10-16 16:12:19 +00:00
Pavel Roskin
fc7267906f
* xdirentry.h: Move system includes to the files that need them.
2003-10-16 08:47:33 +00:00
Pavel Roskin
426c1836d5
* vfs.h: Remove all references to seekdir and telldir. Adjust
...
all dependencies.
2003-10-14 22:24:26 +00:00
Pavel Roskin
6cf97f4069
* xdirentry.h: Remove all typedefs, there is no need to hide the
...
fact that structures are structures. Fix all dependencies.
2003-10-12 01:00:44 +00:00
Pavel Roskin
00b57fd4bf
* vfs.h: Remove typedef vfs, it's too ambiguous. Massive
...
changes to use struct vfs_class instead.
2003-10-12 00:24:00 +00:00
Pavel Roskin
6e6fd9b352
* vfs.c (vfs_add_noncurrent_stamps): Call vfs_rm_parents() at
...
the end. Change all callers not to call it.
(vfs_rm_parents): Make static.
2003-10-11 17:30:54 +00:00