mirrors/mc
1
0
Fork 0
mirror of https://github.com/MidnightCommander/mc synced 2024-12-23 12:56:51 +03:00
Code Issues Packages Projects Releases Wiki Activity
13,936 Commits 47 Branches 83 Tags 91 MiB
b56a77e02f
Commit Graph

344 Commits

Author SHA1 Message Date
Andreas Mohr
a482f38581 Cleanup -Wfloat-conversion warning. 
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-03-04 09:23:37 +03:00
Andrew Borodin
829738baa7 (mc_error_message): make output format translatable. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-03-04 09:23:37 +03:00
Andrew Borodin
4db17d31f9 lib/widget/input.c: (quote): change type to gboolean. 2016-03-04 09:23:37 +03:00
Andrew Borodin
c4258d453b Clarify AM_CPPFLAGS. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-03-04 09:23:36 +03:00
Andreas Mohr
842a723f9b Ticket #3269: only print meaningful error code. 
Some error messages have no meaningful error code, don't display them.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-02-02 09:42:51 +03:00
Andreas Mohr
47590152fa Ticket #3161: WListbox: remember focus state. 
When listbox is updated, e.g. new file match add MSG_DRAW event is triggered
but currently listbox re-draw has no knowledge about right focus state.
Fix it by remember current focus state.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-08 12:49:30 +03:00
Mooffie
aa693fb0c3 Ticket #3569: various fixups in WListbox engine. 
Ticket #3562: Listbox should fire MSG_ACTION on mouse clicks too.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-08 11:40:42 +03:00
Andrew Borodin
471ea781ca Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-01 11:48:10 +03:00
Andreas Mohr
697e406eb8 Robust sizeof() usage at function parameter and use memcpy destination sizeof... 
...for more resilient to errors.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-01 11:48:09 +03:00
Andreas Mohr
5f076e9e05 Ticket #3567: fix heap-use-after-free bug when accessing already freed widget object 
Accessing widget object (at g_array_index loop) which was freed
already (item->quick_widget->u.input.label before at loop).

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-01 11:48:08 +03:00
Mooffie
b6500f1dcc (listbox_key): remove redundant code. 
This l->top calculation is already done in listbox_select_entry().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-01 11:48:08 +03:00
Andrew Borodin
a6f5767f3f Use signed long instead of unsigned long for binded actions. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-01 11:48:08 +03:00
Mooffie
106f80310d Remove outdated comment about refresh. 
This comment was explanining a call to mc_refresh(). That call was
removed in commit 1f0b05b18. Keyboard events and mouse events are
nowadays the same: refresh is done after both.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-01 11:48:07 +03:00
Andreas Mohr
897eac252f (WMenubar): fix -Wconversion warnings. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-01 11:48:07 +03:00
Andreas Mohr
a613de7183 (gauge_callback): fix -Wconversion warnings. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-01 11:48:07 +03:00
Mooffie
5fad7508c5 button_get_text() shouldn't return 'const'. 
As it's a newly allocated string which the caller needs to free.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-01 11:48:06 +03:00
Andrew Borodin
99dd99172f Listbox: don't wraparound on mouse scroll. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-11-18 21:24:53 +03:00
Mooffie
e86072497f Ticket #3554: Listbox: don't wraparound on mouse scroll. 
Initial commit: Listbox code cleanup.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-11-18 21:24:46 +03:00
Andrew Borodin
70fa973f47 Fix typos. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-11-05 14:33:21 +03:00
Andrew Borodin
d9ad3d2e32 Clarify __attribute ((format (printf))) usage. 
Thanks Andreas Mohr <and@gmx.li> for the original patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-11-05 14:33:20 +03:00
Andrew Borodin
a2fbfce123 (gauge_callback): fix draw of progress bar. 2015-11-05 14:32:53 +03:00
Egmont Koblinger
7e622158a2 Ticket #3530: viewer: highlight Find File's result. 
Initial commit: (WLEntry): add free_data member to free or keep the data
on entry's removal.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-10-18 18:19:26 +02:00
Andrew Borodin
21060c8ea7 (groupbox_callback): remove unused variable. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-05-24 20:16:56 +03:00
mooffie
ace07e4239 WGroupbox: respect dialog's colors. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-05-24 19:10:12 +03:00
Andreas Mohr
f023a83502 Ticket #3467: add -Wunreachable-code option and fix relative warnings. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-05-24 17:59:19 +03:00
Andrew Borodin
040be28e1b Ticket #3462: (WHLine): fix memory leak. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-05-24 17:59:18 +03:00
Andrew Borodin
93d7856f85 (quick_dialog_skip): fix location of labeled input. 2015-05-24 17:51:39 +03:00
Andrew Borodin
17bbeb9791 Ticket #3456: SFTP VFS: fix segfault. 
(mc_error_message): return error code for possible following use."
(sftpfs_cb_open_connection): fix dereference of null pointer.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-05-09 16:46:45 +03:00
Andrew Borodin
2789e6e390 Ticket #3431: add missing default cases. 
Introduce -Wswitch-default check.

Some minor cosmetics.

Thanks Andreas Mohr <and at gmx dot li> for original patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-05-03 19:43:50 +03:00
Andrew Borodin
b698b7e834 Ticket #3435: clang compiler fixes/cleanups. 
Since O_* macros are used in lib/global.h, include <fcntl.h> there.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-05-03 19:43:49 +03:00
Andrew Borodin
c08c90cd1b (input_execute_cmd): refactoring. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-02-26 09:20:53 +03:00
Andrew Borodin
42e7e39bd8 Add IS_PATH_SEP macro and use it. 
Also massive use of PATH_SEP and PATH_SEP_STR macros.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-02-26 09:13:02 +03:00
Andrew Borodin
454479549c Update copyright years. 2015-02-26 09:12:08 +03:00
Andrew Borodin
96699b7eba Ticket #3390: fix backward word delete in input fields. 
How to reproduce:
Either on the command line, or in any other text entry field (e.g. copy
file to) enter a string where the last word consists of one single
letter only. E.g. "abc de f".
Press Alt+Backspace.

Expected behavior: Remove the last word, that is, the letter "f" only,
leaving "abc de ".

Actual behavior: Yet another word is removed, leaving "abc ".

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-02-20 09:13:08 +03:00
Andrew Borodin
720f214482 (status_msg_init): repaint screen forced to remove previous finished dialog. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-10-03 13:19:26 +04:00
Andrew Borodin
81201b3022 status_msg_t: reimplement delay usage. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-10-03 13:19:25 +04:00
Andrew Borodin
d6004701cc Fix indentation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-09-02 15:57:56 +04:00
Andrew Borodin
6d82155270 Massive use of MC_PTR_FREE macro. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-09-02 15:32:36 +04:00
Andrew Borodin
4c27f7900c (input_event): fix handling of first mouse click. 2014-08-12 20:48:47 +04:00
Andrew Borodin
ddd336ad4d Ticket #3225: first Backspace/Delete ignored after mouse click in an input widget. 
Initial commit: WInput: refactoring of text marking.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-08-03 14:54:16 +04:00
Andrew Borodin
a5488affc8 Indentation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:53:10 +04:00
Andrew Borodin
c672ed9b21 (label_set_textv): new WLabel API. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:40:30 +04:00
Andrew Borodin
9d4bafd889 (simple_status_msg_t): simple status message with label and 'Abort' button. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:40:30 +04:00
Andrew Borodin
55e604901f Create status dialog window to interrupt long-time operations. 
Such dialog allows:
  * show status of operation;
  * control operation using dialog buttons (Abort, Suspend, Resume, etc).

Status dialog is raised after specified delay after operation start.
If operation duration is less than delay, the status dialog is not raised.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:40:30 +04:00
Andrew Borodin
e786d8266e (mouse_get_local): set Gpm_Event::modifiers only if libgpm is used. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:35:51 +04:00
Slava Zanko
512ad7d962 Make working with GError in more right way (like with exceptions). 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2014-07-22 13:12:07 +04:00
Andrew Borodin
f72cf464c9 (FileProgressStatus): change values to avoid overlapping with B_* values. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:12:07 +04:00
Andrew Borodin
478e58dfa2 (listbox_event): clarify check whether listbox is empty. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:12:07 +04:00
Andrew Borodin
76d61edc1e (mouse_get_local): initialize local.modifiers. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:10:40 +04:00
Andrew Borodin
db951c0d7e lib/widget/dialog-switch.c: fix the FSF name. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:10:40 +04:00
Egmont Koblinger
976c18557e Ticket #3178: fix update of command line colors on skin change. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-03-27 16:41:02 +04:00
Egmont Koblinger
5b243eb9ea (dlg_set_size): clarify comment and hangling of DLG_TRYUP flag. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-03-24 16:20:41 +04:00
Andrew Borodin
be6b3889af Ticket #3173: fix location of popup windows upon screen resize. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-03-24 16:20:40 +04:00
Andrew Borodin
e5203cb023 Fix name of FSF in all *.c files. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-02-28 13:33:17 +04:00
Gergely Szász
2b6e440597 Ticket #3172: WListbox: fix of add item to the empty list. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-02-18 09:42:15 +04:00
Andrew Borodin
bf474e1241 Ticket #2165: basic version of the user-friendly skin selector. 
Thanks Egmont Koblinger and Vitaliy Filippov for original patches.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-02-11 15:13:09 +04:00
Andrew Borodin
30ca8efd7c From ticket #3116: attempt to fix segfault while passing messages to widgets. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-02-10 16:27:03 +04:00
Andrew Borodin
f0da49345a Collapse list of copyright years to ranges. Add 2014 year. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-02-10 16:27:03 +04:00
Andrew Borodin
62e1606106 Fix segfault in directory hotlist. 
(listbox_get_current): check parameter value before use it's member.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-01-22 13:59:54 +04:00
Andrew Borodin
7df67031a2 Refactoring of WListbox widget. 
Use GQueue instead of GList to store listbox entries.

g_list_append() function is slow because it uses g_list_last()
internally to traverse from the beginning to the end of a list, so
forming a list of results has O(n*n) complexity instead of O(n).
GQueue contains pointers to head and tail of list and list length.
So in this case we don't need seach end of list every time when we
want append listbox entry to the listbox.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-01-14 14:13:38 +04:00
Andrew Borodin
29f6dd2a84 Use g_list_free_full(). 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-11-25 13:47:40 +04:00
Slava Zanko
0ed4a91d7d Reduce cppcheck warnings (style) in lib subdirectory. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-11-25 13:47:39 +04:00
Slava Zanko
0d489acd58 cppcheck: reduce variable scope. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-11-25 13:47:39 +04:00
Slava Zanko
bd69b8dd31 Suppress cppcheck errors 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-11-25 13:47:39 +04:00
Andrew Borodin
09f1818bed Ticket #3018: broken directory completion. 
In the command line, the subdirectory completion in current directory
isn't performed if stub isn't starting with './'.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-11-07 21:23:43 +04:00
Andrew Borodin
c7b7a299e3 Ticket #3084: (dlg_init): fix order of messages sent to widgets during dialog initialization. 
If checkbox is the first focusable widget in a dialog, it taken the MSG_DRAW
message after MSG_FOCUS one and therefore wasn't highlighted.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-11-07 15:59:26 +04:00
Andrew Borodin
5a61ac80d0 Refactoring of WInput history. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-11-07 15:53:53 +04:00
Andrew Borodin
de94164cb5 Remove WInput::field_width. Use Widget::cols instead. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-11-07 15:53:53 +04:00
Andrew Borodin
e16e33a186 (input_update): don't do anything if widget is unowned or is in inactive dialog. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-11-07 15:53:53 +04:00
Andrew Borodin
d8bb31c665 Ticket #3076: copy/move doesn't work if num_history_items_recorded=0. 
How to reproduce:
1. Set num_history_items_recorded=0 in my $HOME/.config/mc/ini
2. Run mc.
3. Press F5 to copy and then enter.
Result: nothing happens.

Solution: refactoring of initial text usage in input line.
Use def_text to fill WInput:buffer when WInput is created.
Then overwrite WInput::buffer content from history if history usage
is enabled.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-11-07 15:53:53 +04:00
Andrew Borodin
c058e92586 Remove input_set_origin(). Use widget_set_size() instead. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-10-04 09:14:08 +04:00
Andrew Borodin
b0a793c420 (input_destroy): don't call input_free_completions() twice. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-10-04 09:14:08 +04:00
Andrew Borodin
a6b3cc8f24 Typo. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-10-04 09:14:08 +04:00
Andrew Borodin
200cb115ab (widget_init): init pos_flags member to WPOS_KEEP_DEFAULT. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-10-04 09:14:07 +04:00
Egmont Koblinger
930f683019 Handle newline and tab with shift/ctrl modifiers correctly. 
MC already has its own half-ready trick: when pasting with Shift-Insert,
using the X11 extension, the newline ("Enter" as mc calls it) with the
Shift modifier pressed gets converted to a "Return", and in the editor
the Return character inserts a non-indenting newline. This makes pasting
better in terminals not supporting bracketed paste, however, it has some
problems that this commit addresses:

  * Shift+newline gets this special treatment, but Ctrl+newline gets
    dropped. Hence e.g. when pasting in Gnome-terminal with Ctrl+Shift+V
    all the newlines will be missing. This commit adds the same
    non-indenting newline behavior to Ctrl+Newline and Ctrl+Shift+Newline.

  * The code forgets about Tab that also needs special treatment:

    - Most terminals send \e[Z on Shift+Tab, this is not handled by MC
      at all, moreover it causes a hang for about a second. This commit
      teaches this sequence to MC. This is especially useful when no X11
      is available, because there Ctrl+Tab is identical to Tab, so the
      backwards tab feature is not available. With this commit Shift+Tab
      becomes a backwards tab too on all terminals that emit \e[Z.

    - When pasting to the editor, Shift+Tab, Ctrl+Tab and Ctrl+Shift+Tab
      should all insert a tab for the same reason mentioned at the newline.

    - It would look inconsistent in the keymap files to have logical code
      such as "backtab" instead of "shift-tab" and friends, hence get rid
      of KEY_BTAB and use KEY_M_SHIFT | '\t' instead.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-10-03 11:41:58 +04:00
Andrew Borodin
511850e52b (hline_callback): fix of MSG_INIT and MSG_RESIZE messages handling. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-08-02 21:58:45 +04:00
Andrew Borodin
b451e8d13d (menubar_new): add 3rd 'visible' argument. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-08-02 21:58:45 +04:00
Veres Lajos
dfbb2c9430 Typo fixes. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-07-23 14:15:24 +04:00
Andrew Borodin
ab3f53fbbe Add DIR_IS_DOT and DIR_IS_DOTDOT macros 
...to detect "." and ".." directories, respectively.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-07-23 14:15:24 +04:00
Andrew Borodin
48abe8735f Rename functions: 
init_widget -> widget_init
create_dlg -> dlg_create
init_dlg -> dlg_init
run_dlg -> dlg_run
destroy_dlg -> dlg_destroy

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-06-28 09:21:17 +04:00
Andrew Borodin
0adf569b54 (dlg_overlap): rename to widget_overlapped() 
...and move to lib/widget/widget-common.c.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-06-28 09:21:17 +04:00
Andrew Borodin
c7da120588 (dlg_replace_widget): rename to widget_replace() 
...and move to lib/widget/widget-common.c.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-06-28 09:21:17 +04:00
Andrew Borodin
1672fa44dd (dlg_widget_active): rename to widget_is_active() 
...and move to lib/widget/widget-common.c.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-06-28 09:21:17 +04:00
Andrew Borodin
970cfd881a (dlg_mouse_event): minor refactoring. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-06-28 09:21:17 +04:00
Andrew Borodin
01c5cf66a5 (dlg_default_callback): get rid of extra type cast. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-06-28 09:21:17 +04:00
Andrew Borodin
e7dc599e42 Use "'" instead of "`" for messages and comments quoting. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-06-03 14:21:03 +03:00
Andrew Borodin
6b90a1468a (button_set_text): update value of WButton::hotpos. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-06-03 14:21:02 +03:00
Andrew Borodin
6d31d85f0d Use tty_draw_box instead of draw_box() to draw frames. 
* (draw_box): remove.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-06-03 14:21:02 +03:00
Andrew Borodin
f23f0613ec Ticket #2991: fix redraw of WLabel after text change. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-04-08 15:46:39 +04:00
Andrew Borodin
30959e0b7d Clarify widget redraw in runtime. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-03-09 16:04:19 +04:00
Andrew Borodin
9b0b017201 (input_update): minor optimization: don't call str_term_width2() twice. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-03-09 16:04:18 +04:00
Andrew Borodin
e29d98336b Ticket #2971: mouse click below non-droppeddown menubar activates menu box. 
How to reproduce:
1. Switch the "Drop down menus" option off.
2. Press F9 to activate menubar. Menu is not dropped.
3. Click somewhere below menubar, on one of the files in the directory
listing.

Buggy behavior: the corresponding "Left" or "File" etc. dropdown is
opened, and the mouse button is released, menu item under the mouse
cursor is activated.

Correct behavior: clicking with the mouse somewhere other than the
active menubar doesn't open dropdown menu, instead removes the focus from
menubar and acts on the actual item under the mouse pointer (such
as a filename in the panel).

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-03-05 16:51:52 +04:00
Andrew Borodin
b66a1e0592 Code indentation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-02-14 14:42:27 +04:00
Andrew Borodin
d8340c30da Ticket #2626: special chars are not escaped in autocompletion of filenames. 
Test case:
1. Create a file with name that contains some special chars:
   touch attachment.cgi?id=564208
2. Press F6.
3. Press a. Now only the 'a' letter is in input line.
4. Press Esc Tab Enter.
5a. Input line is filled by 'attachment.cgi?id=564208'...
5b. but 'attachment.cgi\?id=564208' is expected.
6. Add 'patch_' before file name:
   'patch_attachment.cgi?id=564208'.
7. Press Enter.
8a. Result: 'patch_attachment.cgiattachment.cgi?id=564208id=564208'.
8b. Expected result: 'patch_attachment.cgi?id=564208'.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-02-14 14:30:38 +04:00
Andrew Borodin
0608af276e lib/widget/input_complete.c: minor refactoring and optimization. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-02-04 15:48:21 +03:00
Slava Zanko
f7109ab46b Fix for input completions with spaces in names. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-02-04 15:48:21 +03:00
Andrew Borodin
c308d5ed21 lib/widget/input_complete.c: refactoring: 
* (filename_completion_function): use GString to ret rid of hand-made
  low-level memory allocation.
  * (variable_completion_function): likewise.
  * (hostname_completion_function): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-02-04 15:48:21 +03:00
Slava Zanko
f866709186 Concretize the usage of autocompliting in different input fields. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-02-04 15:48:21 +03:00
Slava Zanko
2d58735deb Extend QUICK_INPUT and QUICK_LABELED_INPUT macros for getting completion flags via parameters instead of using hardcoded value 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-02-04 15:29:15 +03:00
Slava Zanko
9935acea33 Ticket #55: savannah: tab completion vs. spaces and escaping 
* Split big functions.
* Add unit tests

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-02-04 15:29:15 +03:00
Andrew Borodin
33cac494c0 WHLine: allow draw text over horizontal line. 
* (hline_set_text): new function.
  * (file_progress_show_total): use hline_set_text to show processed
  files counter.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-01-14 16:23:17 +04:00
Andrew Borodin
2176e5f283 Ticket #2076: make copy/move/delete progress dialog wider. 
Initial step: get rid of hardcoded width of progress bar.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-01-14 16:23:17 +04:00
Andrew Borodin
161a5af516 Ticket #2111: allow pause in copy/move/delete file operation. 
Initial step: if button callback retuns zero, don't close the dialog after
button press.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-12-21 13:37:39 +04:00
Andrew Borodin
30dbb79655 (del_widget): fix memory leak. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-12-20 15:35:35 +04:00
Andrew Borodin
3fc490ea12 (add_widget_autopos): don't access to NULL widget. 
(del_widget): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-12-20 15:35:35 +04:00
Andrew Borodin
7b184ddea4 PCRE_CFLAGS are CPPFLAGS, actually. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-12-18 16:27:49 +04:00
Andrew Borodin
281209c79d lib/widget/*.[ch]: fix indentation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-20 13:27:10 +04:00
Andrew Borodin
4e90c1a229 Internal menu structures are opaque now. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:44:14 +04:00
Andrew Borodin
2ec122bc05 Add useful macros for widget type cast. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:44:14 +04:00
Andrew Borodin
665d238ffa Unify widget and dialog message handling. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:44:14 +04:00
Andrew Borodin
497b69c106 Remove DLG_WANT_IDLE. Use W_WANT_IDLE instead. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:44:13 +04:00
Andrew Borodin
843dcd104e Rename Dlg_head to WDialog. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:47 +04:00
Andrew Borodin
0078874613 Rename default callbacks of widget and dialog. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:47 +04:00
Andrew Borodin
cab525049f (query_dialog): center label horizontally. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:47 +04:00
Andrew Borodin
bafc778ee7 Horizontal centering of multi-line label: center each line independently. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:46 +04:00
Andrew Borodin
96795565f5 (query_dialog): add horizontal line. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:46 +04:00
Andrew Borodin
f14cee4e18 Remove DLG_REVERSE flag. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:46 +04:00
Andrew Borodin
03829a7e6e Don't apply DLG_REVERSE flag to the listbox window 
...since this dialog contains single widget.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:46 +04:00
Andrew Borodin
612c32349d (quick_widget_t): add pos_flags member. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:46 +04:00
Andrew Borodin
322bf132d7 (QUICK_BUTTONS_OK_CANCEL): new macro for often-used dialog buttons. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:46 +04:00
Andrew Borodin
298201d305 Drop old QuickWidget engine. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
581cb4b38e (fg_input_dialog_help): use new quick dialog engine. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
e97ac7507a New QuickDialog engine. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
706c966af8 (groupbox_set_title): new function. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
8623039fe8 (groupbox_new): ignore empty string as title. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
e009cd9ea9 (create_dlg): ignore empty string as title. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
d4b95ea14d (button_set_text): don't forced redraw the entire dialog. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
c59a14d438 Associate label with input line and enable/disable them as pair. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
e6f467c875 Add flags to place widgets with horizontal and vertical centering in dialog. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
1206d156bf (widget_set_options): new function to set/reset widget options. 
Adjust enable/disable widgets.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
8b9fc35b95 WHLine: adjust initialization. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
dc5c49a395 WInput: handle WIDGET_RESIZED. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:45 +04:00
Andrew Borodin
c6ddd28366 Unification of widget and dialog callback functions. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:44 +04:00
Andrew Borodin
05d7f3c84e Aggressive use WIDGET macro. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:44 +04:00
Andrew Borodin
2a95cb2ffd Ticket #2919: widget system improvements and unifications. 
First step: derive dialog from widget.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-19 21:42:44 +04:00
Andrew Borodin
2940b7455d Fix of DOXYGEN docs: @return instead of @returns 
...and other minor corrections.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-09 10:05:13 +04:00
Andrew Borodin
82bb9c39da Define winch_flag as volatile sig_atomic_t. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-09 10:05:13 +04:00
Andrew Borodin
794145090d Fixups of SIGWINCH handling. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-09 10:05:13 +04:00
Andrew Borodin
b2f97443e2 Refactoring of subshell support. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-10-21 18:19:47 +04:00
Andrew Borodin
ea2c57dbd6 Optimization of SIGWINCH handling. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-10-21 18:19:06 +04:00
Andrew Borodin
d82757d233 Ticket #2917: Makefile.ams cleanup: remove unused AM_CPPFLAGS. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-10-20 15:24:30 +04:00
Andrew Borodin
f3cc7de694 Ticket #2898: fix broken path completion on paths starting with ~/. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-09-27 14:25:18 +04:00
Ilia Maslakov
55c8f041da fixed doxygen documentation 
Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
 2012-09-10 14:29:53 +03:00
Andrew Borodin
8b382756bf Use g_strndup() instead of g_strdup() 
...to ret rid of extra calculation of string length.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-09-10 14:29:53 +03:00
Andrew Borodin
908e747861 Optimization of ini files load. 
Some ini files (keymaps, skins) are loaded in read-only mode. For those
files, we don't need load and keep comments.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-07-31 14:50:11 +04:00
Andrew Borodin
b37af47023 Makefile.ams cleanup. 
Set defines via CPPFLAGS variable not via CFLAGS one.
Use AM_CPPFLAGS and AM_CFLAGS variables instead of per-target ones.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-07-17 17:04:05 +04:00
Slava Zanko
94bd4b1f78 Code indentation. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2012-07-17 17:04:05 +04:00
Andrew Borodin
23c95d36ac Code cleanup: removed unused variables amd removed unnedeed code. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-07-17 17:04:05 +04:00
Andrew Borodin
14a4eefc43 Fix typos. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-07-17 17:04:05 +04:00
Andrew Borodin
1f45b0822e Menubar: ignore GPM_UP event. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-06-20 16:46:35 +04:00