Commit Graph

373 Commits

Author SHA1 Message Date
Andrew Borodin
9ac5d5207c Minor optimization of tty_draw_box() function.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-05-05 16:24:14 +04:00
Vit Rosin
2eb870c9c9 Ticket #2041: check return value of g_strdup_printf() in mc_log().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-05-05 16:24:14 +04:00
Vit Rosin
993d678ed9 Use EXIT_FAILURE symbolic name as return code.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-05-05 16:24:14 +04:00
Andrew Borodin
9547a991cb Ticket #2119: some trivial corrections.
Trivial changes in util.h. Type cast in str_move function.

Thanks Vit Rosin for original patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-05-05 16:24:14 +04:00
Andrew Borodin
933aba001d Some optimizatioms in vfs.c.
Avoid some else branches. Type accuracy.

Thanks Vit Rosin for original patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-05-05 16:24:14 +04:00
Andrew Borodin
e70db42deb Grammar.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-05-05 16:24:13 +04:00
Andrew Borodin
4cea5be1ac Ticket #2097: clean up before 4.7.2 release.
Split assignments and conditions. Type accuracy. Minor optimization.

Thanks Vit Rosin for original patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-05-05 16:23:51 +04:00
Slava Zanko
3a1e0966ae Final Indentation of all touched files
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-05-04 17:34:21 +03:00
Enrico Weigelt, metux IT service
303833d590 Ticket #1897: Build breaks on ignored return values
Changes into lib directory

 * samba: handling result of system() call
 * rpc: handling write errors
 * ftpfs: ignoring result of fwrite() on logfile (make compiler happy ;-))
 * fish: proper handling of file io calls
 * ignoring result of fwrite() on logfile (make compiler happy ;-))
 * lib/util.c: handling fwrite() call errors in mc_util_write_backup_content()
 * lib/utilunix.c:
  * handling possible error on dup() in close_error_pipe()
  * handling possible error on getcwd() in mc_realpath()

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-05-04 17:34:20 +03:00
Yury V. Zaytsev
28eda66803 Ticket #1671: i18n_checktimelength may vary depending on the season
On some systems i18n_checktimelength may vary not only depending on the
locale but also on the current month. This patch introduces a cyclic
check that loops through all of the months to find out which one has the
longest name.

However, since this function is called on every pannel reload and now
makes 24 calls to str_term_width1 and strftime it makes sense to
introduce a cache for the resulting value.

Thanks to Sergey Fionov <fionov@gmail.com> for the initial patch.

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2010-05-02 13:21:09 +02:00
Andrew Filonov
d9ebcebdc1 Another side of this bug, missed before
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-04-30 10:49:16 +03:00
Andrew Filonov
fc6cf6bf3f Ticket #2122: Y2k bug in uzip vfs
Newest version of unzip returns year of file with 4 digits.
But regexp in uzip checks only 2 digits.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-04-30 10:49:16 +03:00
Ilia Maslakov
329ef3846a Ticket #120 (View diff files)
added src/diffviewer/ydiff.[ch] into project tree
    added entry 'View diff files' into 'Command' menu
    added 'diffviewer' color pairs
    fixed Makefile and configure.am
    added new binding CmdDiffView into '[main]' section
    Big thanx to 'Daniel Borca <dborca@yahoo.com>' for ydiff

Signed-off-by: Ilia Maslakov <il.smind@gmail.com>

    Added diffviewer own library

Signed-off-by: Slava Zanko <slavazanko@gmail.com>

    Fixed CFLAGS for diffviewer.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>

    changed skins, added section
        [diffviewer]
            added=
            changedline=
            changednew=
            changed=
            removed=
            folder=
            error=

Signed-off-by: Ilia Maslakov <il.smind@gmail.com>

Reimplementation of hardcoded shortcuts to keybindings.

Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-26 11:44:15 +04:00
David Sterba
2a465cb8b5 Ticket #2149: patches adding a single line are not shown correctly by patchfs.
The problem:

$ cat < test.diff
--- a/foo
+++ b/foo
@@ -0,0 +1 @@
+bar

$ mcview test.diff#patchfs/a/foo.diff
--- a/foo
+++ b/foo

'+bar' line is not shown.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-25 10:07:49 +04:00
Andrew Borodin
b266527c5f Applied MC indentation policy.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-23 11:54:25 +04:00
Andrew Borodin
c0c744ba08 Ticket #1660: color keyword names unification.
Changed name of following color keywords:

menu -> menunormal
linestate -> editlinestate

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-22 16:09:52 +04:00
Artem S. Tashkinov
07de6670ed Ticket #2050: extfs/urar: disable user/system configuration for list and copyout operations.
My system wide .rarrc contains these switches

switches= -m5 -mdG -r -s -t -ol -tl

So whenever you list the contents of any archive or copy a file out of
it, RAR/UNRAR will traverse *all* sub directories (note -r, recursive
switch) in a current directory trying to find *all* archives with the
same name. So, the net result might be that unrar/rar will extract
the wrong file and spend a lot of time trying to find archives with
the same name.

That's why I strongly suggest disabling user/system configuration
for archive list and copyout operations (note the added -cfg switch).

I have contacted Eugene Roshal and he said that he won't disable -r switch
for extract and archive list operations, so, we can only fix this problem
on our side.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-22 10:18:46 +04:00
Artem S. Tashkinov
8bdd7bc764 Ticket #2049: extfs/urar doesn't correctly shows localized filenames in RAR archives.
There's no need to export LC_ALL.

Signee-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-20 16:56:41 +04:00
Andrew Borodin
7161567ea8 Ticket #1648: fixed frame corners for NCurses screen library.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-14 14:38:22 +04:00
Andrew Borodin
a708b5c514 Applied MC indentation policy.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-06 11:16:11 +04:00
Andrew Borodin
b0be11acd5 Merged tty_draw_double_box() function into tty_draw_box() one.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-06 10:30:58 +04:00
Andrew Borodin
4e57b599cc Renamed frame symbol names.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-06 10:30:58 +04:00
Andrew Borodin
9a145a88ce Added capability to draw single or double lines.
Fixed tty_print_alt_char() to draw single or double vertical
or horizintal lines.
Added argument to tty_print_one_hline() and tty_print_one_vline()
functions to draw single or double lines.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-06 10:30:58 +04:00
Andrew Borodin
cc2f5670ec Created new function: tty_draw_double_box().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-06 10:30:58 +04:00
Andrew Borodin
be3b0119da Fixed tty_print_alt_char() function for NCurses.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-06 10:30:58 +04:00
Sergei E. Ovsyannikov
d8fb069e85 Ticket #1648: implemented single-line boxes.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-06 10:30:58 +04:00
Andrew Borodin
58909eb708 Ticlet #1909: fix of extfs_read_archive() function.
Fixed bug introduced in ad9c1daad8 commit:
incorrect handling of "." and ".." directories within atchives.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-04-03 11:10:29 +04:00
Andrew Borodin
5b68413e62 Applied MC indentation policy.
Applied MC indentation policy to all files modified in this branch
with some simple manual modifications.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:22 +04:00
Vit Rosin
07a7f446b0 Ticket #2108: Fixed memory leak in fish_linear_start() function.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:22 +04:00
Slava Zanko
2dc590fe62 lib/util.c: Fixed memleak in load_mc_home_file() function
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-03-30 16:21:22 +04:00
Andrew Borodin
e94c1393e6 Fixed memory leak in mc_search__cond_struct_new_regex_accum_append().
Minor optimization.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:22 +04:00
Andrew Borodin
3c88948c9d Fixed memory leak in mc_closedir().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:21 +04:00
Andrew Borodin
f547d149ba Fixed memory leak in vfs_free_handle().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:21 +04:00
Andrew Borodin
407d1f38f5 Fixed memory leak in vfs_s_getlocalcopy().
Thanks Vit Rosin for the original patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:21 +04:00
Vit Rosin
c6a5837f6d Ticket #2069: fixed memory leaks.
Fixed memory leak in mc_config_read_file().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:21 +04:00
Andrew Borodin
68d7a77210 Fixed of GSList item deallocation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-05 17:29:28 +03:00
Andrew Borodin
34d74f09b1 Ticket #1909: don't interpret trailing '+' as a plugin name.
If EXTFS plugin doesn't require a file, that file name must
be finished with '+': for example, rpms+. But trailing '+'
actually is not a part of plugin name, it is an plugin attrubute.
But in the current time trailing '+' must be used in VFS command:

cd #rpms+

instead of

cd #rpms

This commit simplifies the usage of some EXTFS plugins.

Also fixed VFS README.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-05 17:29:28 +03:00
Slava Zanko
7206d2cc6c Fixed wrong colors
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-26 14:22:31 +02:00
Slava Zanko
5354d59337 Identation of some source files.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-26 11:26:00 +02:00
Slava Zanko
cd8b350b6d UNDELFS: code cleanup
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-26 10:58:49 +02:00
Slava Zanko
bff2f7303b Cleanup: avoid warnings for mc-library on x86_64
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-26 10:58:49 +02:00
Slava Zanko
1b75ea27b6 Cleanup of code for master
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-26 10:58:49 +02:00
Andrew Borodin
2cf080d18f Ticket #2058: fixed memory leaks in _vfs_get_cwd() function.
Thanks Vit Rosin to found memory leak in _vfs_memleak() function.
This function was rewritten to fix two memory leaks.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 21:44:07 +03:00
Andrew Borodin
a78115ad8e Fixed variable declarations and added missing includes.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 16:22:43 +00:00
Andrew Borodin
9b36242128 Ticket #1972: fixed broken monochrom support in NCurses-based MC.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 13:54:32 +00:00
Vit Rosin
3770047407 Ticket #2053: fixed memory leak in mc_symlink() function.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 12:08:01 +00:00
Slava Zanko
e1d1e9254d Change progressbar dialog.
* Minimizing dialog;
 * Optimizations of Copy/move progress dialog creation;
 * Added enum for specify dialog type (for copy/move or for delete)
 * Little optimization.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
2010-02-24 10:40:11 +02:00
Slava Zanko
804ca8e7b0 Added indication of total BPS and ETA for file operations.
* Optimized functions calls (changed return type of all file_progress_show*() functions)
 * Reworked for use global structure FileOpTotalContext
 * Moved declarations of file_progress_show*() functions from fileopctx.h to filegui.h
 * Code for calculate progressbar's variables was moved into function copy_file_file_display_progress()
 * Progressbar for little files now shows always 100% (for visible effect)
 * Added i18n string '< 1 sec'
 * Rework of progress copy dialog

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 10:37:43 +02:00
Andrew Borodin
159f5fdff1 Type accuracy in file operation routines.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 10:37:42 +02:00
Andrew Borodin
492ccbe0ee Ticket #1999: changed color of inactive visible main menu.
Added 'menuinactive' skin item to draw incative visible
main menu.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-23 19:01:56 +03:00