Commit Graph

13379 Commits

Author SHA1 Message Date
Andrew Borodin
a52cb840ae (tree_chdir, sync_tree): take vfs_path_t object to avoid double conversion of path.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
387f41f9ce (set_display_type): ret rid of string reduplication. 2016-03-04 09:23:37 +03:00
Andrew Borodin
1fea17b052 (expand_format): ret rid of extra string duplication.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
db1c906ada (edit_get_file_name): return pointer to const. 2016-03-04 09:23:37 +03:00
Andrew Borodin
3168354217 (put_link): use sizeof() for buffer size.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
4a47f88eac (put_prog_name): ret rid of extra string duplication.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
a038484a06 (tree_selected_name): return pointer to const.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
f186e2a151 (panel_operate): minor optimisation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
f292071b35 (panel_operate): ret rid of extra string duplication.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
10ad7aaa22 (panel_operate): fix memory leak.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
f1c56ea55a Change type of WInfo::ready from int to boolean. 2016-03-04 09:23:37 +03:00
Andrew Borodin
3e2d677d64 info.c: remove uneeded include.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Mooffie
ca28e59d08 Ticket #3587: "Listing mode" dialog: remove old code.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
e9f3b526dd Cleanup: mountlist.c: remove unused read_file_system_list() parameter.
need_fs_type and all_fs are never varied.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
78db983626 Cleanup: args.c: recude function scope for mcedit_arg_*.
Reduce to scope for
    mcedit_arg_new (const char *file_name, long line_number)
    mcedit_arg_vpath_new (vfs_path_t * file_vpath, long line_number)
and move to file scope section.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
7146508b31 Cleanup: usermenu.c: use const edit_widget.
Use const because edit_widget not altered in these functions.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
fb3d0f13b3 Cleanup: setup.c: reduce function scope.
Reduce scope for
    void save_config (void);
    void save_layout (void);
    void panels_load_options (void);
    void panels_save_options (void);
and move code to file scope section.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andreas Mohr
7da330ce77 Ticket #3586: mcedit - fix "Lower case selection" command in User Menu
Fix bug #3586 reported by rimf (plus minor tweak remove unneeded
cat/pipe command)

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-03-04 09:23:36 +03:00
Andreas Mohr
9aeacda0d9 lib/vfs/direntry.c: remove unused variables.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
b8d6d348a3 Fix parameter in load_hint() calls.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
dd60bf40dc (get_random_hint): modify time measurement.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
bad3171a0a (edit_symlink_cmd): refactoring.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
6f5fc5d528 (get_random_hint): move to src/filemanager/midnight.c.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
1e302a3c63 (get_random_hint): minor optimisation and type accuracy.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
28ce7e566e (load_mc_home_file): return data length.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
e3e4382612 (mcview_load): minor optimisation:
* read compression type in magic mode only;
 * free temporary variables immediately after use.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
ab2ec1b341 (cpio_open_cpio_file): restore file offset after read of magic number.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
e01a89059b (tar_open_archive_int): restore file offset after read of magic number.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
c4258d453b Clarify AM_CPPFLAGS.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
be158faca6 filehighlight: clarify includes.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Mooffie
0d9b120a63 Makefile is missing subshell.h.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
0eae2cb8dc Unify m4 macro names.
Macros get from other projects keep their original names:
gl_FSTYPENAME, AX_PATH_LIB_PCRE, etc.

Macros initially writtem for MC have original names with prefix mc_:
mc_VERSION, mc_CHECK_GLIB, etc

Macros get from other projects and modified for MC keep their
original names with prefix mc_:
mc_cu_PREREQ_STAT_PROG, mc_AC_GET_FS_INFO.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
cc34f778ed rename: m4.include/ac-glib.m4 -> m4.include/mc-glib.m4
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andreas Mohr
2d7430b520 Cleanup unused option_edit_*_extreme variables.
one-way variables as source for macro definitions

Signed-off-by: Andreas Mohr <and@gmx.li>
2016-03-04 09:23:36 +03:00
Andreas Mohr
c2060a420a Clarify macro variables for USE_INTERNAL_EDIT.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andreas Mohr
785a2fc6e9 (ftpfs_load_no_proxy_list): cleanup unneeded mc_file static cast.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andreas Mohr
d72390a45d Cleanup internal filemanager layout variables.
_free_space and _xterm_title never used.
_command_prompt, _keybar_visible, _menubar_visible, _message_visible used within layout_callback() only.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andreas Mohr
686ce302bd Clarify mc_args__debug_level declare.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
1528f8e4c4 src/filemanager/usermenu.c: use gboolean type for boolean variables.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
1c26cf804a src/filemanager/usermenu.c: apply coding guidelines.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
0e1dfbf2b9 (regex_command_for): minor optimisation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Yury V. Zaytsev
391821e4ab Ticket #3379: fix bashism in gitfs+ extfs helper
Original reporter: Raphael Geissert <atomo64@gmail.com>, upstreamed by
Dmitry Smirnov <onlyjob@member.fsf.org>.

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-03-04 09:23:36 +03:00
Andrew Borodin
88b489ee33 filehighlight.ini: externsions are alphabetically sorted.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
b3f4fc2212 Ticket 3547: code cleanup bebore 4.8.16 release.
filehighlight.ini: add lzma extension.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Yury V. Zaytsev
10a1c9d846 Merge branch '3577_file_copy_preallocation' 2016-03-02 21:18:13 +01:00
Andrey Gursky
47830e09b4 src/filemanager/file.c: (copy_file_file) fix typo in the error message
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-02-29 22:17:35 +01:00
Andrey Gursky
5f63997891 Type accuracy in file operation routines (leftovers)
These are leftovers of 159f5fdff1.

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-02-29 22:16:29 +01:00
Andrey Gursky
9ee5766748 Ticket #3577: Fix preallocation if appending during file copy
The value of `ctx->do_append` is reset:

    appending = ctx->do_append;
    ctx->do_append = FALSE;

Use `appending` in following conditionals instead.

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-02-29 22:12:28 +01:00
Yury V. Zaytsev
f69b08bbd0 Merge branch '3599_fish_minor_major' 2016-02-29 21:48:24 +01:00
Andreas Mohr
ee6dd89deb Ticket #3599: provide major/minor info for block/char devices (FISH)
Perl ls helper did not provide major/minor info for block/char devices,
and `ls -lan` wasn't working because of a typo.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-02-28 22:03:37 +01:00