Yury V. Zaytsev
a8f512c12c
Remove unneeded struct
keyword for typedef'd structs
...
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-03-04 09:23:38 +03:00
Andreas Mohr
561923d643
src/editor/edit.c: Cleanup some compiler warnings
...
edit.c:909:12: warning: implicit conversion changes signedness: 'int' to 'unsigned long' [-Wsign-conversion]
return r;
~~~~~~ ^
edit.c:1689:11: warning: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
col = edit_get_col (edit);
~ ^~~~~~~~~~~~~~~~~~~
edit.c:2361:17: warning: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
d = edit->undo_stack[(sp - 2) & edit->undo_stack_size_mask];
~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
edit.c:2371:17: warning: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
d = edit->undo_stack[spm1];
~ ^~~~~~~~~~~~~~~~~~~~~~
edit.c:2440:17: warning: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
d = edit->redo_stack[(sp - 2) & edit->redo_stack_size_mask];
~ ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
edit.c:2450:17: warning: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
d = edit->redo_stack[spm1];
~ ^~~~~~~~~~~~~~~~~~~~~~
edit.c:2970:27: warning: implicit conversion loses integer precision: 'long' to 'int' [-Wshorten-64-to-32]
q = edit->curs_col;
~ ~~~~~~^~~~~~~~
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:38 +03:00
Andreas Mohr
ae7dacb6f1
src/editor/editbuffer.c: Cleanup some compiler warning
...
editbuffer.c:428:12: warning: implicit conversion changes signedness: 'long' to 'gsize' (aka 'unsigned long') [-Wsign-conversion]
*cut = cut_len;
~ ^~~~~~~
editbuffer.c:518:44: warning: implicit conversion loses integer precision: 'off_t' (aka 'long') to 'guint' (aka 'unsigned int') [-Wshorten-64-to-32]
g_ptr_array_remove_index (buf->b2, i);
~~~~~~~~~~~~~~~~~~~~~~~~ ^
editbuffer.c:554:44: warning: implicit conversion loses integer precision: 'off_t' (aka 'long') to 'guint' (aka 'unsigned int') [-Wshorten-64-to-32]
g_ptr_array_remove_index (buf->b1, i);
~~~~~~~~~~~~~~~~~~~~~~~~ ^
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:38 +03:00
Andreas Mohr
1b8a5d2196
src/editor/editwidget.c: Cleanup some compiler warnings
...
editwidget.c:808:12: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'cb_ret_t' [-Wsign-conversion]
return ret;
~~~~~~ ^~~
editwidget.c:857:71: warning: implicit conversion changes signedness: 'unsigned char' to 'char' [-Wsign-conversion]
char_for_insertion = convert_from_8bit_to_utf_c2 ((unsigned char) x_key);
~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~~~~~
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
a5ebb7d619
(etags_set_definition_hash): refactoring:
...
* type accuracy;
* reduce variable scope;
* trivial optimisation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
4bd1008a03
Add -Wassign-enum compiler wirning.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
ea10f33dbb
(widget_options_t): add W_DEFAULT value to cleanup -Wassign-enum warnings.
...
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
cca1dd2ac3
Add three new compiler warnings:
...
Wconditional-uninitialized
Wfloat-conversion
Wlogical-not-parentheses
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
a482f38581
Cleanup -Wfloat-conversion warning.
...
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
2a5b76b09b
(edit_block_copy_cmd): cleanup -Wconditional-uninitialized warning.
...
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
20ef10038f
(edit_search_fix_search_start_if_selection): cleanup -Wlogical-not-parentheses warning.
...
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
829738baa7
(mc_error_message): make output format translatable.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
1de0434c61
Find File: clarify description of exit from panelize mode.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Mooffie
0c1e480e05
WPanel should report MSG_NOT_HANDLED for unhandled commands.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
6a0767360d
Sync with gnulib 781788eeb5d4d0b816698e8629300cd90a7379bd.
...
mountlist: recognize autofs-mounted remote file systems, too.
src/filemanager/mountlist.c (ME_REMOTE): Return true if a file system
i named "-hosts" because it is used by autofs to mount remote file
systems.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
4db17d31f9
lib/widget/input.c: (quote): change type to gboolean.
2016-03-04 09:23:37 +03:00
Andrew Borodin
a52cb840ae
(tree_chdir, sync_tree): take vfs_path_t object to avoid double conversion of path.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
387f41f9ce
(set_display_type): ret rid of string reduplication.
2016-03-04 09:23:37 +03:00
Andrew Borodin
1fea17b052
(expand_format): ret rid of extra string duplication.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
db1c906ada
(edit_get_file_name): return pointer to const.
2016-03-04 09:23:37 +03:00
Andrew Borodin
3168354217
(put_link): use sizeof() for buffer size.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
4a47f88eac
(put_prog_name): ret rid of extra string duplication.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
a038484a06
(tree_selected_name): return pointer to const.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
f186e2a151
(panel_operate): minor optimisation.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
f292071b35
(panel_operate): ret rid of extra string duplication.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
10ad7aaa22
(panel_operate): fix memory leak.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andrew Borodin
f1c56ea55a
Change type of WInfo::ready from int to boolean.
2016-03-04 09:23:37 +03:00
Andrew Borodin
3e2d677d64
info.c: remove uneeded include.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Mooffie
ca28e59d08
Ticket #3587 : "Listing mode" dialog: remove old code.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
e9f3b526dd
Cleanup: mountlist.c: remove unused read_file_system_list() parameter.
...
need_fs_type and all_fs are never varied.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
78db983626
Cleanup: args.c: recude function scope for mcedit_arg_*.
...
Reduce to scope for
mcedit_arg_new (const char *file_name, long line_number)
mcedit_arg_vpath_new (vfs_path_t * file_vpath, long line_number)
and move to file scope section.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
7146508b31
Cleanup: usermenu.c: use const edit_widget.
...
Use const because edit_widget not altered in these functions.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:37 +03:00
Andreas Mohr
fb3d0f13b3
Cleanup: setup.c: reduce function scope.
...
Reduce scope for
void save_config (void);
void save_layout (void);
void panels_load_options (void);
void panels_save_options (void);
and move code to file scope section.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andreas Mohr
7da330ce77
Ticket #3586 : mcedit - fix "Lower case selection" command in User Menu
...
Fix bug #3586 reported by rimf (plus minor tweak remove unneeded
cat/pipe command)
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-03-04 09:23:36 +03:00
Andreas Mohr
9aeacda0d9
lib/vfs/direntry.c: remove unused variables.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
b8d6d348a3
Fix parameter in load_hint() calls.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
dd60bf40dc
(get_random_hint): modify time measurement.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
bad3171a0a
(edit_symlink_cmd): refactoring.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
6f5fc5d528
(get_random_hint): move to src/filemanager/midnight.c.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
1e302a3c63
(get_random_hint): minor optimisation and type accuracy.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
28ce7e566e
(load_mc_home_file): return data length.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
e3e4382612
(mcview_load): minor optimisation:
...
* read compression type in magic mode only;
* free temporary variables immediately after use.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
ab2ec1b341
(cpio_open_cpio_file): restore file offset after read of magic number.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
e01a89059b
(tar_open_archive_int): restore file offset after read of magic number.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
c4258d453b
Clarify AM_CPPFLAGS.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
be158faca6
filehighlight: clarify includes.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Mooffie
0d9b120a63
Makefile is missing subshell.h.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
0eae2cb8dc
Unify m4 macro names.
...
Macros get from other projects keep their original names:
gl_FSTYPENAME, AX_PATH_LIB_PCRE, etc.
Macros initially writtem for MC have original names with prefix mc_:
mc_VERSION, mc_CHECK_GLIB, etc
Macros get from other projects and modified for MC keep their
original names with prefix mc_:
mc_cu_PREREQ_STAT_PROG, mc_AC_GET_FS_INFO.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andrew Borodin
cc34f778ed
rename: m4.include/ac-glib.m4 -> m4.include/mc-glib.m4
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-03-04 09:23:36 +03:00
Andreas Mohr
2d7430b520
Cleanup unused option_edit_*_extreme variables.
...
one-way variables as source for macro definitions
Signed-off-by: Andreas Mohr <and@gmx.li>
2016-03-04 09:23:36 +03:00