Andrew Borodin
a18cf7bae6
(do_enter): make inline and return gboolean instead of int.
...
(do_enter_on_file_entry_t): rename back to do_enter_on_file_entry and
return gboolean instead of int.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:07 +04:00
Andrew Borodin
2c551edd61
(panel_get_title_without_hotkey): return pointer to static buffer
...
...to avoid extra memory allocation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:07 +04:00
Andrew Borodin
84ce2f2b25
Sync with gnulib f345edc03da1a81f313dd70305764025bffeb1fa.
...
Port 'open' and 'close' redefinitions to AIX 7.1.
Do not #undef 'open' and 'close'. AIX 7 does '#define open open64' and
then 'int open64(const char *, int, ...);', which means the declaration
for 'open' gets lost if we later '#undef open'. Discovered while
building grep pretest 2.18.151-1c770 on AIX 7.1, where the compilation
reported the non-fatal error "In function 'openat_proc_name' ...
warning: implicit declaration of function 'open'". In this case the
error is relatively harmless, but in other cases it might not be so
minor.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:07 +04:00
Andrew Borodin
40caba34a9
src/filemanager/panel.c: clarify condition in 'for' statements.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:07 +04:00
Andrew Borodin
443b845b0f
(move_selection): variable is boolean instead of int.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:07 +04:00
Andrew Borodin
65f7dc3ea1
(maybe_cd): argument is boolean instead of int.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
248a5fc74a
src/filemanager/panel.c: use variable initialization
...
...to remove one branch in 'if' statement.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
fea7491386
src/filemanager/panel.c: 'else' after 'return' is useless.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
ac3aaac556
src/filemanager/panel.[ch]: make some functions inline.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
5a1fed2d98
src/filemanager/panel.c: cosmetics: empty lines, extra braces.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
caa916e94f
(parse_display_format): minor optimization: get rid of strchr() call.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
3fb9627ead
src/filemanager/panel.[ch]: use gboolean instead of int for boolean variables.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
67e6bb8cac
(use_display_format): refactoring of panel column size calculation.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
e6030d8e74
Sync with gnulib 94ee038129c3b40510ef0ff6ac6ddfe85bf0f97f.
...
(xstrtoumax): use enum instead of 0, to pacify IRIX 6.5 cc.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
acf34eb98e
(mc_config_get_string_list): clarify usage.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
725997c8d0
(mc_config_get_groups): optimization of function itself and usage.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
e62906473b
(mc_config_get_keys): optimization of function itself and usage.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
dbf405d290
(mcview_display_text): minor optimization.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:12:06 +04:00
Andrew Borodin
ec7193af37
misc/ext.d/image.sh: minor clarification in image view/open actions.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
24c14153c5
(ftpfs_netrc_lookup): fix null check after dereference
...
...and simplify.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
e33a48fc95
(tar_read_header): fix dereference of null pointer.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
c9d9a8ba93
(sftpfs_open_socket): fix condition of port check.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
8c040b46b8
(x_basename): fix dereference of null pointer.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
a6c5c82fa0
(str_ascii_fit_to_term): fix out-of-bound write.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
4e5819d169
(str_8bit_fit_to_term): fix out-of-bound write.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
708f474d1e
(mc_search_regex__process_append_str): fix possible dereference of null pointer.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
e7252b6603
(lock_extract_info): fix out-of-bound writes.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
2d9cf4cad1
(vfs_s_get_line_interruptible): disable interrrupt after finish of read
...
...and type accuracies.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
33633d610b
(extfs_get_plugins): fix possible file descriptor leak.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
27a14760da
(fish_file_store): fix memory leak.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
fa22898f57
(fish_dir_load): fix usage of unitialized variable.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:41 +04:00
Andrew Borodin
ce1c97bd7d
(ftpfs_dir_load): fix usage of unitialized variable.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:40 +04:00
Andrew Borodin
76d61edc1e
(mouse_get_local): initialize local.modifiers.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:40 +04:00
Andrew Borodin
2f69f5b929
(move_dir_dir): fix usage of unitialized variable.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:40 +04:00
Andrew Borodin
1e17ba4cf7
(background_attention): fix usage of uninitialized variable.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:40 +04:00
Andrew Borodin
91105137f7
(tar_fill_stat): initialize st->st_dev.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:40 +04:00
Andrew Borodin
19c4158152
(render_edit_text): fix usage of uninitalized variable.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:40 +04:00
Andrew Borodin
db951c0d7e
lib/widget/dialog-switch.c: fix the FSF name.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:40 +04:00
Andrew Borodin
125165c9b6
Ticket #3189 : code cleanup before 4.8.13 release.
...
(sigchld_handler_no_subshell): clarify condition.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-07-22 13:10:40 +04:00
Andrew Borodin
4253f59d38
Merge branch '3219_mcviewer_raw_parse_switch'
...
* 3219_mcviewer_raw_parse_switch:
Ticket #3219 : mcviewer: fix switch between raw and parse modes.
2014-07-08 13:29:23 +04:00
Andrew Borodin
d4f77d05e2
Ticket #3219 : mcviewer: fix switch between raw and parse modes.
...
Partially revert 2640b21bb9
for src/mcviewer/lib.c file.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-06-11 13:48:21 +04:00
Slava Zanko
15665b1371
Merge branch '3204_viewer_default_color'
...
* 3204_viewer_default_color:
Ticket #3204 : As user, I want to use own default colors for viewer.
2014-05-07 23:03:58 +03:00
Slava Zanko
29f81d96c9
Ticket #3204 : As user, I want to use own default colors for viewer.
...
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2014-05-07 23:03:33 +03:00
Andrew Borodin
8a0dc9a867
Merge branch '3209_delete_crash'
...
* 3209_delete_crash:
Ticket #3209 : fix crash when file(s) deleting.
2014-05-07 09:42:16 +04:00
Andrew Borodin
fb21b6c757
Ticket #3209 : fix crash when file(s) deleting.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-05-06 11:10:09 +04:00
Andrew Borodin
7ce218d942
Merge branch '3196_move_file_count'
...
* 3196_move_file_count:
Rename structure: FileOpTotalContext -> file_op_total_context_t.
Ticket #3196 : fix incorrect file counting during move operation.
2014-05-04 09:37:51 +04:00
Andrew Borodin
46983140df
Rename structure: FileOpTotalContext -> file_op_total_context_t.
...
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-05-04 09:35:22 +04:00
Andrew Borodin
3a4b489265
Ticket #3196 : fix incorrect file counting during move operation.
...
Problem description:
When files are moved, let's say 10000 for example, MC first copies files
to destination. This is correctly reflected in progress bar and "Files
processed" counter which goes from 1 to 10000. But after when copying
stage is over MC deletes files and "Files processed" goes from 10000 to
20000 which looks weird because it shown like "Files processed:
15232/10000".
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-05-04 09:35:22 +04:00
Andrew Borodin
020edf6e34
Merge branch '3097_smb_recursive_find'
...
* 3097_smb_recursive_find:
Ticket #3097 : fix recursive find file on Samba share.
2014-04-29 09:53:38 +04:00
Martin Petricek
3324ed0727
Ticket #3097 : fix recursive find file on Samba share.
...
src/filemanager/file.c (do_search): the algorithm executes mc_stat() on
a file (directory) and checks number of links. It assumes number of
links minus 2 is number of subdirectories available for recursive
search. While that assumption is valid on probably all Linux
filesystems, it is not valid on mounted Samba shares. For these, number
of links (as reported by stat or seen by 'ls -l') is not 1 for most
files and 2+ for directories, but zero for all files and directories
within the share (I guess that is how the kenrel samba module works
...). Therefore the optimization (that may limit the recursion) done by
subdirs_left breaks the recursive search.
Also this patch fixes recursive search on NFS shares provided by Windows
2012R2 NFS service (ticket #3202 ).
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2014-04-29 09:45:00 +04:00