mirrors/mc
1
0
Fork 0
mirror of https://github.com/MidnightCommander/mc synced 2024-12-23 12:56:51 +03:00
Code Issues Packages Projects Releases Wiki Activity
16,052 Commits 47 Branches 83 Tags 91 MiB
8d0bb40f16
Commit Graph

522 Commits

Author SHA1 Message Date
Andrew Borodin
b9cf2898c4 Ticket #4057: blank screen with invisible error. 
How to reproduce:
Run `mcedit .` from an empty shell. mc used to show an error banner. Now
it shows black-on-black error message.

do_refresh() function expects that at least one fullscreen dialog (file
manager, editor, etc) is existing in the dialog stack. If query dialog
is created before any fullscreen one, do_refresh() do nothing.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-05-11 10:43:05 +03:00
Andrew Borodin
cef0bb0138 Fix segfault in case of click on widget that doesn't handle mouse. 
Use default mouse callback function if widget doesn't handle mouse.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-04-03 16:53:15 +03:00
Andrew Borodin
bcdd81c628 WGroup: support colors. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:17:32 +03:00
Andrew Borodin
d38eb77c8c WGroup: support state. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:17:32 +03:00
Andrew Borodin
f0e13d8fba Make WST_CONSTRUCT a default widget state. 2020-03-08 20:17:32 +03:00
Andrew Borodin
f39f05632a WGroup: support key events. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:17:32 +03:00
Andrew Borodin
2e734e5618 Make keybind map a member of Widget. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:17:32 +03:00
Andrew Borodin
326c4ce1d9 (dlg_key_event): clarify post-hotkey handling. 
Current widget is the sender of MSG_UNHANDLED_KEY message.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:17:32 +03:00
Andrew Borodin
c2aadb2ad5 WGroup: support mouse events. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:17:32 +03:00
Andrew Borodin
4b3b49faad (widget_draw): support groups. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:17:32 +03:00
Andrew Borodin
d1f9e698ac WDialog: use WBackground in frameless dialogs (screens). 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:17:32 +03:00
Andrew Borodin
a87f1e7bf6 Create WBackground widget. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:17:29 +03:00
Andrew Borodin
ed9199e94e Create WFrame widget. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:17:02 +03:00
Andrew Borodin
c77dc88ff9 WGroup: support draw. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:15:37 +03:00
Andrew Borodin
2a265e38a0 WDialog set/change size API: move to WGroup. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:15:37 +03:00
Andrew Borodin
04f04ba130 Send new widget size as parameter of MSG_RESIZE message. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:15:37 +03:00
Andrew Borodin
045816ed13 (dlg_set_position): use WRect. 
(widget_set_size_rect): new API.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:15:37 +03:00
Andrew Borodin
d13a28a91d Create WRect class. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:15:34 +03:00
Andrew Borodin
6acd8475dd Update cursor API: support groups. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:13:35 +03:00
Andrew Borodin
206baa8b9a (widget_is_active): support groups. 2020-03-08 20:13:35 +03:00
Andrew Borodin
95b4a86d44 (dlg_get_current_widget_id): rename to group_get_current_widget_id. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:13:35 +03:00
Andrew Borodin
e9d23e90f0 Find widget API: support groups. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:13:33 +03:00
Andrew Borodin
fdf3d9c3b7 WGroup: implement init & destroy. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:12:45 +03:00
Andrew Borodin
5ce511e07e Implement uniq widget ID for each widget. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:11:55 +03:00
Andrew Borodin
b9cf650605 Move send broadcast message API from WDialog to WGroup. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:11:55 +03:00
Andrew Borodin
74c510f4fb Widget and WGroup API changes: 
* (widget_destroy): new API to destroy widget.
  * (group_del_widget): rename to group_remove_widget. Don't destroy
  widget after remove it from group.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:11:55 +03:00
Andrew Borodin
22ad70ed02 Move widget add/del API from WDialog to WGroup. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:11:55 +03:00
Andrew Borodin
6eedbce076 Move widget selection API from WDialog to WGroup. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:11:39 +03:00
Andrew Borodin
d575c7058b Move winch_pending member from WDialog to WGroup. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:09:13 +03:00
Andrew Borodin
e4e0070db5 Ticket #2919: implement WGroup widget. 
WGroup is the base widget for complex objects such as windows, dialog
windows, etc.

Initial steps:
  * move widget list of dialog into WGroup class;
  * inherit WGroup from Widget;
  * inherit WDialog from WGroup.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-03-08 20:09:12 +03:00
Andrew Borodin
31b37a1f79 Ticket #4050: code cleanup before 4.8.25 release. 
Update copyright years.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-02-29 19:10:17 +03:00
Andrew Borodin
ac184ebafe Ticket #4064: fix garbage in history. 
(do_show_hist): apply new input history and current postition to avoid
use-after-free after call of history_show().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-02-21 18:24:59 +03:00
Andrew Borodin
d034500fd6 (button_set_text): do nothing if new and current texts are equal. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 13:02:31 +03:00
Andrew Borodin
b031b44823 (check_set_text): new WCheck API. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 13:02:31 +03:00
Andrew Borodin
432af88b06 (hotkey_draw): minor optimization. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 13:02:31 +03:00
Andrew Borodin
53314c58b5 (hotkey_get_text): new hotkey API. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 13:02:31 +03:00
Andrew Borodin
851d2022a9 (hotkey_equal): new hotkey API. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 13:02:31 +03:00
Andrew Borodin
32a4b1ac85 Rename hotkey API: 
* parse_hotkey to hotkey_new;
  * release_hotkey to hotkey_free.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 13:02:31 +03:00
Andrew Borodin
57c303eeaf Use g_clear_slist() and g_clear_list(). 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 12:53:20 +03:00
Andrew Borodin
f85c1c898e lib/widget/menu.c: constify some function arguments. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 12:53:20 +03:00
Andrew Borodin
65e12d1a9f (dlg_redraw): rename to dlg_draw. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 12:53:20 +03:00
Andrew Borodin
60fe701b76 (widget_redraw): rename to widget_draw. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 12:53:20 +03:00
Andrew Borodin
35f14be028 (widget_move): rename to widget_gotoyx. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 12:53:20 +03:00
Andrew Borodin
baca4ba045 Widget and WDialog API changes: 
* (widget_destroy): new API to destroy widget.
  * (del_widget): don't destroy widget after remove it from dialog.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-12-15 12:53:20 +03:00
Andrew Borodin
093571938a Ticket #4035: fix compile failure on OS X 10.9. 
Fix duplication of menu_map definition.

Move menu_map definition to lib/widget/menu.c.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-11-23 17:41:58 +03:00
Andrew Borodin
21376ec1e9 (history_show): fix order of history items. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-09-29 15:11:53 +03:00
Andrew Borodin
3c4fe21108 Ticket #4019: fix SIGWINCH handling, 
Fix regression introduced in 37ffc02422.

(tty_got_winch): don't read FIFO, just check whether it os empty or not.
It can be called many times without lost of info about SIGWINCH raises.
(tty_flush_winch): read from FIFO to make it empty.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-09-29 11:21:14 +03:00
Egmont Koblinger
6a5d4243ce Ticket #4013: menubar: fix mouse click coordinate. 
In the menu bar, click on the space character immediately before the
"File" label.

Actual: The "Left" menu opens.

Expected: The "File" menu should open, since when clicking on "File",
this space character on its left is also highlighted.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-09-08 11:41:25 +03:00
Andrew Borodin
297391fd60 (dlg_adjust_position): rename to widget_adjust_position and make public. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-09-01 19:41:12 +03:00
Andrew Borodin
2b55c54efc Menubar is always on top line of screen. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-09-01 19:41:12 +03:00
Andrew Borodin
29110e5681 Move history operation routines from lib/widget/history.c to lib/mcconfig/history.c. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-09-01 19:41:12 +03:00
Andrew Borodin
37ffc02422 Ticket #117: refactoring of SIGWINCH hangling. 
Use pipe to collect consecutive raised SIGWINCH events.
Then handle multiple events at a time treating them
as a single one.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-09-01 19:22:21 +03:00
Andrew Borodin
c4668b56f7 history: refactoring. 
Prepare to support CK_Delete in editor and viewer history.
The filepos file contains file positions and bookmarks. We must keep
them.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-08-10 09:45:27 +03:00
Andrew Borodin
883e7b17b5 (listbox_get_length): new WListbox API. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-08-10 09:45:27 +03:00
Andrew Borodin
0f02d49b0d (history_show): port to WListbox keybindings. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-08-10 09:45:27 +03:00
Andrew Borodin
a4e36d079d WListbox: add Edit, View and Enter keynindings. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-08-10 09:45:27 +03:00
Andrew Borodin
b81e4aac55 (history_show): rename variable. 
(history_dlg_data): rename member.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-08-10 09:45:27 +03:00
Andrew Borodin
644d72fed2 (history_show): constify argument. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-08-10 09:45:27 +03:00
Andrew Borodin
2fce07a7e1 (listbox_set_list): change argument type. 2019-08-10 09:45:27 +03:00
Ilia Maslakov
87428aa8ea added new keybindings (F3, F4) in history list. 
Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
 2019-08-10 09:45:27 +03:00
Andrew Borodin
7eaa51c79b Fix broken hotkeys in menu. 
Regression was introduced in f5f78ea658.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-06-18 09:34:00 +03:00
Andrew Borodin
ff7d1728e2 Menubar: support Home and End actions for Menubar. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-06-09 12:06:10 +03:00
Ilia Maslakov
4e5488d5b2 Menu: implement drop/execute menu by hotkey. 
Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-06-09 12:06:10 +03:00
Ilia Maslakov
f5f78ea658 Ticket #212: implement keybinding for menu. 
Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-06-09 12:06:10 +03:00
Andrew Borodin
3b997974ec Refactor dialog command execution. 2019-04-27 19:29:24 +03:00
Andrew Borodin
433ae45bdd Clarify checks of dialog and widget existence. 
Widget list in the dialog cannot contain empty elements.
Dialog list cannot contain empty elements too.
Therefore simplify some checks.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-02-03 13:10:00 +03:00
Andrew Borodin
1dd8a47987 Ticket #3955: code cleanup before 4.8.23 release. 
Update copyright years.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-02-03 12:44:40 +03:00
Andrew Borodin
669a8e3e17 (dlg_run_done): fix possible NULL dereference. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-09-09 19:10:43 +03:00
Andrew Borodin
b9194d8c8a (dlg_init): fix possible NULL dereference. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-09-09 19:10:43 +03:00
Andrew Borodin
a38c7f19e9 Ticket #3453: Find file: show pattern and content in the results dialog title. 
Initial step:
    * (dlg_set_title): new API.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-09-04 10:26:35 +03:00
Andrew Borodin
2a973f7a46 Use str_move() where possible. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-02-04 11:30:23 +03:00
Andrew Borodin
ddd645526a Update copyright years. 2018-02-04 11:30:22 +03:00
Andrew Borodin
73979369d1 Support __attribute__((fallthrough)) if possible. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-02-04 11:30:22 +03:00
Andrew Borodin
48d85a42b4 achown: add callback for permission buttons 
...to change behaviour of WButton objects.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-12-10 09:19:15 +03:00
Andrew Borodin
6310e07745 (button_callback): clean up unneeded type casting. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-11-17 16:01:30 +03:00
Andrew V. Samoilov
bf5abff937 (buttonbar_call): fix possible NULL dereference. 
Signed-off-by: Andrew V. Samoilov <a.samoilov@gmail.com>
 2017-11-17 16:01:29 +03:00
Andrew Borodin
7772f00aab Ticket #3780: code clean up before 4.8.20 release. 
Direct include <limits.h> for MB_LEN_MAX.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-11-17 15:59:44 +03:00
Maksim Dzabraev
16b569986e Ticket #3870: fix INPUT_COMPLETE_CD in quick widget. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-10-28 19:18:23 +03:00
Mooffie
ac23a4807c Pressing <right> and <left> in hotlist dialog doesn't refresh it. 
Signed-off-by: Mooffie <mooffie@gmail.com>
 2017-02-26 12:38:39 +02:00
Mooffie
5ea5c5deb6 Ticket #3760: Fix aborts of MSG_MOUSE_DOWN. 
This patch was supposed to get committed as part of #3571 but this never
happened. We commit it now as we depend on its functionality for the next
commit.

Signed-off-by: Mooffie <mooffie@gmail.com>
 2017-02-19 00:04:38 +02:00
Andrew Borodin
e83409b6d7 Ticket #3766: add_widget_autopos() doesn't remove focus from the previously focused widget. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-02-09 17:49:34 +02:00
Mooffie
bc46978036 (dialog_switch_list): simplify the listbox selector. 
We use the new run_listbox_with_data().

Signed-off-by: Mooffie <mooffie@gmail.com>
 2017-01-29 23:32:13 +02:00
Mooffie
11c1aff4d3 Ticket #3763: introduce run_listbox_with_data(). 
Signed-off-by: Mooffie <mooffie@gmail.com>
 2017-01-29 23:32:04 +02:00
Andrew Borodin
e9fd11bfcd Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-01-22 19:12:55 +03:00
Andrew Borodin
28ca14d73a Aggressive use of whitespace() and whiteness() macros. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-01-22 18:44:22 +03:00
Andrew Borodin
e0c02c9c77 WCheck, WRadio: send MSG_MOTIFY without parameter. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-01-22 18:44:22 +03:00
Andrew Borodin
1ff4005228 Use g_queue_free_full(). 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-01-22 18:44:22 +03:00
Andrew Borodin
8b14798cc4 setup: split integer and boolean options. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-01-22 18:44:22 +03:00
Andrew Borodin
5e2f4a8069 WCheck: change type of 'state' from int to gboolean. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-01-22 18:44:22 +03:00
Andrew Borodin
76ee3b1644 WCheck: remove unused C_CHANGE. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-01-22 18:44:22 +03:00
Andrew Borodin
d7ecbd51cf (radio_callback): cosmetics. 
* [MSG_HOTKEY]: remove extra block.
 * [MSG_KEY]: do not fall through.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-01-22 18:44:22 +03:00
Andrew Borodin
aa6055b6aa Ticket #3693: code cleanup before 4.8.19 release. 
WRadio: remove unused 'state' field.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-01-22 18:44:22 +03:00
Andrew Borodin
8550044635 Ticket #3731: add new MSG_CHANGED_FOCUS message. 
This message is sent to widgets'owner when widget's focus state is
changed.

Find file dialog: fix initial draw of ignore directories input line.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-12-10 18:31:03 +03:00
Mooffie
e68f105e0e Ticket #3718: Options/Layout/Equal split gets reverted. 
WRadio sends MSG_NOTIFY with MSG_KEY as parameter to it's owner
when selected item is changed.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-11-24 09:41:07 +03:00
Andrew Borodin
0e2833e398 MSG_INIT is handled by default. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-11-21 13:12:55 +03:00
Andrew Borodin
5169a9dd95 Ticket #3714: (dialog_change_screen_size): fix dialog resizing order. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-11-13 12:36:57 +03:00
Mooffie
607eb74cbb Ticket #3721: clean up radio widget's MSG_CURSOR. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-11-13 12:31:47 +03:00
Andrew Borodin
716479ba4f Ticket #3700: fix segfault after switch left panel to info mode. 
(widget_replace): if new widget cannot take focus, move focus to other widget
before widget replacement.

In our case, the focused file panel is replaced by Info one. Info panel
a) isn't selectable (it never takes focus) and b) uses CWD of current
panel. Therefore focus must be moved to other file panel to make it
current and correctly set up it's CWD before first draw of Info panel.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-10-23 08:08:15 +03:00
Andrew Borodin
0cc22928af lib/widget/menu.c: indentation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:52:07 +03:00
Andrew Borodin
36cc88b5f2 Reimplement widget focus/selection. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:30:20 +03:00
Andrew Borodin
599361b3fc (dlg_set_bottom_widget): rename to widget_set_bottom. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:30:20 +03:00
Andrew Borodin
d200893347 (dlg_select_widget): rename to widget_select. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:30:20 +03:00
Andrew Borodin
35451978f6 Rename WDialog APIs: 
dlg_one_up -> dlg_select_prev_widget
dlg_one_down -> dlg_select_next_widget

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:30:20 +03:00
Andrew Borodin
b19ae2b938 Refactoring of change of current widget. 
Add new WDialog APIs:

  * dlg_set_current_widget_next
  * dlg_set_current_widget_prev
  * dlg_get_widget_next_of
  * dlg_get_widget_prev_of

and use them:

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:30:20 +03:00
Andrew Borodin
47f9b77194 WMenuBar: remove WMenuBar::is_active. Use WST_FOCUSED instead. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:30:20 +03:00
Andrew Borodin
0df5ad5686 WInput: avoid double draw on resize. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:30:20 +03:00
Andrew Borodin
fd7c6c1c5d Menu: avoid double draw on resize. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:30:20 +03:00
Andrew Borodin
91c72122a8 (widget_set_size): send MSG_DRAW after MSG_RESIZE. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:30:20 +03:00
Andrew Borodin
240350db95 Refactoring of widget drawing to avoid multiple widget redraw. 
Send MSG_DRAW message immediately after MSG_FOCUS/MSG_UNFOCUS.
Thus, the MSG_DRAW message handler is the only place where widget
should be drawn. Widget should not draw itself in other message
handlers.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:30:20 +03:00
Andrew Borodin
e1a2e8f8ec WButton: remove WButton::selected. Use WST_FOCUSED instead. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:26:00 +03:00
Andrew Borodin
ad166313a4 WListbox: remove WListbox::focused. Use WST_FOCUSED instead. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:26:00 +03:00
Andrew Borodin
c37f9b770a WST_FOCUSED: add new state and handle it. 
Notify widget's owner that widget gets or loses focus.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:26:00 +03:00
Andrew Borodin
3debdac657 (menubar_callback): refactoring of menu draw after get focus and resize. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:26:00 +03:00
Andrew Borodin
41144d619c (widget_set_state): return cb_ret_t instead of gboolean. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:26:00 +03:00
Andrew Borodin
c90b806728 Don't focus widget that doesn't have the WOP_SELECTABLE option. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:26:00 +03:00
Andrew Borodin
a64a7ba2fa Use WOP_SELECTABLE option in menu. 
If menu is not active, it is not selectable also in order to disallow
select and focus the inactive menu.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:26:00 +03:00
Andrew Borodin
5ac1c5a3e0 Ticket #2919: refactoring of focus/unfocus of widgets. 
Initial step: add WOP_SELECTABLE option and set it up explicitly for
widgets that can be selected.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:26:00 +03:00
Andrew Borodin
adc6bd83d6 (dlg_adjust_position): refactoring. 2016-09-11 11:11:01 +03:00
Andrew Borodin
fb4f4674c7 Ticket #3641: code cleanup before 4.8.18 release. 
(dlg_adjust_position): don't change origin of non-centered dialog.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-09-11 11:11:01 +03:00
Andreas Mohr
b36cec44e3 Cleanup unused macros. 
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-07-29 09:32:04 +03:00
Andrew Borodin
e07408e8c7 (check_callback): clean unneeded type casting. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-07-29 09:32:04 +03:00
Andrew Borodin
b0e3552847 Refactoring of widget's position and size calculation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-07-29 09:29:36 +03:00
Andrew Borodin
86fd77155e Refactoring of dialog's position and size calculation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-07-29 09:29:36 +03:00
wwp
e629712197 Ticket #3562: fix Glib-critical asserts in empty WListbox. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-07-29 09:29:36 +03:00
Andreas Mohr
8710d2522f (variable_completion_function): cleanup Wconditional-uninitialized warning. 
input_complete.c:383:42: error: variable 'p' may be uninitialized when used here [-Werror,-Wconditional-uninitialized]
        temp = g_string_new_len (*env_p, p - *env_p);
                                         ^

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-07-29 09:29:36 +03:00
Andrew Borodin
7c74fd90f0 Ticket #3661: wrong handling of mouse clicks in long listing mode. 
This occurs if the left panel is in long listing mode and the right
panel is in full listing mode:
When the left panel is active and you click on the right side of the
panel, the click event is directed to the (inactive) right panel instead
of the (active) left panel.

This occurs if the right panel is in long listing mode:
When the left panel is active and you click on the left panel, the click
event is always directed to the (inactive) right panel. It's impossible
to click anything on the left panel, if the right panel is in long
listing mode.

Thanks Seray Rosh <seray.rosh@web.de> for intial patch.

Initial commit: refactoring of widget selection.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-07-09 19:13:20 +03:00
Andrew Borodin
b4af91dfc0 Reorganize WDialog flags. 
* DLG_FULLSCREEN: move and rename to WPOS_FULLSCREEN.
 * DLG_CENTER: move and rename to WPOS_CENTER.
 * DLG_TRYUP: move and rename to WPOS_TRYUP.
 * WDialog::fullscreen: remove, use WPOS_FULLSCREEN instead.
 * WDialog::compact: new field. Use instead of DLG_COMPACT.
 * WDialog:🎏 remove.
 * dlg_flags_t: remove.
 * dlg_create: add new agruments: pos_flags, compact. Remove
argument: flags.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:41:00 +03:00
Andrew Borodin
0933b08964 (dlg_set_position): minor refactoring. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
163d9cd94a Rename DLG_WANT_TAB to WOP_WANT_TAB and move it to widget_options_t. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
2dab74fddd By default, WOP_WANT_HOTKEY option is off. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
d44220c75f If widget wants cursor, define that explicitly. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
db0d01b9d6 Add WST_MODAL state. 
* WDialog::modal: remove. Use WST_MODAL instead.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
fd4e56bf39 WOP_TOP_SELECT: new widget option 
...to place widget on top of other widgets in dialog.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
4b72fb5f5e Join widget_state_t and dlg_state_t. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
0a2877edef Move WOP_WANT_IDLE option to widget_state_t flags 
...and rename to WST_IDLE.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
b337287336 Move WOP_DISABLED option to widget_state_t flags 
...and rename to WST_DISABLED.

  * Widget::state: new field.
  * (widget_set_state): new function.
  * (widget_set_options): symplify.
  * (input_set_options): remove.
  * MSG_ENABLE, MSG_DISABLE: new messages.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
a9fcd6c4c6 widget_state_t: new type. 
(widget_get_state): new widget API.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
f5a1dfcef4 (widget_get_options): new widget API. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
4a0cd948df Change prefix of widget options: W_ -> WOP_. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
619480c68b Ticket #3632: refactoring of widget flags. 
Initial commit: rename functions:
  * widget_default_set_options_callback -> widget_default_set_options
  * input_set_options_callback -> input_set_options

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-06-02 20:34:38 +03:00
Andrew Borodin
abbfde35b2 lib/widget/input_complete.c: apply coding guidelines. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Andreas Mohr
1bfe137d2a (command_completion_function): cleanup cppcheck warning. 
As other local functions use "text" as function parameter variable
to fix cppcheck warning:

[lib/widget/input_complete.c:569]: (error) Uninitialized variable: text

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Andrew Borodin
dcf2ac11c1 (dlg_set_top_or_bottom_widget): move to proper file section. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Andrew Borodin
bc14ff44c8 Remove min() and max() macros. Use MIN() and MAX() macros from GLib. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Andrew Borodin
0641e942e5 (input_is_empty): new WInput API. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Andreas Mohr
eef076cef6 cppcheck: Cleanup Passing NULL after the last typed argument warning 
Cleanup Passing NULL after the last typed argument warning.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Andreas Mohr
5a7d7d0087 (mouse_get_local): cleanup uninitialized warning. 
Cleanup uninitialized warning with gcc compiler (gcc-4.4.7-4.el6).

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Andreas Mohr
284a19aff1 (find_widget_type): Make Solaris Studio happy 
Make Solaris Studio 12.4 happy.

"dialog.c", line 1029: warning: argument #2 is incompatible with prototype:
        prototype: pointer to const void
        argument : pointer to function (...) returning enum (...)

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Yuri Khan
c1975a3a35 Do not duplicate alternate screen switching. 
S-Lang already handles that in SLsmg_init_smg() and SLsmg_reset_smg().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-05 10:01:13 +03:00
Yuri Khan
abb4996589 Ticket #3640: Subshell cursor position lost after window resizing. 
Refactoring: rename functions:

do_enter_ca_mode -> tty_enter_ca_mode
do_exit_ca_mode -> tty_exit_ca_mode

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-05 10:01:13 +03:00