5535 Commits

Author SHA1 Message Date
Andrew Borodin
1c22d44970 Ticket #3637: fix memory leaks in search engine.
(mc_search_set_error): new search API to set the code and message
of search error.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-22 14:16:19 +03:00
Ben Woods
1afe2a091a Ticket #3643: fix FTBFS in cons.handler.c on FreeBSD 11
Replace `min` with `MIN` macro missed in bc14ff44.

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-05-11 21:16:29 +02:00
Andrew Borodin
1a5aff3188 Clarify center scrolling of multi-column lists.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 18:20:43 +03:00
Mike Smithson
a4b51c3e81 Ticket #3130: implement center scrolling of panel.
Behavior: cause the panel to begin scrolling when the cursor
reaches the middle of the panel, so that the cursor tends to stay in
the middle of the panel on long listings. Only when you reach the
beginning or the end of the listing will the cursor move to the first or
last file.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 18:20:16 +03:00
Andrew Borodin
e251c67ef7 (feed_subshell): change type of fail_on_error from int to gboolean.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:28:47 +03:00
Andrew Borodin
4449f525e2 (dview_save_options): clarify boolean options.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andrew Borodin
2151edaff2 Get rid of global variables mc_main_config and mc_panels_config.
Use mc_global.main_config and mc_global.panels_congig instead.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andreas Mohr
f03bb30a5a (update_split): cleanup cppcheck warning.
Cleanup following cppcheck warnings:

[src/filemanager/layout.c:231]: (style) Clarify calculation precedence for '&' and '?'.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Sergei Trofimovich
5b594fffeb MidnightCommander/mc#97: src/filemanager/mountlist.c: add makedev() declaration.
On glibc-2.23 link fails as

    $ mc-9999/src/filemanager/mountlist.c:750: undefined reference to `makedev'

Reported-by: Thomas D.
Bug: https://bugs.gentoo.org/579858
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andrew Borodin
bc14ff44c8 Remove min() and max() macros. Use MIN() and MAX() macros from GLib.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andrew Borodin
3bea889648 (edit_replace_cmd): change type of 2nd argument from int to gboolean.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andrew Borodin
288c4490bf mcedit: fix type of function arguments:
(edit_move_{up,down}): fix 3rd argument: gboolean instead of int.
(edit_move_{up,down}_paragraph]): fix 2nd argument: gboolean instead of int.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andrew Borodin
0641e942e5 (input_is_empty): new WInput API.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andrew Borodin
4d65a731c2 mcview: refactoring of mcview_get_utf().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andrew Borodin
8cd8dbeb58 diffview: refactoring of dview_get_byte() and dview_get_utf().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andreas Mohr
eef076cef6 cppcheck: Cleanup Passing NULL after the last typed argument warning
Cleanup Passing NULL after the last typed argument warning.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andreas Mohr
72258dcca6 args.c: Make Solaris Studio happy
Make Solaris Studio 12.4 & 12.5 happy.

"args.c", line 180: warning: initialization type mismatch
"args.c", line 188: warning: initialization type mismatch

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andrew Borodin
874be2de1e mcedit: rename functions:
edit_buffer_move_forward -> edit_buffer_get_forward_offset
edit_buffer_move_backward -> edit_buffer_get_backward_offset

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andrew Borodin
2b8b1c56ea edit_buffer: clarify of buffer size update.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Andrew Borodin
954af9fec9 Ticket #3607: code cleanup bebore 4.8.17 release.
Clarify include of fileloc.h.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-07 16:19:02 +03:00
Yuri Khan
abb4996589 Ticket #3640: Subshell cursor position lost after window resizing.
Refactoring: rename functions:

do_enter_ca_mode -> tty_enter_ca_mode
do_exit_ca_mode -> tty_exit_ca_mode

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-05 10:01:13 +03:00
Yuri Khan
f278eaec99 Ticket #3639: fix window resizing when panels are hidden.
Calling tty_change_screen_size() causes a switch to the alternate screen:

   * Resizing the window causes a SIGWINCH sent to the mc process.
   * sigwinch_handler() sets the flag mc_global.tty.winch_flag to 1.
   * The select() call in feed_subshell() is interrupted.
   * feed_subshell() notices the winch_flag and calls tty_change_screen_size().
   * tty_change_screen_size() calls SLsmg_reinit_smg().
   * SLsmg_reinit_smg() sees that Smg_Mode is currently SMG_MODE_NONE
     (because it was set that way back in reset_smg() that was called
     when panels were hidden).
   * SLsmg_reinit_smg() calls SLsmg_init_smg().
   * SLsmg_init_smg() calls init_smg_for_mode(SMG_MODE_FULLSCREEN).
   * init_smg_for_mode() calls SLtt_init_video().
   * SLtt_init_video() sends the smcup terminfo sequence to the terminal.
   * SLtt_init_video() calls SLtt_init_keypad().
   * SLtt_init_keypad() sends the smkx terminfo sequence to the terminal
     and flushes the output buffer. (If $TERM starts with xterm or exactly
     matches screen, this function returns immediately without flushing the
     buffer, so the issue will not be visible.) The terminal switches to
     alternate screen and clears it.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-05-05 09:56:21 +03:00
Mooffie
a1d2c81d15 Ticket #3622: extfs/uzip: fix date parsing
By default, on Unix systems, unzip gets compiled with MDY date order. Debian
based distros compile it with YMD order, for which this patch adds support.

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-05-01 14:23:35 +02:00
Andreas Mohr
903773ceed Ticket #3610: remove executable bit from FISH helper scripts
Prevent them from getting accidentally run by users and fix rpmlint
warning found by OBS Framework (build.opensuse.org)

mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/append
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/chmod
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/chown
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/fexists
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/get
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/hardlink
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/info
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/ln
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/ls
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/mkdir
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/mv
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/rmdir
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/send
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/unlink
mc.x86_64: W: script-without-shebang /usr/lib/mc/fish/utime

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-04-30 18:02:25 +02:00
Andrew Borodin
cedcb28912 (copy_file_file): reduce variable scopes.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-25 13:15:12 +03:00
Andrew Borodin
f866d41746 (copy_file_file): get rid of one goto.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-25 13:15:12 +03:00
Andrew Borodin
abfadbb27f (copy_file_file): rename variables.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-25 13:15:12 +03:00
Andrew Borodin
18f6b85005 (copy_file_file): define copy buffer size in depend on destination file system block size.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-25 13:15:12 +03:00
Andrew Borodin
9523401374 (io_blksize): add intermediate variable.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-25 13:15:12 +03:00
Andrew Borodin
e7c01c7781 Ticket #2193: use Coreutils way to define buffer size to copy file.
m4.include/stat-size.m4, lib/stat-size.h: get these files from Gnulib.
src/filemanager/ioblksize.h: get this file from Coreutils.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-25 13:12:51 +03:00
Andreas Mohr
263012123c Ticket #3611: fix FISH ls helper (Perl)
In #3599 a Perl warning was introduced in fish_list_perl(), so
fish_list_perl() was skipped (return code 255) and fallback ls function
was used instead.

Additionally, all % chars must quoted because of g_strconcat() after
reading script file into a string.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
2016-04-21 21:37:35 +02:00
Andreas Mohr
d033e17a23 src/setup.c: cleanup -Wcast-qual warning.
Signed-off-by: Andreas Mohr <and@gmx.li>
2016-04-16 10:23:45 +03:00
Andreas Mohr
9a48fb4b0c src/clipboard.c: cleanup Wcast-qual warning.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-16 10:23:45 +03:00
Andreas Mohr
311ef4c669 src/viewer/search.c: cleanup some -Wcast-qual warning.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-16 10:23:45 +03:00
Andreas Mohr
f9f08fbfd7 src/vfs/extfs.c: cleanup -Wcast-qual warnings.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-16 10:23:45 +03:00
Andreas Mohr
0fae3ded3e src/filemanager/find.c: cleanup -Wcast-qual warning.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-16 10:23:45 +03:00
Andrew Borodin
8fd2fd69d7 src/filemanager/file.c: cleanup -Wcast-qual warning.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-16 10:23:45 +03:00
Andreas Mohr
e9730afef5 src/filemanager/file.c: cleanup -Wcast-qual warning.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-16 10:23:45 +03:00
Andreas Mohr
6005a63cad src/filemanager/panel.c: cleanup -Wcast-qual warning.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-16 10:23:45 +03:00
Andreas Mohr
3e7695619f src/editor/syntax.c: cleanup -Wcast-qual warnings.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-16 10:23:45 +03:00
Andreas Mohr
d640a34ada src/editor/editcmd.c: cleanup some -Wcast-qual warnings.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-16 10:23:45 +03:00
Andreas Mohr
edff1cff6f src/editor/choosesyntax.c: cleanup -Wcast-qual warning.
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-16 10:23:44 +03:00
Andreas Mohr
9cb22c41a6 src/diffviewer/ydiff.c: cleanup -Wcast-qual warning.
Signed-off-by: Andreas Mohr <and@gmx.li>
2016-04-16 10:23:44 +03:00
Andrew Borodin
0b46b4690f (dview_get_utf): apply const qualifier to str argument. 2016-04-16 10:23:44 +03:00
Andreas Mohr
16f229114a Ticket #3598: cleanup some -Wcast-qual compiler warnings.
Introduce CONST_WIDGET helper and use it.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-16 10:23:43 +03:00
Andrew Borodin
8490ca7be4 Drop old mouse API and use the new one.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-01 15:29:55 +03:00
Mooffie
781b810c13 Fix menu handling.
We now send mouse events to widgets in reverse Z-order, as done in common GUIs.
This makes it easy to implement "invisible" menubars correctly.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-01 15:29:55 +03:00
Andrew Borodin
c9a437a9c2 Optimize menu activation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-01 15:29:55 +03:00
Andrew Borodin
1adc6a53d1 mcedit: rename MCEDIT_DRAG_NORMAL to MCEDIT_DRAG_NONE.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-01 15:29:55 +03:00
Andrew Borodin
46963b3e71 mcedit: use the new mouse API.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2016-04-01 15:29:55 +03:00