How to reproduce:
1. Switch the "Drop down menus" option off.
2. Press F9 to activate menubar. Menu is not dropped.
3. Click somewhere below menubar, on one of the files in the directory
listing.
Buggy behavior: the corresponding "Left" or "File" etc. dropdown is
opened, and the mouse button is released, menu item under the mouse
cursor is activated.
Correct behavior: clicking with the mouse somewhere other than the
active menubar doesn't open dropdown menu, instead removes the focus from
menubar and acts on the actual item under the mouse pointer (such
as a filename in the panel).
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
* 2206_jump_line:
Add description of feature to man/help
Implementation of getting last editing/viewing position of file.
Add default options for most popular editors/viewers.
Add support of reading parameters for external editor/viewer from main config.
mc_config_get_string(): if default parameter is NULL, then no any config entities will be created
mc_config_get_string_raw(): if default parameter is NULL, then no any config entities will be created
Add lib/strutil/replace:str_replace_all() function.
Add src/execute.c:execute_external_editor_or_viewer() function.
Add function lib/utilunix.c:my_systemv_flags()
Code refactoring: split src/execute.c:execute_with_vfs_arg() function.
Add tests for src/execute.c:execute_with_vfs_arg() function.
Add new functions:
Code refactoring: my_system was split by few functions.
Add tests for lib/utilunix.c:my_system() function
Ticket #2206: Add jump support to target line in some external editors
for example, the config file may contain strings:
[External editor or viewer parameters]
vim = %filename +%lineno
mcedit = %filename:%lineno
And these external editors will open a file at the previously saved position.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
* 2626_escape_autocompletion:
mc_search__translate_replace_glob_to_regex(): Avoid warnings
Update EN and RU man pages.
Add tests for mc_search__translate_replace_glob_to_regex() function.
Ticket #2626: special chars are not escaped in autocompletion of filenames.
Test case:
1. Create a file with name that contains some special chars:
touch attachment.cgi?id=564208
2. Press F6.
3. Press a. Now only the 'a' letter is in input line.
4. Press Esc Tab Enter.
5a. Input line is filled by 'attachment.cgi?id=564208'...
5b. but 'attachment.cgi\?id=564208' is expected.
6. Add 'patch_' before file name:
'patch_attachment.cgi?id=564208'.
7. Press Enter.
8a. Result: 'patch_attachment.cgiattachment.cgi?id=564208id=564208'.
8b. Expected result: 'patch_attachment.cgi?id=564208'.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Steps to Reproduce:
1. Run mc in native console (not in X terminal emulator).
2. Press Ctrl+O to switch to subshell.
3. Try select anything with mouse.
Result: mouse does't select anything.
This bug was introduced in 68468a25ac
commit.
Solution: make mouse initialization after initializaton of subshell.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
* 2958_hotlist_buttons:
Fix buttons placement in file find result window.
Ticket #2958: buttons in the 'Directory hotlist' window are placed incorrectly.
A followup extension, "SGR 1006" was invented by xterm, to overcome some
of the shortcomings of the previous one. It is becoming as widespread as
the previous one, and is likely to soon overtake it in popularity.
Note that most of the patch is just the removal of the huge complexity
introduced by the previous one. The previous extension didn't have a
unique prefix which made the whole parsing logic extremely complicated.
The new extension does have a unique prefix, so parsing becomes a piece
of cake. The code becomes much cleaner and much easier to maintain.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
* 55_filename_complete:
lib/widget/input_complete.c: minor refactoring and optimization.
Fix for input completions with spaces in names.
lib/widget/input_complete.c: refactoring:
Concretize the usage of autocompliting in different input fields.
Extend QUICK_INPUT and QUICK_LABELED_INPUT macros for getting completion flags via parameters instead of using hardcoded value
Ticket #55: savannah: tab completion vs. spaces and escaping
* (filename_completion_function): use GString to ret rid of hand-made
low-level memory allocation.
* (variable_completion_function): likewise.
* (hostname_completion_function): likewise.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
# By Andrew Borodin (10) and Slava Zanko (1)
# Via Slava Zanko
* 2944_cleanup:
Avoid compiler errors like: error: variable 'xxx' set but not used [-Werror=unused-but-set-variable]
Clarify check of C compiler flags.
Enable -Wunused-but-set-variable flag by default.
Clarify usage of use_internal_edit variable
Merge src/filemanager/option.[ch] to src/filemanager/boxes.[ch].
Remove irrelevant comments about file_date() function.
Avoid C++-style comments.
(mc_global_t::shell): new member to store user's shell
(subshell_prompt): changed to GString.
(read_subshell_prompt): return gboolean instead of int.
Ticket #2944: code cleanup before 4.8.8 release.
