Commit Graph

12680 Commits

Author SHA1 Message Date
Andrew Borodin
4e6dc8cbc9 Ticket #3044: invalid order of filename and line number for external editor.
Most applications require the line number to precede the filename,
with apparently 'vim' and 'mcedit' being the only exceptions
(they accept both possible orders). E.g. 'emacs +10 /etc/services'
opens that file at line 10, but 'emacs /etc/services +10' simply
ignores the line number.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-29 14:03:53 +04:00
Andrew Borodin
4c3d5df63b (read_file_system_list): remove extra }.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 14:07:51 +04:00
Andrew Borodin
50b599a6a7 Merge branch '3051_cleanup'
* 3051_cleanup: (27 commits)
  Use AC_HEADER_MAJOR.
  Don't use g_memmove().
  Fix use of uninitialized memory in sigaction structure.
  Clarify usage of MSG_IDLE in mcedit.
  Fix search in internal viewer in case of nroff mode.
  Use g_list_free_full().
  Use g_slist_free_full().
  Fix directory content counting before file operation.
  (me_remote): don't use undefined _GL_UNUSED.
  (file_mask_dialog): don't call tilde_expand() because vfs_path_from_str() returns an absolute path.
  Fix reloading of the root directory.
  Reduce cppcheck warnings (style) in src subdirectory.
  Clarify usage of WPanel widget.
  Rename structures:
  Reduce cppcheck warnings (style) in lib subdirectory.
  cppcheck: reduce variable scope.
  Use UTF8_CHAR_LEN instead of a magic number
  (lcsubstr): fix memory deallocation.
  (panel_get_field_by_title): fix memory leak.
  (sftpfs_open_file): fix memory leak.
  ...
2013-11-25 13:49:02 +04:00
Andrew Borodin
14973bfe79 Use AC_HEADER_MAJOR.
Instead of checking for sys/mkdev.h headerfile, there is the
AC_HEADER_MAJOR helper for how to get major(), minor(), makedev().

Sinc with GLib efb1701bf3baf6f5b05fd1a7a5a4ff990a7dc460.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Andrew Borodin
77717b67bb Don't use g_memmove().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Andrew Borodin
bb65b46790 Fix use of uninitialized memory in sigaction structure.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Egmont Koblinger
255cc340b5 Clarify usage of MSG_IDLE in mcedit.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Andrew Borodin
377807c5de Fix search in internal viewer in case of nroff mode.
(mc_search__run_regex): fix conditions.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Andrew Borodin
29f6dd2a84 Use g_list_free_full().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Andrew Borodin
90dc6fffac Use g_slist_free_full().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Andrew Borodin
d0a082fbd5 Fix directory content counting before file operation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Andrew Borodin
dcfba47c8e (me_remote): don't use undefined _GL_UNUSED.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Andrew Borodin
1b774ac1fe (file_mask_dialog): don't call tilde_expand() because vfs_path_from_str() returns an absolute path.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Andrew Borodin
673d438938 Fix reloading of the root directory.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Slava Zanko
b136b2fa9f Reduce cppcheck warnings (style) in src subdirectory.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-25 13:47:40 +04:00
Andrew Borodin
9fcff743a7 Clarify usage of WPanel widget.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:40 +04:00
Slava Zanko
e351822191 Rename structures:
* FileOpContext -> file_op_context_t
* FileOpContextUI -> file_op_context_ui_t

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-25 13:47:40 +04:00
Slava Zanko
0ed4a91d7d Reduce cppcheck warnings (style) in lib subdirectory.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-25 13:47:39 +04:00
Slava Zanko
0d489acd58 cppcheck: reduce variable scope.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-25 13:47:39 +04:00
Slava Zanko
a3b8a2f005 Use UTF8_CHAR_LEN instead of a magic number
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-25 13:47:39 +04:00
Andrew Borodin
74d4efe871 (lcsubstr): fix memory deallocation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:39 +04:00
Andrew Borodin
e986039142 (panel_get_field_by_title): fix memory leak.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:39 +04:00
Andrew Borodin
917d463d28 (sftpfs_open_file): fix memory leak.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:39 +04:00
Andrew Borodin
6cbb11673c src/vfs/undelfs/undelfs.c: fix memory leaks.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-25 13:47:39 +04:00
Slava Zanko
3feb3f26d6 Improve developer's docs by adding info about new make targets:
cppcheck and indent.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-25 13:47:39 +04:00
Slava Zanko
bd69b8dd31 Suppress cppcheck errors
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-25 13:47:39 +04:00
Slava Zanko
41f9b60a15 Add indent rule in makefile
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-25 13:47:39 +04:00
Slava Zanko
c6e094f483 Added makefile's targets for run cppcheck
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-25 13:47:39 +04:00
tiandrey
b34e1d2988 From ticket #3057: Update for Syntax.in file
This patch fixes syntax highlighting for files in .config directory
(I was wondering why my rc.lua file in ~/.config/awesome is highlighted
as 'Java File' while in /etc/xdg/awesome it was highlighted correctly).

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-25 13:47:39 +04:00
Slava Zanko
49805a3e23 Ticket #3051: Prepare for release mc-4.8.11
From ticket #3044: mc.lib typo: linenog
mc.lib has a typo. "less=%filename +%linenog" instead of "+%lineno"

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-25 13:47:39 +04:00
Andrew Borodin
ab344e21b0 Merge branch '3096_save_setup_message'
* 3096_save_setup_message:
  Ticket #3096: clarify "Setup saved to ~/.config/mc/ini" message.
2013-11-23 14:58:38 +04:00
Andrew Borodin
ef90859a8f Ticket #3096: clarify "Setup saved to ~/.config/mc/ini" message.
The "Options -> Save setup" menu entry tells me "Setup saved to
~/.config/mc/ini".

This information is misleading, since this is not the only file
written, e.g. panels.ini is also updated.

Now this message contains the directory only:
"Setup saved to ~/.config/mc".

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-23 14:57:50 +04:00
Andrew Borodin
d501e20b9e Merge branch '3105_move_dir_crash'
* 3105_move_dir_crash:
  Ticket #3105: fix crash when moving directories on different file systems
2013-11-22 14:21:21 +04:00
Andrew Borodin
bae94b7acd Ticket #3105: fix crash when moving directories on different file systems
...in case "Verbose operation" option is off.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-22 14:20:42 +04:00
Slava Zanko
edf9a499d3 Merge branch '3101_gplib_fixes'
* 3101_gplib_fixes:
  Ticket #3101: F3 doesn't work on .so files in FreeBSD 9.x
2013-11-22 13:16:04 +03:00
Slava Zanko
0bc183c842 Ticket #3101: F3 doesn't work on .so files in FreeBSD 9.x
FreeBSD 9.x doesn't accept syntax for viewing lib) files
processed by /usr/local/libexec/mc/ext.d/misc.sh
revealing "/usr/local/libexec/mc/ext.d/misc.sh: 25: Syntax error: | unexpected".

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-22 13:15:53 +03:00
Slava Zanko
efa06663e2 Merge branch '3098_strip_home'
* 3098_strip_home:
  Ticket #3098: vfs_path_from_str_flags() doesn't support VPF_STRIP_HOME
2013-11-13 11:12:35 +03:00
Slava Zanko
a57d45d590 Ticket #3098: vfs_path_from_str_flags() doesn't support VPF_STRIP_HOME
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2013-11-08 16:57:42 +03:00
Andrew Borodin
91027154a2 Merge branch '3018_path_completion'
* 3018_path_completion:
  Ticket #3018: broken directory completion.
2013-11-07 21:24:24 +04:00
Andrew Borodin
09f1818bed Ticket #3018: broken directory completion.
In the command line, the subdirectory completion in current directory
isn't performed if stub isn't starting with './'.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-07 21:23:43 +04:00
Andrew Borodin
ed65223a23 Merge branch '3084_dlg_highlight_first_widget'
* 3084_dlg_highlight_first_widget:
  Ticket #3084: (dlg_init): fix order of messages sent to widgets during dialog initialization.
2013-11-07 16:00:08 +04:00
Andrew Borodin
c7b7a299e3 Ticket #3084: (dlg_init): fix order of messages sent to widgets during dialog initialization.
If checkbox is the first focusable widget in a dialog, it taken the MSG_DRAW
message after MSG_FOCUS one and therefore wasn't highlighted.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-07 15:59:26 +04:00
Andrew Borodin
83ea8e0f14 Merge branch '3076_num_history_items_recorded_0'
* 3076_num_history_items_recorded_0:
  Refactoring of WInput history.
  Remove WInput::field_width. Use Widget::cols instead.
  (input_update): don't do anything if widget is unowned or is in inactive dialog.
  Ticket #3076: copy/move doesn't work if num_history_items_recorded=0.
2013-11-07 15:54:24 +04:00
Andrew Borodin
5a61ac80d0 Refactoring of WInput history.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-07 15:53:53 +04:00
Andrew Borodin
de94164cb5 Remove WInput::field_width. Use Widget::cols instead.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-07 15:53:53 +04:00
Andrew Borodin
e16e33a186 (input_update): don't do anything if widget is unowned or is in inactive dialog.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-07 15:53:53 +04:00
Andrew Borodin
d8bb31c665 Ticket #3076: copy/move doesn't work if num_history_items_recorded=0.
How to reproduce:
1. Set num_history_items_recorded=0 in my $HOME/.config/mc/ini
2. Run mc.
3. Press F5 to copy and then enter.
Result: nothing happens.

Solution: refactoring of initial text usage in input line.
Use def_text to fill WInput:buffer when WInput is created.
Then overwrite WInput::buffer content from history if history usage
is enabled.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-07 15:53:53 +04:00
Andrew Borodin
f5f177e711 Fix indentation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-11-06 16:38:52 +04:00
Andrew Borodin
51769255b9 Merge branch '3050_bg_colors'
* 3050_bg_colors:
  Ticket #3050: don't use bright colors as background ones.
2013-11-06 16:12:14 +04:00
Andrew Borodin
e5e0a77bc9 Ticket #3050: don't use bright colors as background ones.
Only following colors can be used in 16-color skins:
black, red, green, brown, blue, magenta, cyan, lightgray.

Following colors are replaced in 16-color skins:

white -> lightgray
yellow -> brown
brightgreen -> green

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2013-10-17 09:28:19 +04:00