Commit Graph

83 Commits

Author SHA1 Message Date
Roland Illig
2f059780af * find.c: Applied patch to make the find dialog more responsive
while scanning through large files.

	From Jindrich Makovicka <makovick kmlinux.fjfi.cvut.cz>
2004-09-19 11:32:30 +00:00
Andrew V. Samoilov
2253379eb8 * subshell.c (exit_subshell): Prevent unwanted reuse of freed
pty_buffer.
        * complete.c (variable_completion_function): strncpy()->memcpy()
        changes are because we know there is no '\0' among the first
        length bytes.
        (insert_text): Likewise.
        (command_completion_function): Avoid memory leaks.
        (filename_completion_function): g_free handles NULL argument too,
        no need for the comparison.
        (try_complete): Likewise.
        (command_completion_function): Likewise.
        (free_completions): Likewise.
        * widget.c (gauge_callback): Fix for 64-bit arches (%*s len must
        be int, %3d takes int.
        (copy_region): g_free handles NULL argument too, no need for
        the comparison.
        (kill_line): Likewise.
        * find.c (do_search): Likewise.
        (init_find_vars): Likewise.
        (do_find): Likewise.
2004-09-03 22:00:27 +00:00
Roland Illig
5697bd2a92 * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 22:51:02 +00:00
Roland Illig
5c74367969 Added more const-ness to variables. 2004-08-16 23:48:46 +00:00
Pavel Roskin
fce80af570 * widget.[ch] (listbox_search_text): Constify "text" argument.
(listbox_add_item): Ditto.

* find.c (add_to_list): Make inline.
(stop_idle): Ditto.
(status_update): Ditto.
(get_list_info): Ditto.

(push_directory): Constify "dir" argument and use
concat_dir_and_file() instead of g_strdup().

(find_add_match): Constify "dir" and "file" arguments.
(insert_file): Ditto. Don't append trailing PATH_SEP, it's done
in push_directory().

(search_content): Constify "directory" and "filename" arguments.
(do_search): Make "directory" char * instead of char[].
2003-10-30 16:43:22 +00:00
Pavel Roskin
24384e9a89 * panel.h: Fix duplication between cpanel and current_panel in
favor of current_panel.  Ditto opanel and other_panel.
2003-10-26 06:45:59 +00:00
Pavel Roskin
98950838b4 * dlg.h: Merge with ...
* dialog.h: ... this.  Adjust all dependencies.
* dlg.c: Merge with ...
* dialog.c: ... this.
* Makefile.am (SRCS): Remove dlg.h and dlg.c.
2003-10-24 23:20:30 +00:00
Pavel Roskin
5995204d0e * dir.h: Eliminate DIR_H_INCLUDE_HANDLE_DIRENT. Adjust all
callers.  Remove unused code.
* dlg.h: Remove unused code.
* panel.h: Likewise.
2003-10-24 17:55:35 +00:00
Pavel Roskin
f219b81311 * vfsdummy.h: New file to replace vfs.h if VFS is disabled.
* Makefile.am: Add vfsdummy.h.
* global.h [!USE_VFS]: Include vfsdummy.h.  Fix files that
include vfs.h directly.
2003-10-11 08:54:31 +00:00
Pavel Roskin
3ba2ed6891 * find.c (do_search): Use strncpy() instead if unsafe strcpy().
Check mc_(l)stat() return values.
2003-09-29 15:58:08 +00:00
Pavel Roskin
8729c81ddc * find.c (find_file): Don't call file_mark(), it would use
uninitialized data.
* main.c (panel_clean_dir): Make panel dirty.
2003-09-22 22:05:27 +00:00
Pavel Roskin
e14f56d71b * dlg.h: Replace DLG_BACKWARD to DLG_REVERSE with a better
defined meaning.  Make it default to populate dialogs from the
top.  Change all calls to create_dlg().
2003-09-12 21:22:01 +00:00
Pavel Roskin
0c794a4e95 Fix unsafe defines. 2003-09-10 21:33:12 +00:00
Pavel Roskin
33078ab195 * find.c: Remove useless calls to paint_panel().
* panelize.c: Likewise.
2003-09-10 05:38:38 +00:00
Pavel Roskin
649f1c538e * find.c (find_parameters): Make "filename" entry focused on
startup - it's used more often than "start at".
2003-09-10 00:29:09 +00:00
Pavel Roskin
13a02ef978 * dlg.h: Use new types for dialog callbacks.
(dlg_cb_fn): Swap msg and parm arguments for consistency with
widget callbacks.  Adjust all dependencies.
2003-09-07 21:24:01 +00:00
Pavel Roskin
f8e00e7b6a * widget.c (listbox_new): Remove "action" argument. Listboxes
without callbacks default to closing the dialog.  Adjust all
users.  This fixes double click on completion listbox.
* widget.h: Use uppercase names for the return values of the
listbox callback.
2003-09-01 07:31:56 +00:00
Pavel Roskin
2b9b18150e * widget.h (button_new): Remove unused extra argument. Adjust
all dependencies.
2003-09-01 02:07:02 +00:00
Pavel Roskin
fab6e8a493 * widget.h: Completely get rid of tkname. Rename it to histname
for the input widget.  Adjust all dependencies.
2003-09-01 00:18:37 +00:00
Pavel Roskin
10f65ac83d * dlg.h (struct Widget): Remove tkname field.
(init_widget): Remove tkname argument.
* widget.h (listbox_new): Likewise.
Adjust all dependencies.
2003-08-31 23:29:49 +00:00
Pavel Roskin
4dd13a09ba * dir.h (file_entry): Rename "buf" to "st". Adjust all
dependencies.
2003-08-18 00:47:43 +00:00
Pavel Roskin
0900e8faee * find.c (get_line_at): Strip trailing newline to fix $
matching.
2003-04-16 15:26:29 +00:00
Pavel Roskin
eb781a8f06 * dlg.h: Add new event DLG_VALIDATE.
* dlg.c (frontend_run_dlg): Send DLG_VALIDATE.
(select_a_widget): Don't send DLG_ONE_DOWN, nobody uses it.
* find.c (find_parm_callback): New callback for the parameter
dialog.  Don't allow stopping the dialog if the regular
expression is invalid.
2002-12-24 11:28:26 +00:00
Pavel Roskin
42fcf6c927 * find.c (find_file): Skip entries without data when panelizing.
Found by Valgrind.
2002-12-11 07:14:00 +00:00
Pavel Roskin
66f451aac7 * dlg.c (send_message_to): Remove, use send_message() instead.
(send_message): Make inline, remove Dlg_head argument.  Change
all callers.
2002-11-13 02:56:40 +00:00
Pavel Roskin
a84b0fc9cd Fix some of the most ugly abuses of mixed caps in English texts,
especially in button captions.
2002-10-21 22:26:39 +00:00
Pavel Roskin
c011f62dea * color.c: Rename stalledlink to stalelink. Make the same
change elsewhere.
2002-10-13 22:23:17 +00:00
Pavel Roskin
c785d4195b * global.h: Move fcntl.h inclusion here. Define O_BINARY.
* mountlist.c: Remove more includes already handled in global.h.
2002-09-23 06:43:22 +00:00
Pavel Roskin
97148e3e55 Reuse the same title "Find File". Reformat most ugly code. 2002-09-03 20:04:54 +00:00
Pavel Roskin
6c2eb32b70 * dlg.c (x_set_dialog_title): Completely eliminate. Adjust all
dependencies.
2002-09-03 07:42:36 +00:00
Pavel Roskin
e000c69683 * wtools.c (common_dialog_callback): Fold into ...
* dlg.c (default_dlg_callback): ... this.  Don't redraw dialogs
that don't have colors.  Adjust all dependencies.
(std_callback): Elimitate.
2002-09-02 16:31:33 +00:00
Pavel Roskin
9e36fa257d * global.h: Move include for rx.h and eregex.h here. 2002-08-21 07:20:39 +00:00
Pavel Roskin
047a7f906e * dlg.h: Remove all unused flags for create_dlg(). Adjust all
dependencies.
2002-08-19 06:22:32 +00:00
Pavel Roskin
7ca687c8ed * eregex.h: Update from glibc-2.2.5.
* regex.c: Likewise.
* find.c: Use eregex.h, not regex.h.
* util.c: Likewise.
* view.c: Likewise.
From Alexander Varakin <avarakin00@hotmail.com>
2002-03-18 21:08:18 +00:00
Pavel Roskin
ebe22f53db * find.c (find_parameters): Invert condition when find is case
sensitive.
2002-03-18 20:04:13 +00:00
Andrew V. Samoilov
3de820819f * find.c (find_parameters): Compile content_pattern here.
Inform user about alformed regular expression.
(search_content): Use compiled regular expression.
(do_find): Eliminate `done'.  Call regfree for compiled
content_pattern.
2002-02-28 13:50:03 +00:00
Pavel Roskin
86213a2be0 * find.c (do_find): Re-sort the panel according to the current
settings when doing panelizing.
2001-11-14 19:59:31 +00:00
Pavel Roskin
3ab6f77fee * boxes.c (tree): Rename to tree_box() to avoid confusion.
Adjust all callers and headers.
* main.c (tree_box): Rename to tree_box_cmd().
2001-10-01 06:51:15 +00:00
Pavel Roskin
2168f2fc50 * find.c: Include rx.h or regex.h
(get_line_at): New function.  Returns malloc()ed null-terminated
line from file file_fd.  Input is buffered in buf_size long
buffer.
(search_content): Don't use external egrep.
Use get_line_at and regexp.
2001-09-23 04:06:35 +00:00
Pavel Roskin
c11389facb * global.h: Include io.h, pwd.h, grp.h and utime.h. Adjust all
sources not to include them and to include global.h at the right
place.
2001-09-07 17:52:19 +00:00
Pavel Roskin
a8ef641beb * x.h: Remove. Adjust all users. Make sure that global.h is
included instead.  Don't include sys/param.h unconditionally -
rely on global.h taking care of it.
* Makefile.in: Remove x.h.
2001-09-03 05:07:40 +00:00
Andrew V. Samoilov
d83a8e7b5e * find.c (find_parameters): Fix hotkeys duplication. 2001-07-31 12:18:07 +00:00
Pavel Roskin
e280cb5c8b * find.c: Remove code unused in the text edition. 2001-07-14 21:44:39 +00:00
Pavel Roskin
7205d0210c * background.c: Include "x.h".
* panelize.c: Likewise.
* treestore.c: Likewise.
* user.c: Likewise.
* util.c: Likewise.
* command.c: Reorder includes. Include "x.h".
* complete.c: Likewise.
* find.c: Likewise.
* user.h: Declare user_menu_cmd() inconditionally.
* i18n.h [GAVE_GNOME]: Remove code that is now in x.h.
2001-06-15 23:37:59 +00:00
Pavel Roskin
8c1534e4e6 * cons.handler.c (handle_console): Remove useless default.
* ext.c (regex_command): Initialize include_target_len.
* find.c [HAVE_GNOME]: Eliminate untyped declarations.
* fsusage.c: Remove untyped declaration of statfs().
[_AIX && _I386]: Rename statfs to aix_statfs and move
it before get_fs_usage(). Define statfs to aix_statfs.
2001-06-14 23:28:54 +00:00
Pavel Roskin
1bb43b9c1a * boxes.c [HAVE_GNOME]: Disable unused code.
* find.c [HAVE_GNOME]: Likewise.
2001-05-14 21:57:10 +00:00
Andrew V. Samoilov
ea0cfde3c9 * find.c (search_content): Redo recent change without infinite loop ;-),
egrep_path hardcoded to "egrep" as it is done in locate_egrep ()

(locate_egrep): commented out

(rotating_dash) [!HAVE_X]: moved into do_search to prevent warning
2001-04-27 10:07:45 +00:00
Pavel Roskin
c267347457 * find.c (search_content): Undo a recent change that caused an
infinite loop.
2001-04-26 23:59:59 +00:00
Andrew V. Samoilov
42dd6b0b90 * view.c (get_line_at): previous newline is right condition
for regexp '^' pattern also, fixed

(search) [HAVE_GNOME]: gnome_message_box_new don't expand printf
pattern, so g_strdup_printf used

* find.c (find_parameters): don't use stat structure if mc_stat failed
2001-04-24 14:39:38 +00:00
Pavel Roskin
bb912def1a * gtkedit/editcmd.c: Remove support for XView layout attributes.
* gtkedit/editoptions.c: Likewise.
* pc/chmod.c: Likewise.
* pc/drive.c: Likewise.
* src/boxes.c: Likewise.
* src/chmod.c: Likewise.
* src/dlg.c: Likewise.
* src/dlg.h: Likewise.
* src/filegui.c: Likewise.
* src/find.c: Likewise.
* src/hotlist.c: Likewise.
* src/layout.c: Likewise.
* src/listmode.c: Likewise.
* src/main.c: Likewise.
* src/option.c: Likewise.
* src/panelize.c: Likewise.
* src/wtools.c: Likewise.
* src/wtools.h: Likewise.
* vfs/smbfs.c: Likewise.
2001-04-06 21:48:11 +00:00