Commit Graph

346 Commits

Author SHA1 Message Date
Andrew Borodin 5b68413e62 Applied MC indentation policy.
Applied MC indentation policy to all files modified in this branch
with some simple manual modifications.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:22 +04:00
Vit Rosin 07a7f446b0 Ticket #2108: Fixed memory leak in fish_linear_start() function.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:22 +04:00
Slava Zanko 2dc590fe62 lib/util.c: Fixed memleak in load_mc_home_file() function
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-03-30 16:21:22 +04:00
Andrew Borodin e94c1393e6 Fixed memory leak in mc_search__cond_struct_new_regex_accum_append().
Minor optimization.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:22 +04:00
Andrew Borodin 3c88948c9d Fixed memory leak in mc_closedir().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:21 +04:00
Andrew Borodin f547d149ba Fixed memory leak in vfs_free_handle().
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:21 +04:00
Andrew Borodin 407d1f38f5 Fixed memory leak in vfs_s_getlocalcopy().
Thanks Vit Rosin for the original patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:21 +04:00
Vit Rosin c6a5837f6d Ticket #2069: fixed memory leaks.
Fixed memory leak in mc_config_read_file().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-30 16:21:21 +04:00
Andrew Borodin 68d7a77210 Fixed of GSList item deallocation.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-05 17:29:28 +03:00
Andrew Borodin 34d74f09b1 Ticket #1909: don't interpret trailing '+' as a plugin name.
If EXTFS plugin doesn't require a file, that file name must
be finished with '+': for example, rpms+. But trailing '+'
actually is not a part of plugin name, it is an plugin attrubute.
But in the current time trailing '+' must be used in VFS command:

cd #rpms+

instead of

cd #rpms

This commit simplifies the usage of some EXTFS plugins.

Also fixed VFS README.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-03-05 17:29:28 +03:00
Slava Zanko 7206d2cc6c Fixed wrong colors
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-26 14:22:31 +02:00
Slava Zanko 5354d59337 Identation of some source files.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-26 11:26:00 +02:00
Slava Zanko cd8b350b6d UNDELFS: code cleanup
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-26 10:58:49 +02:00
Slava Zanko bff2f7303b Cleanup: avoid warnings for mc-library on x86_64
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-26 10:58:49 +02:00
Slava Zanko 1b75ea27b6 Cleanup of code for master
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-26 10:58:49 +02:00
Andrew Borodin 2cf080d18f Ticket #2058: fixed memory leaks in _vfs_get_cwd() function.
Thanks Vit Rosin to found memory leak in _vfs_memleak() function.
This function was rewritten to fix two memory leaks.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 21:44:07 +03:00
Andrew Borodin a78115ad8e Fixed variable declarations and added missing includes.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 16:22:43 +00:00
Andrew Borodin 9b36242128 Ticket #1972: fixed broken monochrom support in NCurses-based MC.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 13:54:32 +00:00
Vit Rosin 3770047407 Ticket #2053: fixed memory leak in mc_symlink() function.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 12:08:01 +00:00
Slava Zanko e1d1e9254d Change progressbar dialog.
* Minimizing dialog;
 * Optimizations of Copy/move progress dialog creation;
 * Added enum for specify dialog type (for copy/move or for delete)
 * Little optimization.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
2010-02-24 10:40:11 +02:00
Slava Zanko 804ca8e7b0 Added indication of total BPS and ETA for file operations.
* Optimized functions calls (changed return type of all file_progress_show*() functions)
 * Reworked for use global structure FileOpTotalContext
 * Moved declarations of file_progress_show*() functions from fileopctx.h to filegui.h
 * Code for calculate progressbar's variables was moved into function copy_file_file_display_progress()
 * Progressbar for little files now shows always 100% (for visible effect)
 * Added i18n string '< 1 sec'
 * Rework of progress copy dialog

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 10:37:43 +02:00
Andrew Borodin 159f5fdff1 Type accuracy in file operation routines.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-24 10:37:42 +02:00
Andrew Borodin 492ccbe0ee Ticket #1999: changed color of inactive visible main menu.
Added 'menuinactive' skin item to draw incative visible
main menu.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-23 19:01:56 +03:00
Andrew Borodin 4451e07fab Ticket #2028: fixed memory leak in mc_search__hex_translate_to_regex() function.
Thanks Vit Rosin for the original patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-23 14:35:43 +03:00
Slava Zanko 47cdfd6baf Use system function strverscmp() if exists.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-22 11:08:37 +02:00
Vladimir Brednikov 3c4221bc40 Ticket #1994: Sort files by version (like strverscmp(3) does)
Suppose we have 3 files with version in their names:
 * file-2.1.tgz
 * file-2.2.tgz
 * file-2.10.tgz

It is impossible to see them in natural order using standard facilities,
they will be sorted in alphabet order:
 * file-2.1.tgz
 * file-2.10.tgz
 * file-2.2.tgz

There was some attempts to fix this. I've picked up the patch by Roland Illig <roland illig gmx de>
(http://mail.gnome.org/archives/mc-devel/2004-July/msg00016.html) and adopted it for today's git snapshot.
It adds "version" option to the sort menu, which uses copy of strverscmp function from glibc.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-22 11:08:37 +02:00
Andrew Borodin 68ecccb453 Ticket #2018: strcpy() is used for overlaping strings.
memmove() is used for overlaping strings instead of strcpy().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-18 13:21:25 +00:00
Andrew Borodin d5d1589665 Replaced hardcoded '/' symbols.
Symbolic names and GLib functions are used instead of
hardcoded '/' symbols.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-15 16:10:02 +00:00
Andrew Borodin b7d5a5852c 2-level extfs plugin structure.
extfs vfs plugins are read from following places:
1. ~/.mc/extfs.d directory.
2. /usr/libexec/mc/extfs.d direcotry.

Priority of plugins installed in user home directory
is highest. If there are two plugins with same names
exist in user home and system directories, the plugin
from user home is used.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-15 16:10:02 +00:00
Andrew Borodin ba1d909a7a extfs.ini file is replaced to extfs.d directory.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-15 16:10:02 +00:00
Andrew Borodin 2d43ad1bb4 Reimplemented work with plugin info.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-15 16:10:02 +00:00
Andrew Borodin 6e1c61da0e Optimization of symbolic link loop protection.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-15 16:10:02 +00:00
Andrew Borodin 5b96caa5f0 Optimization of extfs_get_path_from_entry() function.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-15 16:10:02 +00:00
Andrew Borodin ad9c1daad8 Ticket #1909: easy plugable EXTFS VFS.
Reimplemented EXTFS VFS to be friendly to package-based
systems. Currently, MC requires to edit extfs.ini file
to add new plugin to MC VFS. After upgrade, all changes
to this files will be lost.

To solve that problem, MC configuration system should
support ".d" pattern.

Initial step: refactoring of current extfs code:
cleanup, type accuracy, indentation.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-15 16:10:02 +00:00
Serhiy Storchaka d45554ffad urar.in: fixed work with filenames begining with spaces.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-15 13:39:30 +02:00
Serhiy Storchaka 786e6f548e Ticket #2029: Error in supporting rar-archives
Contents of rar-archives with filenames contained / \d\d:\d\d / are not listed correctly.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-15 13:06:42 +02:00
Martin Petricek 7c3196b60e Ticket #1767: Custom/locale-based date format
Fixed showing of datetime format in various locales (such as Polish locale)

Added new options in config file:

[Misc]
    ...
    timeformat_recent=%d.%m.%y %H:%M
    timeformat_old=%d.%m.%y %H:%M
    ...

where
    timeformat_recent - for files with mtime between now
                         and "6 moths old" (like "Nov 2 00:56")
    timeformat_old    - for other files (like "Jun 23 2007")

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-15 12:31:47 +02:00
Max Khon 35e211123b Ticket #1017: added missing #include.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-11 12:23:59 +00:00
Andrew Borodin 56bf77ae57 Ticket #1926: Ctrl-\ key behaviour in NCurses-based MC.
Generally, Ctrl-\ is a default assignment to SIGQUIT signal.
S-Lang breaks this assignment. NCurses doesn't, therefore
MC just quits when user presses the Ctrl-\ key.

This commit emulates the S-Lang way in NCurses-based MC.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-06 13:21:25 +03:00
Slava Zanko 7ea4dfb4ca Ticket #1902: (reopened defect) Possible security risk in mcserv.c
Comment by Oswald Buddenhagen:
first, you decided to ignore my advice about not
obfuscating the code with nonsense-checks, and on top of that you
broke the string comparison (just see what happens when you try a user
named "ftpmaster").

This commit contain changes for respect this critic.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-05 17:36:19 +02:00
Andrew Borodin 1d16fd3a88 Small refactoring of history engine.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-04 13:42:44 +00:00
Pavel Vasilyev b3ea5f8ceb Ticket #1902: Possible security risk in mcserv.c
Look at mcserv.c near 1019
The chroot() call's return value isn't handled - this may a security risk.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-04 11:12:56 +02:00
Serhiy Storchaka 6191ca0b1f Ticket #1921: Fix lslR VFS
The lslR VFS does not work with ls-lR files created in en_US.UTF-8 locale and with files and directories started with whitespaces.
Followed patch fixes both issues.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-02 22:25:54 +02:00
Slava Zanko 8d1eebc30e lib/mcconfig/common.c: fixed memory leak
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-02 21:56:01 +03:00
Andrew Borodin 6354f6b265 Fixed unused variables.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-02 21:45:21 +03:00
Andrew Borodin 7f50de4670 Added missed includes.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2010-02-02 21:45:11 +03:00
Andrew Borodin 0bd03e07f5 Ticket #1990: code cleanup before 4.7.0.2 release.
Fixed warings: local variable shadows a global declaration.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
2010-02-02 21:45:05 +03:00
Slava Zanko f7c574b76e lib/Makefile.am: added lib/skin.h into distribution
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-02 18:01:18 +02:00
Vladimir Prodan 2d025b7ede Make b&w colors work as before
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-01 12:25:46 +02:00
Slava Zanko f4c23b7081 Ticket #1972: Selections not visible on monochrome terminals
Reported-By: Dr. Stefan Thurner (TU-Chemnitz)

Since 4.7, on monochrome terminals (eg. xterm-mono) the
selections are not visible anymore (pre 4.7 inverted
the selected text).

Probably this has to do w/ the new skinning stuff.

Fix issue: added additional check for b&w terminal into skins engine.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2010-02-01 12:25:46 +02:00