Commit Graph

6354 Commits

Author SHA1 Message Date
Roland Illig
b5ef1bd79a * HACKING: Added a section "Programming Tips" which lists mistakes
that have been done once and should never be repeated.
2004-09-02 14:48:21 +00:00
Andrew V. Samoilov
d99d02c743 * mcfs.c (mcfs_readlink): Revert last change: readlink does not
append a NUL character to buf. Fix compilation.
2004-09-02 14:34:58 +00:00
Roland Illig
f30fc0163b * man2hlp.c (handle_link): Added header "glib-compat.h" because
glib-1.2 does not know g_strlcpy.
2004-09-02 14:32:53 +00:00
Andrew V. Samoilov
fc3bf048e9 * local.c (local_readlink): Make "size" size_t.
* direntry.c (vfs_s_readlink): Revert last changes. Make "size"
        size_t.
        * sfs.c (sfs_readlink): Reformat function.
        * smbfs.c (smbfs_readlink): Reformat function.
2004-09-02 14:12:21 +00:00
Andrew V. Samoilov
e04694309c * tar.c (tar_read_header): Fix missed *.
* extfs.c (extfs_readlink): Revert last change: readlink does not
        append a NUL character to buf.
        * ftpfs.c: Warning fix.
        * vfs-impl.h (struct vfs_class.readlink): Make "size" size_t.
        Adjust all callers.
2004-09-02 13:57:59 +00:00
Roland Illig
c44a4a4c31 * mcfs.c (mcfs_readlink): Fixed syntax error (usage of
undeclared variable). Simplified string copying.
2004-09-02 13:26:28 +00:00
Roland Illig
68fa8e1cd8 * color.c (try_alloc_color_pair (ncurses)): Added const qualifier
to the arguments.
2004-09-02 12:51:09 +00:00
Roland Illig
38257a486a * man2hlp.c (handle_link): Reverted the last change because
glib-1.2 does not know g_strlcpy.
2004-09-02 12:30:28 +00:00
Andrew V. Samoilov
64b5b8b9ee uzip.in (mczipfs_list): Add support for negative
compression ratio in archive listing.
2004-09-02 00:16:33 +00:00
Andrew V. Samoilov
ce4e912cbf * extfs/uzip.in (mczipfs_list): Add support for negative
compression ratio in archive listing.
2004-09-02 00:15:59 +00:00
Andrew V. Samoilov
81ce34aa3f Done: Need a separate color for hotkeys in red dialogs. 2004-09-02 00:10:25 +00:00
Andrew V. Samoilov
15c6e5cae6 * direntry.c (vfs_s_readlink): Use g_strlcpy instead strncpy.
* ftpfs.c (ftpfs_get_reply): Use g_strlcpy instead strncpy.
* extfs.c (extfs_readlink): Fix return value. Use g_strlcpy
        instead strncpy.
* mcfs.c (mcfs_readlink): Fix return value. Use g_strlcpy
        instead strncpy.
* tar.c (tar_read_header): Add additional check for consistency.
        Fix memory leak.
* cpio.c (cpio_defer_find): Remove recursion.
        (cpio_free_archive): Fix memory leak.
        (cpio_read_bin_head): Use union for simplicity using of header
        structure. Add additional check for consistency.
        (cpio_read_oldc_head): Add additional check for consistency.
2004-09-02 00:09:02 +00:00
Andrew V. Samoilov
1b80f9ceac * complete.c (completion_matches): Use more suitable function
g_strndup(), instead sequence g_malloc(), strncpy(),
        name[len] = '\0'
* widget.c (copy_region): Likewise. (delete_region): Use
        memmove() instead strcpy().
* user.c (debug_out): Eliminate buffer array.
2004-09-01 23:25:21 +00:00
Andrew V. Samoilov
f379b30232 * editcmd.c (edit_save_as_cmd): Add hotkey to dialog.
(edit_save_confirm_cmd): Likewise. (edit_new_cmd): Likewise.
(edit_load_cmd): Likewise. (edit_block_move_cmd): Likewise.
(edit_block_delete): Likewise. (edit_ok_to_exit): Likewise.
2004-09-01 22:40:45 +00:00
Andrew V. Samoilov
f27d0e157f * color.c (load_dialog_colors): Make a separate color for
hotkeys in red dialogs.
* color.h: Likewise.
* view.c (view_ok_to_quit): Add hotkey to dialog.
2004-09-01 22:33:43 +00:00
Andrew V. Samoilov
71ffc327b5 * fish.c (fish_get_reply): Use g_strlcpy instead
sequence strncpy(), name[len] = '\0'
* vfs.c (mc_get_current_wd): Likewise.
2004-09-01 18:39:48 +00:00
Andrew V. Samoilov
83de09639c * syntax.c(this_try_alloc_color_pair): Use g_strlcpy instead
sequence strncpy(), name[len] = '\0'
(edit_read_syntax_rules):Likewise.
2004-09-01 18:37:14 +00:00
Andrew V. Samoilov
de59cf86c4 * user.c (check_format_var): Use more suitable function
g_strndup, instead sequence g_malloc(), strncpy(), name[len] = '\0'
* man2hlp.c (handle_link): Use g_strlcpy instead sequence
        strncpy(), name[len] = '\0'
* profile.c (GetSetProfile): Likewise.
* wtools.c (fg_input_dialog_help): Likewise.
2004-09-01 18:31:24 +00:00
Andrew V. Samoilov
03ddc6c8e9 * wtools.h: Fix warnings.
* selcodepage.c (select_charset): Likewise.
        * boxes.c (display_bits_box): Likewise.
2004-09-01 17:46:53 +00:00
Andrew V. Samoilov
facaac9889 * color.c (mc_init_pair): Use cast to avoid warning.
* screen.c (display_mini_info): Likewise.
* slint.c (do_define_key): Likewise.
* tree.c (tree_show_mini_info): Likewise. (show_tree):Likewise.
* view.c (view_status): Likewise.
2004-08-31 23:34:18 +00:00
Andrew V. Samoilov
784158a520 E-mail fixes 2004-08-31 14:16:16 +00:00
Andrew V. Samoilov
b93c90db4e * include/slang.h: Revert last changes - it breaks compiling
* sldisply.c: Likewise.
* slerr.c: Likewise.
* slsmg.c: Likewise.
* sltermin.c: Likewise.
2004-08-31 06:44:20 +00:00
Andrew V. Samoilov
0bc44d553c * extfs.c (struct inode): Use off_t for size. 2004-08-30 18:38:21 +00:00
Andrew V. Samoilov
562577c0d4 Use atoll()/atof() instead of atol() for st_size to show file sizes > 2G. 2004-08-30 18:36:58 +00:00
Andrew V. Samoilov
d16aa745e8 * utilvfs.c (vfs_parse_ls_lga): Use atoll()/atof() instead of atol()
for st_size to show file sizes > 2G.
* fish.c (fish_dir_load): Likewise.
* extfs.c (struct inode): Use off_t for size.
2004-08-30 18:36:22 +00:00
Roland Illig
bdd4ab2ae5 * m4/ri-gcc-warnings.m4: Now handles only the last --enable or
--disable option. Before, --disable has not been handled
	correctly.
2004-08-30 11:24:11 +00:00
Roland Illig
73207a8994 * slang.h: Added const qualifier to some of the SLang functions. 2004-08-30 11:12:57 +00:00
Roland Illig
be94f06cc2 * ri-gcc-warnings.m4: Fixed handling of more than one --enable option. 2004-08-30 10:46:07 +00:00
Roland Illig
2ed35b596c * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional
	changes. Patch contributed by Andrew V Samoilov.
2004-08-30 10:38:00 +00:00
Roland Illig
3da9abba54 * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-30 00:02:36 +00:00
Roland Illig
7bff9337c0 * Code cleanup: Added const qualifier for variables and
function declarations where possible. Additionally wrapped
	the calls to putenv() by g_strdup().
2004-08-29 23:59:17 +00:00
Roland Illig
3f3c24f511 * view.c (move_backward2): Removed unused variables. 2004-08-29 23:56:53 +00:00
Roland Illig
1d573d9059 * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 23:54:47 +00:00
Roland Illig
3957415603 * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 23:39:38 +00:00
Roland Illig
03913065b4 * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 23:27:40 +00:00
Roland Illig
17714fd8d9 * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 23:20:01 +00:00
Roland Illig
4c1ea14493 * Code cleanup: Added const qualifier for variables and
function declarations where possible. Now using two temp
	variables: one for strings that need not be freed (temp) and
	one for strings that need to (temp2).
2004-08-29 22:55:57 +00:00
Roland Illig
5697bd2a92 * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 22:51:02 +00:00
Roland Illig
d6d457ba9a * dialog.c: made the callback parameter of find_widget_type correctly typed. 2004-08-29 22:44:17 +00:00
Roland Illig
b75c5a31a3 * dialog.h: marked the title as "notconst", as it is freed
by the destructor.
2004-08-29 22:43:27 +00:00
Roland Illig
5c4add0e6e * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 22:38:06 +00:00
Roland Illig
b86b6a7bc7 * background.c (do_background): Fixed file descriptor leak. 2004-08-29 18:57:31 +00:00
Roland Illig
243e84706e * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 18:45:56 +00:00
Roland Illig
263ea5c1d5 * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 17:57:39 +00:00
Roland Illig
65ffa864b8 * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 17:24:12 +00:00
Roland Illig
4baefa09c2 * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 17:15:23 +00:00
Roland Illig
8458240147 * Code cleanup: Added const qualifier for variables and
function declarations where possible. No functional changes.
2004-08-29 16:42:40 +00:00
Andrew V. Samoilov
3c4b2f8ff4 Fixed changelog entry - use parenthesis for explicit function name 2004-08-26 19:56:14 +00:00
Andrew V. Samoilov
81e4bdfe72 smbfs.c (smbfs_open_readwrite): Implement O_APPEND via smbfs_lseek(). 2004-08-26 19:51:38 +00:00
Andrew V. Samoilov
7680fd6884 * extfs/rpm: Modified workaround for spaces and single quotes
in the path name. For mcrpmfs_copyout too.
2004-08-26 18:59:26 +00:00