mirrors/mc
1
0
Fork 0
mirror of https://github.com/MidnightCommander/mc synced 2025-01-22 03:02:06 +03:00
Code Issues Packages Projects Releases Wiki Activity
15,579 Commits 48 Branches 84 Tags 97 MiB
25a445ed88
Commit Graph

119 Commits

Author SHA1 Message Date
Andrew Borodin
49624e473b Ticket #4450: support PCRE2 in the search engine. 
* m4.include/ax_path_lib_pcre.m4: replace by recent version from GNU
Autoconf Archive.
  * m4.include/ax_check_pcre2.m4: get grom GNU Autoconf Archive.
  * m4.include/mc-check-search-type.m4: support both PCRE versions.
  * */*/Makefile.am: remove @CHECK_CFLAGS@ and @PCRE_LIBS@ ads they are
added via AX_PATH_LIB_PCRE and AX_CHECK_PCRE2.
  * lib/search.h, lib/search/: add support of PCRE2. Thanks broly <gagan@hotmail.com>
for the initial patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-25 10:07:41 +03:00
Andrew Borodin
7257f794d2 Update template for .c files. 
Add section for forward declarations of local functions. This section is
located before file scope variables because functions can be used in
strucutres (see find.c for example):

/*** forward declarations (file scope functions) *************************************************/

/* button callbacks */
static int start_stop (WButton * button, int action);
static int find_do_view_file (WButton * button, int action);
static int find_do_edit_file (WButton * button, int action);

/*** file scope variables ************************************************************************/

static struct
{
    ...
    bcback_fn callback;
} fbuts[] =
{
    ...
    { B_STOP, NORMAL_BUTTON, N_("S&uspend"), 0, 0, NULL, start_stop },
    ...
    { B_VIEW, NORMAL_BUTTON, N_("&View - F3"), 0, 0, NULL, find_do_view_file },
    { B_VIEW, NORMAL_BUTTON, N_("&Edit - F4"), 0, 0, NULL, find_do_edit_file }
};

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:24 +03:00
Kian-Meng Ang
5001232704 Fix various typos in the source code (closes MidnightCommander/mc#177). 
Found via `codespell -S
po,doc,./misc/syntax,./src/vfs/extfs/helpers/README.it -L
parm,rouge,sav,ect,vie,te,dum,clen,wee,dynamc,childs,ths,fo,nin,unx,nd,iif,iterm,ser,makrs,wil`

Co-authored-by: Yury V. Zaytsev <yury@shurup.com>
Signed-off-by: Kian-Meng Ang <kianmeng@cpan.org>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2023-01-28 21:38:05 +03:00
Andrew Borodin
57c61b7681 Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:05 +03:00
Andrew Borodin
52ab57dca0 (sftpfs_read_known_hosts): display the unknown host key type in hex. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:04 +03:00
Andrew Borodin
ab897e4ca6 (vfs_path_element_build_pretty_path_str): return GString. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:04 +03:00
Andrew Borodin
328d27ccf1 Ticket #4426: code clean up before 4.8.30 release. 
(sftpfs_cb_open): minor optimization.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:04 +03:00
Andrew Borodin
ebb328353e (vfs_s_subclass::dir_load): constify argument. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-06-05 12:19:44 +03:00
Andrew Borodin
bb42ed706c (sftpfs_read_known_hosts): clarify displayed value of unknown host key type. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-03-13 13:17:27 +03:00
Andrew Borodin
2c205c5928 Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-03-13 13:17:26 +03:00
Andrew Borodin
d04abc5a76 sftpfs: refactoring. 
Merge init.c, vfs_class.c, and vfs_subclass.c to sftpfs.c.
Rename files:
    init.h -> sftpfs.h.
Rename variables:
    sftpfs_class -> vfs_sftpfs_class.
Rename functions:
    sftpfs_cb_is_equal_connection -> sftpfs_archive_same
    sftpfs_cb_init_connection -> sftpfs_new_archive
    sftpfs_cb_open_connection -> sftpfs_open_archive
    sftpfs_cb_close_connection ->  sftpfs_free_archive
to be consistent with other VFSes.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-11-21 15:00:39 +03:00
Andrew Borodin
4fce4fa7c3 sftpfs: trivial optimization. 
* (sftpfs_opendir): call sftpfs_fix_filename() before loop.
  * (sftpfs_mkdir): likewise.
  * (sftpfs_rmdir): likewise.
  * (sftpfs_open_file): likewise.
  * (sftpfs_stat_init): likewise.
  * (sftpfs_readlink): likewise.
  * (sftpfs_utime): likewise.
  * (sftpfs_chmod): likewise.
  * (sftpfs_unlink): likewise.
  * (sftpfs_rename): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-11-21 15:00:39 +03:00
Andrew Borodin
c3ba19b422 (sftpfs_chmod): set permissions only, don't touch other attributes. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-09-11 20:34:21 +03:00
Andrew Borodin
8e5f8255e1 Ticket #4285: sftp: timestamps are not preserved for uploaded symlink. 
* (sftpfs_symlink): don't call sftpfs_fix_filename() for target file
    bacause it breaks symlink: relative symlinks became an absolute one.
  * (sftpfs_utime): set timestamps only, don't touch other attributes.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-09-11 20:24:30 +03:00
Andrew Borodin
9235d3c232 SFTPFS: verify server fingerprint (fix CVE-2021-36370). 
Use ~/.ssh/known_hosts file to verify server fingerprint
using ssh way:

$ ssh localhost
The authenticity of host 'localhost (127.0.0.1)' can't be established.
ED25519 key fingerprint is SHA256:FzqKTNTroFuNUj1wUzSeV2x/1lpcESnT0ZRCmq5H6o8.
Are you sure you want to continue connecting (yes/no)? no
ssh: Host key verification failed.

$ ssh localhost
The authenticity of host 'localhost (127.0.0.1)' can't be established.
ED25519 key fingerprint is SHA256:FzqKTNTroFuNUj1wUzSeV2x/1lpcESnT0ZRCmq5H6o8.
Are you sure you want to continue connecting (yes/no)? yes
Warning: Permanently added 'localhost' (ED25519) to the list of known hosts.
andrew@localhost's password:

Thanks the Curl project for the used code.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Signed-off-by: Yury V. Zaytsev <yury.zaytsev@moneymeets.com>
 2021-07-26 20:34:17 +03:00
Andrew Borodin
fdd6706245 (sftpfs_open_connection): handle EAGAIN for libssh2_session_handshake(). 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-07-26 20:34:17 +03:00
Andrew Borodin
b0450a1e18 Ticket #4259: SFTPFS VFS: verify server fingerprint (CVE-2021-36370). 
This vulnerability was discovered by AUT-milCERT during an audit of open
source software.

Initial changeset: set minimal version of libssh2 to 1.2.8.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-07-26 20:33:48 +03:00
Andrew Borodin
106d95229f (sftpfs_open_file): don't destroy file handler here. 
Fix Coverity id #331814.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 16:16:45 +03:00
Andrew Borodin
6596185573 (sftpfs_fix_filename): return pointer to GString instead of pointer to char. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:55 +03:00
Andreas Mohr
b71f66dbbd Fix const/unconst casts. 
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-06-20 15:14:55 +03:00
Andrew Borodin
536fb676d8 (vfs_path_free): add 2nd parameter... 
...to free or not to free the string representation
of vfs_path_t object.

It allows to get rid of string duplication in following cases:

vfs_path_t *vpath;
char *path;
...
vpath = vfs_path_from_str (...);
path = g_strdup (vfs_path_as_str (vpath));
vfs_path_free (vpath);

Now we can write:

vfs_path_t *vpath;
char *path;
...
vpath = vfs_path_from_str (...);
path = vfs_path_free (vpath, FALSE);

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-03-14 19:52:39 +03:00
Andrew Borodin
9ee52e77c3 Ticket #4179: code clean up before 4.8.27 release. 
Update copyright years.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-03-14 19:30:42 +03:00
Andrew Borodin
4c7223e9f2 Ticket #4145: file names longer than 255 bytes are not supported. 
Avoid limitation of file name length.

(vfs_dirent): redefined to use instead of standard "struct direct"
to hold file name of any length.
(vfs_class::readdir): return newly allocated vfs_dirent structure.
Related changes.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-12-12 20:23:05 +03:00
Andrew Borodin
31b37a1f79 Ticket #4050: code cleanup before 4.8.25 release. 
Update copyright years.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-02-29 19:10:17 +03:00
Andrew Borodin
68d9961977 Ticket #4022: fix compile failure on AIX 7.2. 
Rename MC VFS flags to avoid name conflicts with system-wide VFS flags
on some OSes (such as AIX).

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-11-18 21:27:56 +03:00
Andrew Borodin
0dacce4228 Do not include <sys/select> globally via "lib/global.h". 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-09-29 15:11:53 +03:00
Adam Majer
dc830db839 Ticket #3921: enable keyboard interactive authentication. 
If SSH server does not support cleartext tunneled password
authentication and only 'keyboard interactive' authentication
instead, then we need to use different authentication
function along with a interactive callback.

Signed-off-by: Adam Majer <amajer@suse.de>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-08-10 09:35:45 +03:00
Andrew Borodin
01a1a01d4e Rename VFS module initialization functions. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-06-15 17:43:00 +03:00
Andrew Borodin
533cbbd971 VFS: make vfs_file_handler related macros more readable. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-04-27 19:29:24 +03:00
Andrew Borodin
6d21416672 VFS: derive VFS-specific file handler class from vfs_file_handler_t. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-04-27 19:29:24 +03:00
Andrew Borodin
86401f30dc VFS: make vfs_super related macros more readable. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-04-27 19:29:24 +03:00
Andrew Borodin
3e08cc7226 VFS: derive VFS-specific super class from vfs_s_super. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-04-27 19:29:24 +03:00
Andrew Borodin
d51f1f4963 VFS: refactor VFS unit initialization. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-04-27 19:29:24 +03:00
Andrew Borodin
672ba46c8b VFS: make vfs_class and vfs_s_subclass related macros more readable. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-04-27 19:29:24 +03:00
Andrew Borodin
0fbd98fece Join vfs_class_flags_t and vfs_subclass_flags_t. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-04-27 19:29:24 +03:00
Andrew Borodin
c764d60238 VFS: (vfs_s_subclass): derive from vfs_class. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-04-27 19:29:24 +03:00
Andrew Borodin
1dd8a47987 Ticket #3955: code cleanup before 4.8.23 release. 
Update copyright years.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-02-03 12:44:40 +03:00
Andrew Borodin
5dacf75cef Ticket #3937: fix crash when trying some sftp connections. 
(sftpfs_recognize_auth_types): fix dereference of NULL returned by
libssh2_userauth_list().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-10-20 18:51:40 +03:00
Andrew Borodin
1fec6e9854 Partially revert "VFS: (vfs_s_subclass): make the derived class from vfs_class." 
This reverts commit 5d1284c4a6.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-09-10 12:47:12 +03:00
Andrew Borodin
c7206191bc Revert "VFS: make VFS-specific super class as derived one from vfs_s_super." 
This reverts commit ab033ad318.
 2018-09-10 12:47:12 +03:00
Andrew Borodin
c91e3d5edb Revert "VFS: make VFS-specific file handler class the derived one from vfs_file_handler_t." 
This reverts commit 2d58e4d624.
 2018-09-10 12:47:12 +03:00
Andrew Borodin
2d58e4d624 VFS: make VFS-specific file handler class the derived one from vfs_file_handler_t. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-09-09 19:10:43 +03:00
Andrew Borodin
ab033ad318 VFS: make VFS-specific super class as derived one from vfs_s_super. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-09-09 19:10:43 +03:00
Andrew Borodin
5d1284c4a6 VFS: (vfs_s_subclass): make the derived class from vfs_class. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-09-09 19:10:43 +03:00
moko
5f603638de Ticket #3917: preserve atime/mtime over sftpfs. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-06-03 14:54:01 +03:00
Andrew Borodin
95e1ab3064 vfs: use LS_NOT_LINEAR constant. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-02-04 11:30:23 +03:00
Andrew Borodin
ddd645526a Update copyright years. 2018-02-04 11:30:22 +03:00
Andrew Borodin
f46c483e64 sftpfs: handle file operation errors. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-12-28 10:22:00 +03:00
Andrew Borodin
bcdb78c7a0 (sftpfs_close_file): return actual result of sftp file close operation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-12-28 10:22:00 +03:00
Andrew Borodin
57be6c6c80 (sftpfs_waitsocket): refactor and use it for file and directory operations. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-12-28 10:21:50 +03:00