Steps to reproduce:
* run mc
* change encoding one of panels to any different from system encoding
* try to copy any file to panel with changed encoding
Expected result: files should be copied.
Actual result: error box here.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
...in case of rename and delete directories.
Steps to reproduce the problem:
* Choose "file listing" mode for one panel and "directory tree" mode for the other.
* Perform all operations on the "file listing" panel.
* Create a new directory -> tree view will update correctly.
* Perform an operation, which changes this directory like rename/delete.
* Deleted directory will still show up on the "directory tree" view.
Renamed directory will show up with the new name, but the old name will also stay there.
Minor cleanup: remove extra parenthesis.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Steps to reproduce:
* run mc
* go to 'F9 -> left/right panel -> Tree'
Expected result: unique directory names.
Actual result: duplicate directory names
(one name with leading slash, second directory name without leading slash).
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
How to reproduce:
on sources: ctags -R .
with tags in current dir open any file (needn't be C source or headers)
Alt- (i.e. alt minus or Esc '-')
Current result: sigsegv
Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
Syntax file properties.syntax used very dark color for keys (cyan is
almost invisible on default MC background), and bright color for
delimiters (yellow), which made highlighted file difficult to read.
Change keys color to yellow.
Change delimeters color to bright cyan.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Test case:
* cp /path/to/any-file.rpm '/tmp/a n y - f i l e.rpm'
* run /usr/bin/mc, go to /tmp
* Press Enter on 'a n y - f i l e.rpm' file
Expected result: mc should be entered to RPM package as in directory
Actual result: gor errors:
Inconsistent extfs archive
error: open of /tmp/a\ failed: No such file or directory
...
error: open of e.rpm failed: No such file or directory
-r--r--r-- 1 root root 0 Jun 29 15:12 ERROR
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
* 2846_cleanup:
Clarify cvs dependency.
Indent files.
(mcview_moveto_eol): comparison of unsigned expression < 0 fixup.
Try fix of compile warnings about assigned but unused variables
Code cleanup: removed unused variables amd removed unnedeed code.
Fix of f13 key handling.
Ticket #2538: mcviewer: unused result of str_term_width1().
src/filemanager/mountlist.c: apply mc code indentation policy.
Sync with gnulib 06b335ade65c8fe60fee8b9e18b670bb54ed924a:
Minor optimization and type accuracy of some editor functions.
Fix of mult-byte characters and tabulation printing.
Menubar: ignore GPM_UP event.
Accuracy use of arguments of dlg_move and widget_move macros.
Ticket #2846: code cleanup before 4.8.1.4 release.
In Search dialog in mcedit M-n hotkey was used for normal search mode.
Therefore, M-n as HistoryPrev in the input line was in accessible.
Change hotkey for normal seach mode to M-r. Use this hotkey for normal diff
mode in mcdiffviewer to unify i18n resources.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
src/filemanager/filegui.c does not compile on Solaris due to missing macros.
AVE_STRUCT_STATVFS_F_BASETYPE and HAVE_STRUCT_STATVFS_F_FSTYPENAME macros
are not set or even defined in config.h. configure scrips does not even
check for those members.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Steps to reproduce:
* ./configure --disable-vfs
* make
Expected result: project should be builded successfully.
Actual result:
build stopped with errors:
lib/vfs/interface.c: In function 'mc_chdir':
lib/vfs/interface.c:714: error: 'struct vfs_s_super' has no member named 'path_element'
lib/vfs/interface.c:716: error: 'struct vfs_s_super' has no member named 'path_element'
lib/vfs/interface.c:717: error: 'struct vfs_s_super' has no member named 'path_element'
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
While copy/move file, the ENOSPC value of errno wasn't handled.
If destination file isn't comlete because of full partition, source file
is kept and destination one is removed unconditionally.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
* 2827_tweak_without_charset:
Tests tweak and cleanup in case of --disable-charset option usage.
Core, mceditor, mcviewer and mcdiffviewer code tweak and cleanup
Ticket #2827: tweak and cleanup of code in case of --disable-charset option usage.