Commit Graph

4366 Commits

Author SHA1 Message Date
Slava Zanko
0a44a9ff5f Ticket #2779: Active VFS directories list contain incorrect current path
1) login to any ftp or fish resource
2) select ftp/fish entry and change current path
3) go back to old path
4) press Ctrl+X A (open "Active VFS directories" dialog)

Expected result: should be correct path to current VFS path
Actual result: path is incorrect.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-04-22 10:23:13 +03:00
Slava Zanko
117aa67155 Ticket #2765: Show directory sizes on any VFS is broken
Command "Show directory sizes" shows zero when executed on ftp, utar, fish etc.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-04-18 10:30:56 +03:00
Andrew Borodin
638cac9be3 Ticket #2776: file selection reset after cd to ".." in remote VFS.
After cd from directory to ".." in remote VFS, directory selection is
reset (".." is selected instead of the previous directory).

Bug was introduced in c457eaf9b1.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-04-15 14:38:04 +04:00
Andrew Borodin
c457eaf9b1 Ticket #2776: file selection reset after exit from the archive in the root.
After exit from archive located in the root of FS, file selection is
reset (/bin is selected instead of the archive).

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-04-13 14:53:57 +04:00
Slava Zanko
764cdf2497 Ticket #2775: segfault after open incorrect archive
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-04-12 22:52:47 +03:00
Slava Zanko
4184555b82 Ticket #2760: The password for session ftp remains in input history
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-04-12 22:31:20 +03:00
Slava Zanko
0e5b78b98b Code optimization: memory allocation and free moved outside of loop.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-04-09 12:30:05 +03:00
Slava Zanko
b4571ad1c5 Ticket #1868: mcedit hang up on replace with regexp.
steps to reproduce:

 * create/open dummy file
 * replace (with regexp enabled)
 * on search string, put: ^ or $
 * on replacement string, put *any string*
 * on confirm replace, select All

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-04-09 12:30:05 +03:00
Ilia Maslakov
55684c3286 Ticket #2766 (Cursor position reset after update)
Cursor position reset after update when panel is panelized, but doesn't.

Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
2012-04-04 15:59:42 +04:00
Andrew Borodin
e4fc99d404 Tweak description of MC_HOME environment variable.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-04-04 15:52:08 +04:00
Slava Zanko
bd5c568f8f Ticket #2663: Segmentation fault while background copying
Action to reproduce bug:
Start copy/move file/files (around 100mb+) in background

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-04-04 13:59:19 +03:00
Andrew Borodin
b4efe67b12 (diff_view): make static.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-04-04 13:57:23 +04:00
Andrew Borodin
118d7c1d1d Make mcdiff verbose if one or both parameters are incorrect.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-04-04 13:57:22 +04:00
Andrew Borodin
809f668717 Ticket #2769: crash on compare files if one panel is not in the listing mode.
Added check of panel types before run file comparision.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-04-04 13:57:22 +04:00
Egmont Koblinger
caf5a9e1b5 Ticket #2763 (Last word of help links not clickable)
The last word of hyperlinks in the interactive help don't act on mouse clicks.
    This also implies that one-word links can't be clicked at all.

Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
2012-03-28 13:26:45 +04:00
Slava Zanko
2a5885fb7f Ticket #2761: save file on top of existing directory changes dir's permissions
Steps to reproduce:

mkdir foo
chmod 0700 foo
mcedit bar
ls -ld foo
drw-r--r-- 1 slyfox users 0 Mar 22 22:10 foo

We've lost dir's permissions.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-03-27 11:05:13 +03:00
Ilia Maslakov
f0f39cb2a7 code indentation
Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
2012-03-26 10:12:24 +04:00
Slava Zanko
a58aee00cb Ticket #2278: Problem in the Copy operation
Previously, copying a file does not change access permissions of the destination
file if the check box "Preserve attributes" in the Copy window is not set.
For some time it is not so: if you uncheck the "Preserve attributes" then access
permissions of the destination file are set in accordance with the value of
umask, which can lead to information disclosure(i.e. security problem).

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-03-26 09:50:02 +04:00
Slava Zanko
d52b1dced1 Ticket #2759: Unable to edit gzipped files
Steps to reprosuce:

 *) dmesg| gzip -c9 > out.gz
 *) press F4 on out.gz file

Expected result: editor should be opened
Actual result: segmentation fault.

Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-03-25 15:34:08 +03:00
Andrew Borodin
62f382b70e Ticket #2384: allow rebind Fx keys in the file manager.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-25 10:39:35 +04:00
Andrew Borodin
87174bad44 Optimization of second panel directory setup.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-03-24 17:20:26 +03:00
Andrew Borodin
188a20f333 Ticket #2762: mc ignores second directory argument.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-24 17:20:26 +03:00
Slava Zanko
408ba2a2de hotlist: fixed broken newly added entries.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-03-22 11:04:06 +03:00
Slava Zanko
296eec83eb Ticket #2753: fixed entering to old-style path format.
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-03-22 11:04:06 +03:00
Andrew Borodin
529a7ba24c Ticket #2754: mceedit can't run w/o file as parameter.
Also fixed segfault while run `mc -v ""`.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-21 14:12:17 +03:00
Ilia Maslakov
4a940004ed Added new entry to the external panelize - "Modified git files".
Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
2012-03-19 17:00:29 +04:00
Andrew Borodin
7b28a01feb Fixed handling actions in chmod dialog
...in according with 7e6ff9caf9

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:07:43 +03:00
Andrew Borodin
4f5c2e1649 (extfs_get_path_mangle): renamed to extfs_get_path_int
and chnaged type of returned value to pointer to constant.

Related changes.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:06:01 +03:00
Andrew Borodin
c2406adfce (extfs_get_path_mangle): minor optimization.
Avoid string allocation if it is really unneeded.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:06:01 +03:00
Andrew Borodin
8b8c9a4f34 (panel_reload): fixup of panel current directory obtain.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:06:01 +03:00
Andrew Borodin
62bbe53205 (edit_load_file_from_filename): fixed file unlocking.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:06:01 +03:00
Slava Zanko
409e8ab5fd Typo fix in message
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
2012-03-19 11:06:01 +03:00
Andrew Borodin
4bd81f5866 (expand_format): minor optimization.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:06:01 +03:00
Andrew Borodin
53b146c83a Added default shortcuts for dynamically resize panels.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:06:01 +03:00
Andrew Borodin
308237aa11 Fixed preprocessor conditions.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:06:00 +03:00
Andrew Borodin
d38385eb37 find.c: drop support of legacy config option.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:06:00 +03:00
Andrew Borodin
67a4c6d521 Added macros for Layout and Misc sections of main config file.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:06:00 +03:00
Andrew Borodin
dea3aa9023 Reorder fields in mc_global struct and change type for some of them.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:06:00 +03:00
Andrew Borodin
0960ef2541 Removed useless return.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:04:58 +03:00
Andrew Borodin
01e51f5496 Editor: avoid extra screen redraw.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:04:57 +03:00
Andrew Borodin
4ca6fe66aa editdraw.c: removed unused defines.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:04:57 +03:00
Andrew Borodin
c7bde637f9 Tweak background operations support.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:04:57 +03:00
Andrew Borodin
aadf01f390 Include sys/param.h conditionally.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:04:57 +03:00
Andrew Borodin
f7f37f674e Check assert.h header and use it conditionally.
assert(3) should be replaced with g_assert().

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:04:57 +03:00
Andrew Borodin
b3d1eafb5e Minor optimization of memory allocation for string copy.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:04:57 +03:00
Andrew Borodin
e2b67a33ba Ticket #2740: code cleanup before 4.8.2 release.
Removes references to AC_HEADER_STDC macro, marked as obsolescent
in the Autoconf 2.60 release.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:04:56 +03:00
Andrew Borodin
13a660d2e0 Allow setup mc home directory using MC_HOME environment variable.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-19 11:43:55 +03:00
Andrew Borodin
cce7ccf48a Tweak arguments parsing
...to allow to show info about mc options regardless of the fact that
configuration directories cannot be created.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-17 19:04:22 +03:00
Andrew Borodin
dcba554a6d Handle error of mc main loop.
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-17 19:04:22 +03:00
Andrew Borodin
9919577962 Ticket #2738: handle errors at mc sturtup stage.
Don't run MC if configuration directory cannot be created.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
2012-03-17 19:04:22 +03:00