mirrors
/
mc
mirror of https://github.com/MidnightCommander/mc
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
16,102 Commits 47 Branches 83 Tags 90 MiB
Commit Graph

310 Commits

Author SHA1 Message Date
Yury V. Zaytsev 877ef7d78b tests: don't free after `ck_abort_msg` as it's marked no-return 
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-19 08:56:56 +02:00
Yury V. Zaytsev 22b80bf2d4 tests: fix `-Winvalid-source-encoding` warnings in `path_recode` 
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-19 08:56:56 +02:00
Yury V. Zaytsev 5779e51e69 tests: fix `-Winvalid-source-encoding` warnings in `config_string` 
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-19 08:56:56 +02:00
Yury V. Zaytsev 15eeb94d2c tests: fix `-Wmissing-variable-declarations` warnings in vfs tests 
```
../../../../tests/lib/vfs/vfs_parse_ls_lga.c:39:23: warning: no previous extern declaration for non-static variable 'test_subclass1' [-Wmissing-variable-declarations]
struct vfs_s_subclass test_subclass1;
                      ^
../../../../tests/lib/vfs/vfs_parse_ls_lga.c:42:21: warning: no previous extern declaration for non-static variable 'vfs_root_entry' [-Wmissing-variable-declarations]
struct vfs_s_entry *vfs_root_entry;
                    ^
../../../../tests/lib/vfs/vfs_s_get_path.c:40:23: warning: no previous extern declaration for non-static variable 'test_subclass1' [-Wmissing-variable-declarations]
struct vfs_s_subclass test_subclass1, test_subclass2, test_subclass3;
                      ^
```

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-19 08:56:56 +02:00
Yury V. Zaytsev 5b63416d04 tests: fix `-Wmissing-variable-declarations` warnings in filevercmp 
```
../../../../tests/lib/strutil/filevercmp.c:213:14: warning: no previous extern declaration for non-static variable 'filevercmp_test_ds2_len' [-Wmissing-variable-declarations]
const size_t filevercmp_test_ds2_len = G_N_ELEMENTS (filevercmp_test_ds2);
             ^
../../../../tests/lib/strutil/filevercmp.c:250:14: warning: no previous extern declaration for non-static variable 'filevercmp_test_ds3_len' [-Wmissing-variable-declarations]
const size_t filevercmp_test_ds3_len = G_N_ELEMENTS (filevercmp_test_ds3);
             ^
../../../../tests/lib/strutil/filevercmp.c:288:14: warning: no previous extern declaration for non-static variable 'filevercmp_test_ds4_len' [-Wmissing-variable-declarations]
const size_t filevercmp_test_ds4_len = G_N_ELEMENTS (filevercmp_test_ds4);
             ^
../../../../tests/lib/strutil/filevercmp.c:349:14: warning: no previous extern declaration for non-static variable 'filevercmp_test_ds5_len' [-Wmissing-variable-declarations]
const size_t filevercmp_test_ds5_len = G_N_ELEMENTS (filevercmp_test_ds5);
             ^
```

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-19 08:56:56 +02:00
Yury V. Zaytsev 93b539444b Ticket #4584: re-implement mocking via weak symbols instead of symbol duplication 
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-19 08:56:40 +02:00
Andrew Borodin 3da5412999 maint/utils/update-years.sh: add tests/src/vfs/extfs/helpers-list/test_all. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-10-05 15:05:58 +03:00
Yury V. Zaytsev 8f723b8a7f charset: reimplement `is_supported_encoding` to use iconv instead of mc built-in charset table 
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-05 11:49:26 +02:00
Yury V. Zaytsev c079a09612 tests: edit_complete_word_cmd - fix `-Winvalid-source-encoding` to make it easier to debug 
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-05 11:49:26 +02:00
Yury V. Zaytsev 1e0e6b5e1e charset: rename IBM866 to CP866 for iconv and adjust charset names for codeset 
```
linux $ iconv -l | grep 866
866//
866NAV//
CP866//
CP866NAV//
CSIBM866//
IBM866//
IBM866NAV//

solaris $ iconv -l | grep 866
    CP866 (CP866, CP-866, CP_866, 866),
    IBM-866,

macos % iconv -l | grep 866
CP866 866 CSIBM866 IBM866 MSCP866

musl/src/locale/codepages.h: "cp866\0"
```

On glibc-based systems, codeset will be set to charmap name, on most other systems it seems to be taken from locale name.

## Linux

```
zaytsev@fedora:~$ locale -a | grep ru
ru_RU
ru_RU.cp866
ru_RU.ibm866
ru_RU.iso88595
ru_RU.koi8r
ru_RU.utf8
russian
ru_UA
ru_UA.koi8u
ru_UA.utf8

zaytsev@fedora:~/src$ LC_ALL=ru_RU.cp866 LANG=ru_RU.cp866 ./a.out
IBM866

zaytsev@fedora:~/src$ LC_ALL=ru_RU.koi8r LANG=ru_RU.koi8r ./a.out
KOI8-R

zaytsev@fedora:~/src$ LC_ALL=ru_RU.iso88595 LANG=ru_RU.iso88595 ./a.out
ISO-8859-5
```

## macOS

```
ru_RU.ISO8859-5
ru_RU.CP866
ru_RU.CP1251
ru_RU.UTF-8
ru_RU.KOI8-R
ru_RU

zaytsev@Yurys-MBP mc % LANG=ru_RU.CP866 LC_ALL=ru_RU.CP866 ./a.out
CP866

zaytsev@Yurys-MBP mc % LANG=ru_RU.ISO8859-5 LC_ALL=ru_RU.ISO8859-5 ./a.out
ISO8859-5
```

## FreeBSD

```
ru_RU.CP1251
ru_RU.CP866
ru_RU.ISO8859-5
ru_RU.KOI8-R
ru_RU.UTF-8

zaytsev@cfarm240:~ $ LANG=ru_RU.ISO8859-5 LC_ALL=ru_RU.ISO8859-5 ./a.out
ISO8859-5

zaytsev@cfarm240:~ $ LANG=ru_RU.CP866 LC_ALL=ru_RU.CP866 ./a.out
CP866
```

## Solaris

```
ru
ru.UTF-8
ru.koi8-r
ru_RU
ru_RU.ANSI1251
ru_RU.ISO8859-5
ru_RU.KOI8-R
ru_RU.UTF-8

zaytsev@gcc-solaris10:~/src$ LANG=ru_RU.ISO8859-5 LC_ALL=ru_RU.ISO8859-5 ./a.o>
ISO8859-5

zaytsev@gcc-solaris10:~/src$ LANG=ru.koi8-r LC_ALL=ru.koi8-r ./a.out
KOI8-R
```

## AIX

```
zaytsev@gcc111:[/home/zaytsev]locale -a
C
POSIX
en_US.8859-15
en_US.IBM-858
en_US.ISO8859-1
en_US

-bash-5.1$ LANG=en_US.ISO8859-1 LC_ALL=en_US.ISO8859-1 ./a.out
ISO8859-1
```

Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-05 11:49:26 +02:00
Yury V. Zaytsev f34e2ae715 tests: use UTF-8 to prevent creation of invalid converters 
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-05 11:49:26 +02:00
Yury V. Zaytsev 319598df41 tests: path_len - fix assertions, now test should fail 
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-05 11:49:26 +02:00
Yury V. Zaytsev 8978b7f1d6 Ticket #3972: fix test harness on Illumos by resolving shellcheck warnings 
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-10-05 11:49:26 +02:00
Yury V. Zaytsev a3ce493ae2 vfs: fix tempdir path building to account for trailing slash on macOS 
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-09-03 07:39:25 +02:00
slowpeek 2971db6226 Ticket #4567: Test fails in iso9660.xorriso in 4.8.32-pre1. 
xorriso uses different date formats when listing recent (180 days old at max)
and older items. For the test to not fail with time, it is important to NOT have
any "recent" items in the input data.

Closes MidnightCommander/mc#204.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-08-10 20:37:28 +03:00
Yury V. Zaytsev eb1375b65d vfs: implement support for all known stat formats and centralize handling 
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2024-07-28 10:00:52 +02:00
Andrew Borodin 6718b3ec26 Indentation using GNU indent-2.2.13. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-06-02 12:49:13 +03:00
Andrew Borodin 46ea5e2a99 Clarify handling of "#enc:". 
* (vfs_canon): treate "#enc:" as a regular part of path in case of
    --disable-charset.
  * (realpath_test): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-06-02 12:41:34 +03:00
Andrew Borodin e496af7a1c input complete: reimplement using GPtrArray. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-06-02 12:41:32 +03:00
slowpeek 62915a38f1 extfs: add test data for the iso9660 extfs helper (xorriso part) 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-05-18 19:47:06 +03:00
Andrew Borodin a2f65852e3 Merge lib/utilunix.h into lib/util.h. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-04-07 16:38:11 +03:00
Andrew Borodin aa38245e85 Merge lib/strescape.h into lib/strutil.h. Rename functions. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-04-07 16:38:11 +03:00
Andrew Borodin 258b52b2d1 mceditor: massive use of edit_arg_t as function argument. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-04-07 16:38:11 +03:00
Andrew Borodin 44d8213f4e Ticket #4533: External editor does not work with arguments in $EDITOR 
When using an external editor (i.e. "Use internal edit" in the Configure
Options is unchecked) the environment variable EDITOR is used. However,
if $EDITOR contains a command line argument after the executable name,
these arguments are not processed properly, and the editor might not be
started at all.

How to reproduce: (Precondition: vi is available on the system)
  1) On the command line, execute: export EDITOR="vi +" && mc
(the + argument should let vi start at the document's end instead of the
beginning).
  2) Go to the Options menu -> Configuration -> uncheck "Use internal
edit".
  3) Move the cursor to a file that is larger than a single screen (e.g.
ABOUT-NLS in mc's source directory).
  4) Press F4 to start the external editor.

Result: Nothing visible happens

Expected result: vi is opened showing the end of the file ABOUT-NLS

The bug: my_system_make_arg_array() doesn't perform full-feature
parsing of the comman line.

  * (str_tokenize): mew function based on history_tokenize_internal()
from GNU readline-8.2.
  * (str_tokenize_word): mew function based on history_tokenize_word()
from GNU readline-8.2.
  * (my_system_make_arg_array): reimplement using str_tokenize().
  * (my_systemv_flags): use modified my_system_make_arg_array().
  * (fork_child_tokens): new test for string tokenization.
  * (fork_child_tokens2): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-03-31 19:04:26 +03:00
Andrew Borodin fe42478b97 Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-01-01 09:46:17 +03:00
Andrew Borodin 2019737846 (test_glob_prepare_replace_str): remove unneeded type cast. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-12-31 19:28:44 +03:00
Andrew Borodin d4e59aa022 Refactoring: avoid create an empty strings. 
* (name_quote): return NULL instead of an empty string.
  * (fake_name_quote): likewise.
  * (expand_format): likewise.
  * Related changes.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-11-06 21:06:14 +03:00
Andrew Borodin 6ca4ab4b4e Rename FISH VFS to SHELL one. 2023-10-15 16:04:39 +03:00
Andrew Borodin 77890a3d1a tests: fix incomplete linkage in case of --enable-mclib. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-13 14:59:25 +03:00
Andrew Borodin 8ce06c4868 (str_replace_all): refactoring. 
Get rig of intermediate storage of string patrs. Create result string directly.
Update comments. Update test.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:05:44 +03:00
Andrew Borodin 634219ccad tests/lib/strutil/str_replace_all.c: rename file. 2023-08-04 21:04:55 +03:00
Andrew Borodin f1cf92f435 Indentation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:55 +03:00
Andrew Borodin e20d9acecb Use vfs_path_get_last_path_str() where it is resonable. 2023-08-04 21:04:55 +03:00
Andrew Borodin 044c035900 Use bit-field members of file_entry_t as integers explicitly. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:54 +03:00
Andrew Borodin f29118dcec WPanel: rename 'selected' to 'current' and related changes. 
Renames:
  WPanel::selected -> WPanel::current
  selection (macro) -> panel_current_entry()
  panel_selected_at_half() -> panel_current_at_half()
  move_selection() -> panel_move_current()
  do_select() -> panel_set_current()
  try_to_select() -> panel_set_current_by_name()
  mark_if_marking(): argument and intermal variables
  file attributes:
    SELECTED -> CURRENT
    MARKED_SELECTED -> MARKED_CURRENT

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:54 +03:00
Andrew Borodin 97e8cbc8d6 (test_vfs_setup_cwd_symlink): simplify. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:11 +03:00
Andrew Borodin 3616877462 (vfs_get_cwd): rename from _vfs_get_cwd(), simplify. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:11 +03:00
Andrew Borodin 52572d5b80 (vfs_path_new): add argument to create relative path object. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-08-04 21:04:11 +03:00
Evgeny Grin 8cd913a28a Ticket #4460: fix unportable '$<' in Makefiles. 
POSIX specifis '$<' only for "inference" rules (i.e. general rule
like '.c.o:'), while for "target" is undefined.
It is supported as extension for targets by some "make" implementations,
but not all.
The workarounds could be easily used.

Closes MidnightCommander/mc#185.

Signed-off-by: Karlson2k (Evgeny Grin) <k2k@narod.ru>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-05-20 20:18:58 +03:00
Andrew Borodin 49624e473b Ticket #4450: support PCRE2 in the search engine. 
* m4.include/ax_path_lib_pcre.m4: replace by recent version from GNU
Autoconf Archive.
  * m4.include/ax_check_pcre2.m4: get grom GNU Autoconf Archive.
  * m4.include/mc-check-search-type.m4: support both PCRE versions.
  * */*/Makefile.am: remove @CHECK_CFLAGS@ and @PCRE_LIBS@ ads they are
added via AX_PATH_LIB_PCRE and AX_CHECK_PCRE2.
  * lib/search.h, lib/search/: add support of PCRE2. Thanks broly <gagan@hotmail.com>
for the initial patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-25 10:07:41 +03:00
Andrew Borodin 8a951746b3 Collect all editor options to structure. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:24 +03:00
Andrew Borodin 7257f794d2 Update template for .c files. 
Add section for forward declarations of local functions. This section is
located before file scope variables because functions can be used in
strucutres (see find.c for example):

/*** forward declarations (file scope functions) *************************************************/

/* button callbacks */
static int start_stop (WButton * button, int action);
static int find_do_view_file (WButton * button, int action);
static int find_do_edit_file (WButton * button, int action);

/*** file scope variables ************************************************************************/

static struct
{
    ...
    bcback_fn callback;
} fbuts[] =
{
    ...
    { B_STOP, NORMAL_BUTTON, N_("S&uspend"), 0, 0, NULL, start_stop },
    ...
    { B_VIEW, NORMAL_BUTTON, N_("&View - F3"), 0, 0, NULL, find_do_view_file },
    { B_VIEW, NORMAL_BUTTON, N_("&Edit - F4"), 0, 0, NULL, find_do_edit_file }
};

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:24 +03:00
Andrew Borodin 8fdcbeed74 Move definition of file_entry_t to separate file. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:23 +03:00
Andrew Borodin cf223bec27 Use g_ptr_array_new_with_free_func() where reasonably. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:23 +03:00
Kian-Meng Ang 5001232704 Fix various typos in the source code (closes MidnightCommander/mc#177). 
Found via `codespell -S
po,doc,./misc/syntax,./src/vfs/extfs/helpers/README.it -L
parm,rouge,sav,ect,vie,te,dum,clen,wee,dynamc,childs,ths,fo,nin,unx,nd,iif,iterm,ser,makrs,wil`

Co-authored-by: Yury V. Zaytsev <yury@shurup.com>
Signed-off-by: Kian-Meng Ang <kianmeng@cpan.org>
Signed-off-by: Yury V. Zaytsev <yury@shurup.com>
 2023-01-28 21:38:05 +03:00
Andrew Borodin 57c61b7681 Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:05 +03:00
Andrew Borodin 6f352854fa tests/mctest.h: indentation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:04 +03:00
Andrew Borodin a4d254c6ec Ticket #4429: multi-line search is buggy. 
Revert "Ticket #400: support multi-line search."

This reverts commit e370818c09.

Update doc/README.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-15 16:10:38 +03:00
Yury V. Zaytsev 9d7a83aec6 maint: update address protocol and mailing list information 2023-01-02 21:43:20 +01:00
Andrew Borodin 3f882f50e0 Ticket #4413: mcedit: syntax definitions in user location don't work. 
Fix location of all user's syntax related stuff. Now it is the
~/.local/share/mc/syntax/ directory.

Don't use the system configuration directory (/etc/mc) as a storage
of syntax definitions.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-12-18 14:20:36 +03:00