mirrors/mc
1
0
Fork 0
mirror of https://github.com/MidnightCommander/mc synced 2024-12-22 20:36:50 +03:00
Code Issues Packages Projects Releases Wiki Activity
16,173 Commits 47 Branches 83 Tags 91 MiB
4572_cleanup
Commit Graph

43 Commits

Author SHA1 Message Date
Andrew Borodin
2db4f47bdd (tr_utf8_search_{first,last}): minor refactoring. 
Reduce variable scope.
Call strlen(search) before loop.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-10-05 15:05:58 +03:00
Andrew Borodin
87f46330d5 (str_utf8_make_make_term_form): call strlen() one time. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-10-05 15:05:58 +03:00
Andrew Borodin
6718b3ec26 Indentation using GNU indent-2.2.13. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-06-02 12:49:13 +03:00
Andrew Borodin
fe42478b97 Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2024-01-01 09:46:17 +03:00
Andrew Borodin
247d092217 (str_utf8_offset_to_pos): change type of variable. 
GString is pointless here.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-12-31 19:28:44 +03:00
Andrew Borodin
7257f794d2 Update template for .c files. 
Add section for forward declarations of local functions. This section is
located before file scope variables because functions can be used in
strucutres (see find.c for example):

/*** forward declarations (file scope functions) *************************************************/

/* button callbacks */
static int start_stop (WButton * button, int action);
static int find_do_view_file (WButton * button, int action);
static int find_do_edit_file (WButton * button, int action);

/*** file scope variables ************************************************************************/

static struct
{
    ...
    bcback_fn callback;
} fbuts[] =
{
    ...
    { B_STOP, NORMAL_BUTTON, N_("S&uspend"), 0, 0, NULL, start_stop },
    ...
    { B_VIEW, NORMAL_BUTTON, N_("&View - F3"), 0, 0, NULL, find_do_view_file },
    { B_VIEW, NORMAL_BUTTON, N_("&Edit - F4"), 0, 0, NULL, find_do_edit_file }
};

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-03-19 20:34:24 +03:00
Andrew Borodin
57c61b7681 Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2023-01-28 21:38:05 +03:00
Andrew Borodin
2c205c5928 Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2022-03-13 13:17:26 +03:00
Andrew Borodin
e71972003e lib/strutil/strutilutf8.c: use MB_LEN_MAX constant. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-11-21 15:00:39 +03:00
Andrew Borodin
9ee52e77c3 Ticket #4179: code clean up before 4.8.27 release. 
Update copyright years.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2021-03-14 19:30:42 +03:00
Andrew Borodin
5bf714b008 Ticket #4131: use G_UNICODE_SPACING_MARK instead of G_UNICODE_COMBINING_MARK. 
G_UNICODE_COMBINING_MARK is deperecated in glib >= 30.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-10-15 15:16:24 +03:00
Andrew Borodin
31b37a1f79 Ticket #4050: code cleanup before 4.8.25 release. 
Update copyright years.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2020-02-29 19:10:17 +03:00
Andrew Borodin
1dd8a47987 Ticket #3955: code cleanup before 4.8.23 release. 
Update copyright years.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2019-02-03 12:44:40 +03:00
Andrew Borodin
52d1980c46 strutil: character test functions return gboolean instead of int. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-02-04 11:30:23 +03:00
Andrew Borodin
8b6f4ef2c2 Use gboolean instead of int in file/dir sort related functions. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-02-04 11:30:23 +03:00
Andrew Borodin
ddd645526a Update copyright years. 2018-02-04 11:30:22 +03:00
devzero
7f9b333861 Ticket #3616: speed up of utf-8 normalization. 
When content of a large directory is being sorted by file names, a
significant amount of CPU time is spent in str_utf8_normalize() that is
called from str_utf8_create_key_gen().

For example, /usr/bin/ contains 5437 files on my Archlinux box. Running
mc /usr/bin/ /usr/bin/ takes approx. 75 000 000 CPU instructions to sort
file names, or 25% of total program run time. From these 75 000 000
instructions, 42 500 000 instruction are spent in str_utf8_normalize().

str_utf8_normalize() uses g_utf8_normalize() to do the work.
g_utf8_normalize() is a heavyweight function, that converts UTF-8 into
UCS-4, does the normalization and then converts UCS-4 back into UTF-8.

Since file names are composed of ASCII characters in most cases, we can
speed up str_utf8_normalize() by checking if the heavyweight Unicode
normalization is actually needed. Normalization of ASCII string is
no-op, so it is effectively "normalized" by just strdup().

With this patch, running mc /usr/bin/ /usr/bin/ requires just 37 000 000
instructions to sort the file names (down from 75 000 000) and 4 500 000
instuctions to do str_utf8_normalize() (down from 42 500 000).

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-07-29 10:23:09 +03:00
Andrew Borodin
e9fd11bfcd Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-01-22 19:12:55 +03:00
Andrew Borodin
bc14ff44c8 Remove min() and max() macros. Use MIN() and MAX() macros from GLib. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Andrew Borodin
2d77cb32f9 lib/strutil/strutilutf8.c: grammar. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Andrew Borodin
41035995c8 lib/strutil/{strutil8bit.c,strutilutf8.c}: cleanup -Wcast-qual warning. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-04-16 10:23:44 +03:00
Andrew Borodin
471ea781ca Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-01 11:48:10 +03:00
Andrew Borodin
615eba776d Ticket #3420: code cleanup before 4.8.15 release. 
lib/strutil/*.c: apply template.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-11-05 14:32:51 +03:00
Andrew Borodin
2789e6e390 Ticket #3431: add missing default cases. 
Introduce -Wswitch-default check.

Some minor cosmetics.

Thanks Andreas Mohr <and at gmx dot li> for original patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-05-03 19:43:50 +03:00
Andrew Borodin
454479549c Update copyright years. 2015-02-26 09:12:08 +03:00
Slava Zanko
512ad7d962 Make working with GError in more right way (like with exceptions). 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2014-07-22 13:12:07 +04:00
Andrew Borodin
e5203cb023 Fix name of FSF in all *.c files. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-02-28 13:33:17 +04:00
Andrew Borodin
f0da49345a Collapse list of copyright years to ranges. Add 2014 year. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-02-10 16:27:03 +04:00
Slava Zanko
0d489acd58 cppcheck: reduce variable scope. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-11-25 13:47:39 +04:00
Andrew Borodin
17aef88637 lib/strutil/strutilutf8.c: cosmetics and minor refactoring. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-07-23 14:01:05 +04:00
Slava Zanko
80c8d58003 remove the include duplicates from source files 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-06-03 10:58:14 +03:00
Andrew Borodin
6cd19ea6cb Remove irrelevant comments about file_date() function. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-01-16 14:34:34 +04:00
Andrew Borodin
0e5b483974 Portability: rename some str_class members 
...to avoid conflict with global names.

On HP-UX, inttypes.h includes ctype.h through other dependencies, ctype.h
defines macros for various functions and these macros clash with entries
of "struct str_class".

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-12-20 15:35:35 +04:00
Andrew Borodin
04942e5f2b (str_iscombiningmark): return gboolean instead of int 
...and related changes.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-12-20 15:18:06 +04:00
Andrew Borodin
8e224507c1 (str_utf8_normalize): ret rid of extra memory allocation. 
(str_utf8_casefold_normalize): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-09-10 14:29:53 +03:00
Slava Zanko
94bd4b1f78 Code indentation. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2012-07-17 17:04:05 +04:00
Slava Zanko
0138645541 Ticket 1551: Update GPL version from 2 to 3 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2011-10-18 14:08:34 +03:00
Andrew Borodin
1c0e5a4773 Fix potential segfault in term_trim() functions 
...if requested width is negative.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2011-10-17 13:30:03 +03:00
Andrew Borodin
f70e06b37a Optimization of str_msg_term_size(). 
Use single function to calculate of text lines and columns
because algorithm is the same for all encodings.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2010-11-24 10:51:30 +03:00
Slava Zanko
feb733663f Code indentation in lib directory 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2010-11-24 10:27:20 +03:00
Andrew Borodin
4aec2187e1 Ticket #1894: sort order should not mix hidden files with others. 
In case sensitive sort, the order of files and directories is following:
hidden dirs
dirs
hidden files
files

In case insensitive mode, directories are mixed and files are mixed too:
dirs (hidden and not are mixed)
files (hidden and not are mixed).

This commit defines the sort order independently of case sensitivity:
hidden dirs
dirs
hidden files
files

Files in UTF-8 locale require special handling: leading dot must not be
processed in g_utf8_casefold() funcion.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2010-11-01 15:02:57 +03:00
Slava Zanko
cd4dbf3a09 Changes for build after moving strutil into lib 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2010-01-26 10:30:24 +02:00
Slava Zanko
7fa24fbc9b Moved strutil-related stuff from src into lib/strutil/* 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2010-01-26 10:30:24 +02:00