mirrors/mc
1
0
Fork 0
mirror of https://github.com/MidnightCommander/mc synced 2024-12-22 12:32:40 +03:00
Code Issues Packages Projects Releases Wiki Activity
14,290 Commits 47 Branches 83 Tags 91 MiB
3858-rotating_dash_location
Commit Graph

78 Commits

Author SHA1 Message Date
Andrew Borodin
eb507862ff (str_ptr_array_join): constify argument. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-09-09 19:10:43 +03:00
Andrew V. Samoilov
dfd6d99e1c (str_8bit_encodings[], str_utf8_encodings[]): make const. 
Signed-off-by: Andrew V. Samoilov <a.samoilov@gmail.com>
 2018-02-04 11:30:23 +03:00
Andrew Borodin
52d1980c46 strutil: character test functions return gboolean instead of int. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-02-04 11:30:23 +03:00
Andrew Borodin
8b6f4ef2c2 Use gboolean instead of int in file/dir sort related functions. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2018-02-04 11:30:23 +03:00
Andrew Borodin
ddd645526a Update copyright years. 2018-02-04 11:30:22 +03:00
devzero
7f9b333861 Ticket #3616: speed up of utf-8 normalization. 
When content of a large directory is being sorted by file names, a
significant amount of CPU time is spent in str_utf8_normalize() that is
called from str_utf8_create_key_gen().

For example, /usr/bin/ contains 5437 files on my Archlinux box. Running
mc /usr/bin/ /usr/bin/ takes approx. 75 000 000 CPU instructions to sort
file names, or 25% of total program run time. From these 75 000 000
instructions, 42 500 000 instruction are spent in str_utf8_normalize().

str_utf8_normalize() uses g_utf8_normalize() to do the work.
g_utf8_normalize() is a heavyweight function, that converts UTF-8 into
UCS-4, does the normalization and then converts UCS-4 back into UTF-8.

Since file names are composed of ASCII characters in most cases, we can
speed up str_utf8_normalize() by checking if the heavyweight Unicode
normalization is actually needed. Normalization of ASCII string is
no-op, so it is effectively "normalized" by just strdup().

With this patch, running mc /usr/bin/ /usr/bin/ requires just 37 000 000
instructions to sort the file names (down from 75 000 000) and 4 500 000
instuctions to do str_utf8_normalize() (down from 42 500 000).

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-07-29 10:23:09 +03:00
Andrew Borodin
e9fd11bfcd Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2017-01-22 19:12:55 +03:00
Andrew Borodin
2356acc26d NULL-ize some variables to make unit tests happy. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-11-21 13:12:55 +03:00
Andrew Borodin
9a39e35dc3 Use g_assert() instead of assert(3). 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-11-21 13:12:55 +03:00
Andreas Mohr
b36cec44e3 Cleanup unused macros. 
Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-07-29 09:32:04 +03:00
Andrew Borodin
bdb81cd482 Sync with gnulib 6ed53f13bc39d9a0252549e98a2a59441fb2351f. 
lib/strutil/xstrtol.c: prohibit monstrosities like "1bB".

Problem reported by Young Mo Kang in: http://bugs.gnu.org/23388.

(xstrtoumax): Allow trailing second suffixes like "B" only if the first
suffix needs a base.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:28:47 +03:00
Andrew Borodin
bc14ff44c8 Remove min() and max() macros. Use MIN() and MAX() macros from GLib. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Andrew Borodin
2d77cb32f9 lib/strutil/strutilutf8.c: grammar. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-05-07 16:19:02 +03:00
Andrew Borodin
41035995c8 lib/strutil/{strutil8bit.c,strutilutf8.c}: cleanup -Wcast-qual warning. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-04-16 10:23:44 +03:00
Andrew Borodin
471ea781ca Update copyright years. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2016-01-01 11:48:10 +03:00
Andrew Borodin
615eba776d Ticket #3420: code cleanup before 4.8.15 release. 
lib/strutil/*.c: apply template.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-11-05 14:32:51 +03:00
Andrew Borodin
2789e6e390 Ticket #3431: add missing default cases. 
Introduce -Wswitch-default check.

Some minor cosmetics.

Thanks Andreas Mohr <and at gmx dot li> for original patch.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-05-03 19:43:50 +03:00
Andreas Mohr
bd051e4095 lib/strutil/strutil8bit.c: remove unused functions. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-05-03 19:43:49 +03:00
Andrew Borodin
8c88aa01ad Remove code required for GLib < 2.14.0. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2015-02-26 09:20:54 +03:00
Andrew Borodin
454479549c Update copyright years. 2015-02-26 09:12:08 +03:00
Slava Zanko
512ad7d962 Make working with GError in more right way (like with exceptions). 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2014-07-22 13:12:07 +04:00
Andrew Borodin
e6030d8e74 Sync with gnulib 94ee038129c3b40510ef0ff6ac6ddfe85bf0f97f. 
(xstrtoumax): use enum instead of 0, to pacify IRIX 6.5 cc.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:12:06 +04:00
Andrew Borodin
a6c5c82fa0 (str_ascii_fit_to_term): fix out-of-bound write. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:10:41 +04:00
Andrew Borodin
4e5819d169 (str_8bit_fit_to_term): fix out-of-bound write. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-07-22 13:10:41 +04:00
Andrew Borodin
e5203cb023 Fix name of FSF in all *.c files. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-02-28 13:33:17 +04:00
Andrew Borodin
43bf10b170 Ticket #3167: copyright issues. 
lib/strutil/xstrtol.c: restore copyright line.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-02-28 13:33:16 +04:00
Andrew Borodin
f0da49345a Collapse list of copyright years to ranges. Add 2014 year. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2014-02-10 16:27:03 +04:00
Slava Zanko
0d489acd58 cppcheck: reduce variable scope. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-11-25 13:47:39 +04:00
Slava Zanko
0b0f7e3975 Refactoring: use define DEFAULT_CHARSET for "ASCII" charset. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-09-21 13:35:59 +04:00
Andrew Borodin
f9eed1fcef Indentation. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-07-23 14:15:29 +04:00
Andrew Borodin
17aef88637 lib/strutil/strutilutf8.c: cosmetics and minor refactoring. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-07-23 14:01:05 +04:00
Andrew Borodin
7ee58f73ff lib/strutil/strutil8bit.c: cosmetics and minor refactoring. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-07-23 14:01:05 +04:00
Andrew Borodin
9e4d279885 lib/strutil/strutilascii.c: cosmetics and minor refactoring. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-07-23 14:01:05 +04:00
Andrew Borodin
5b91108b3c lib/strutil/strutil.c: cosmetics and minor refactoring. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-07-23 14:01:05 +04:00
Slava Zanko
0013adeeba Ticket #2992: mc fails to link when system lib does not contain strverscmp 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-07-09 13:44:51 +03:00
Andrew Borodin
ccf82ada12 Add functions to transform string to unsigned integer: 
* (xstrtoumax): from gnulib.
 * (parse_integer): from coreutils (dd.c).

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-07-05 09:09:03 +04:00
Veres Lajos
805703523d Misspellings fixes by https://github.com/vlajos/misspell_fixer 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-06-15 11:10:41 +04:00
Slava Zanko
80c8d58003 remove the include duplicates from source files 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-06-03 10:58:14 +03:00
Slava Zanko
808988b1f1 Add lib/strutil/replace:str_replace_all() function. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2013-02-16 17:40:37 +03:00
Andrew Borodin
6cd19ea6cb Remove irrelevant comments about file_date() function. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2013-01-16 14:34:34 +04:00
Andrew Borodin
0e5b483974 Portability: rename some str_class members 
...to avoid conflict with global names.

On HP-UX, inttypes.h includes ctype.h through other dependencies, ctype.h
defines macros for various functions and these macros clash with entries
of "struct str_class".

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-12-20 15:35:35 +04:00
Andrew Borodin
82b1d7bff3 Parenthesis around some -1. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-12-20 15:35:35 +04:00
Andrew Borodin
04942e5f2b (str_iscombiningmark): return gboolean instead of int 
...and related changes.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-12-20 15:18:06 +04:00
Andrew Borodin
60727b9b79 Clarify usage of AM_CPPFLAGS. 
Use AM_CPPFLAGS not AM_CFLAGS for includes. GLIB_CFLAGS are CPPFLAGS, actually.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-12-18 16:27:49 +04:00
Andrew Borodin
2940b7455d Fix of DOXYGEN docs: @return instead of @returns 
...and other minor corrections.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-09 10:05:13 +04:00
Andrew Borodin
d1fb83358d lib/strutil/strverscmp.c: add missing include of config.h. 
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-11-09 10:05:12 +04:00
Ilia Maslakov
55c8f041da fixed doxygen documentation 
Signed-off-by: Ilia Maslakov <il.smind@gmail.com>
 2012-09-10 14:29:53 +03:00
Andrew Borodin
8e224507c1 (str_utf8_normalize): ret rid of extra memory allocation. 
(str_utf8_casefold_normalize): likewise.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-09-10 14:29:53 +03:00
Andrew Borodin
b37af47023 Makefile.ams cleanup. 
Set defines via CPPFLAGS variable not via CFLAGS one.
Use AM_CPPFLAGS and AM_CFLAGS variables instead of per-target ones.

Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
 2012-07-17 17:04:05 +04:00
Slava Zanko
94bd4b1f78 Code indentation. 
Signed-off-by: Slava Zanko <slavazanko@gmail.com>
 2012-07-17 17:04:05 +04:00