mirrors/mc
1
0
Fork 0
mirror of https://github.com/MidnightCommander/mc synced 2025-04-03 05:32:56 +03:00
Code Issues Packages Projects Releases Wiki Activity

1999-08-12 Federico Mena Quintero <federico@redhat.com>

Browse Source 
The two following entries are BUGFIX: GNOME bug tracker #1789.

	* gscreen.c (panel_fill_panel_list): Do not allow selection of "..".
	(panel_icon_list_select_icon): Likewise.

	* glayout.c (gnome_panel_edit_menu): Removed the Invert Selection
	command.  It is completely broken for the expected GNOME
	semantics.
This commit is contained in:
Miguel de Icaza 1999-08-12 22:14:07 +00:00
parent 5e2a2a1e40
commit fe7d83f1d0
4 changed files with 23 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BUGS
View File

@ -3,7 +3,7 @@ Bugzilla: 3436
bugs.gnome.org:
Important: 1006, 1796
Major cosmetic: 272/875, 487, 825, 845, 1845, 899, 923, 1072/1336,
1299, 1415, 1457, 1545, 1559, 1582, 1656, 1758, 1789
1299, 1415, 1457, 1545, 1559, 1582, 1656, 1758
Minor cosmetic: 55/208, 115, 308, 383, 398, 449, 479, 597, 781,
874, 931, 956/1126, 1022.1, 1045, 1047, 904, 1329,
1468, 1508, 1750

9
gnome/ChangeLog
View File

@ -1,5 +1,14 @@
1999-08-12 Federico Mena Quintero <federico@redhat.com>
The two following entries are BUGFIX: GNOME bug tracker #1789.
* gscreen.c (panel_fill_panel_list): Do not allow selection of "..".
(panel_icon_list_select_icon): Likewise.
* glayout.c (gnome_panel_edit_menu): Removed the Invert Selection
command. It is completely broken for the expected GNOME
semantics.
* gnome-file-property-dialog.c (perm_group_new): If the file
belongs to an unknown user/group, use the group's number as a
string for the entry box. BUGFIX: GNOME bug tracker #1414.

1
gnome/glayout.c
View File

@ -395,7 +395,6 @@ GnomeUIInfo gnome_panel_edit_menu [] = {
{ GNOME_APP_UI_ITEM, N_("Select _All"), N_("Select all files in the current Panel"), gnome_select_all_cmd,
NULL, NULL, 0, NULL, 'a', GDK_CONTROL_MASK },
GNOMEUIINFO_ITEM_NONE(N_("_Select Files..."), N_("Select a group of files"), gnome_select),
GNOMEUIINFO_ITEM_NONE(N_("_Invert Selection"), N_("Reverses the list of tagged files"), reverse_selection_cmd),
GNOMEUIINFO_SEPARATOR,
{ GNOME_APP_UI_ITEM, N_("Search"), N_("Search for a file in the current Panel"), gnome_start_search,
NULL, NULL, 0, NULL, 's', GDK_CONTROL_MASK },

21
gnome/gscreen.c
View File

@ -199,6 +199,7 @@ panel_fill_panel_list (WPanel *panel)
for (i = 0; i < top; i++){
file_entry *fe = &panel->dir.list [i];
format_e *format = panel->format;
int n;
for (col = 0; format; format = format->next){
if (!format->use_in_gui)
@ -209,12 +210,17 @@ panel_fill_panel_list (WPanel *panel)
type_col = col;
if (!format->string_fn)
texts [col] = "";
texts[col] = "";
else
texts [col] = (*format->string_fn)(fe, 10);
texts[col] = (* format->string_fn) (fe, 10);
col++;
}
gtk_clist_append (cl, texts);
n = gtk_clist_append (cl, texts);
/* Do not let the user select .. */
if (strcmp (fe->fname, "..") == 0)
gtk_clist_set_selectable (cl, n, FALSE);
color = file_compute_color (NORMAL, fe);
panel_file_list_set_row_colors (cl, i, color);
@ -486,10 +492,6 @@ panel_file_list_configure_contents (GtkWidget *sw, WPanel *panel, int main_width
gtk_clist_thaw (clist);
}
/* Handler for the select_row signal of the clist. We synchronize the panel's
* idea of a selection, and handle pending actions that the
* button_press/button_release handlers did not handle by themselves.
*/
static void
panel_file_list_select_row (GtkWidget *file_list, gint row, gint column,
GdkEvent *event, gpointer data)
@ -517,7 +519,6 @@ panel_file_list_unselect_row (GtkWidget *widget, int row, int columns, GdkEvent
panel->selected = 0;
}
/* Figure out the number of visible lines in the panel */
static void
panel_file_list_compute_lines (GtkScrolledWindow *sw, WPanel *panel, int height)
@ -1380,6 +1381,10 @@ panel_icon_list_select_icon (GtkWidget *widget, int index, GdkEvent *event, WPan
display_mini_info (panel);
execute_hooks (select_file_hook);
/* Do not let the user select .. */
if (strcmp (panel->dir.list[index].fname, "..") == 0)
gnome_icon_list_unselect_icon (GNOME_ICON_LIST (widget), index);
if (!event)
return;