mirrors/mc
1
0
Fork 0
mirror of https://github.com/MidnightCommander/mc synced 2025-01-03 10:04:32 +03:00
Code Issues Packages Projects Releases Wiki Activity

* HACKING: Added a warning for the ?: operator.

Browse Source
This commit is contained in:
Roland Illig 2005-04-22 15:35:35 +00:00
parent bbdebd492c
commit 796bfbf4f0
1 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
HACKING
View File

@ -316,6 +316,25 @@ Programming Tips
(This list should be sorted alphabetically.)
?: This operator has a precedence that is easy to use the wrong way. You
might think that
int right = 25 + have_frame() ? 1 : 0; /* WRONG */
results in either 25 or 26. This is not the case. The C compiler
sees this as:
int right = (25 + have_frame()) ? 1 : 0; /* WRONG */
To avoid this, put the ?: in parentheses, like this
int right = 25 + (have_frame() ? 1 : 0); /* RIGHT */
If the condition is more complicated, put it in additional
parentheses:
int right = 25 + ((have_frame()) ? 1 : 0); /* RIGHT */
const: For every function taking a string argument, decide whether you
(as a user of the function) would expect that the string is modi-
fied by the function. If not, declare the string argument as