mirrors/mc
1
0
Fork 0
mirror of https://github.com/MidnightCommander/mc synced 2025-03-10 10:01:36 +03:00
Code Issues Packages Projects Releases Wiki Activity

(handle_console_linux): fix resource leak.

Browse Source 
Handle open failure properly.

Found by Coverity.

Coverity id #32608.

Signed-off-by: Andreas Mohr <and@gmx.li>
Signed-off-by: Andrew Borodin <aborodin@vmail.ru>
This commit is contained in:
Andreas Mohr 2020-12-08 15:10:05 +00:00 committed by Andrew Borodin
parent 61f997de26
commit 5f482396f6
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/cons.handler.c
View File

@ -191,6 +191,8 @@ handle_console_linux (console_action_t action)
/* Bind the pipe 0 to the standard input */
do
{
gboolean ok;
if (dup2 (pipefd1[0], STDIN_FILENO) == -1)
break;
status = close (pipefd1[0]);
@ -201,9 +203,13 @@ handle_console_linux (console_action_t action)
status = close (pipefd2[1]);
/* Bind standard error to /dev/null */
status = open ("/dev/null", O_WRONLY);
if (dup2 (status, STDERR_FILENO) == -1)
if (status == -1)
break;
ok = dup2 (status, STDERR_FILENO) != -1;
status = close (status);
if (!ok)
break;
if (tty_name != NULL)
{
char *mc_conssaver;