1998-03-10 Federico Mena Quintero <federico@nuclecu.unam.mx>

* gtools.c (message): Added return NULL.  This needs to be fixed.
	(translate_gdk_keysym_to_curses): FIXME: Replace KEY_BACKTAB by '\t'
	while KEY_BACKTAB is added somewhere else.
	(translate_gdk_keysym_to_curses): return -1 as last resort.

	* glayout.c (get_current_index): Add g_assert_not_reached() for
	fatal case.

	* gmenu.c (menubar_new): Cast g_menubar to unsigned long.

	* gwidget.c (x_create_input): Cast entry to GTK_OBJECT.

	* gkey.c (find_select_closure_callback): Fix = -> == typo.

1998-03-10  Federico Mena Quintero  <federico@nuclecu.unam.mx>

	* xslint.c (getch): Added missing "return".

	* utilunix.c (init_groups): Added parentheses around
	assignment/truth value.

	* boxes.c: #include <stdlib.h>

	* screen.c (string_inode): Cast fe->buf.st_ino to long to be
	consistent with sprintf format.

	* main.c (handle_args): Added parentheses around assignment/truth value.
This commit is contained in:
Miguel de Icaza 1998-03-10 21:10:30 +00:00
parent 49eda3f828
commit 4dd40872d9
12 changed files with 57 additions and 10 deletions

View File

@ -1,3 +1,19 @@
1998-03-10 Federico Mena Quintero <federico@nuclecu.unam.mx>
* gtools.c (message): Added return NULL. This needs to be fixed.
(translate_gdk_keysym_to_curses): FIXME: Replace KEY_BACKTAB by '\t'
while KEY_BACKTAB is added somewhere else.
(translate_gdk_keysym_to_curses): return -1 as last resort.
* glayout.c (get_current_index): Add g_assert_not_reached() for
fatal case.
* gmenu.c (menubar_new): Cast g_menubar to unsigned long.
* gwidget.c (x_create_input): Cast entry to GTK_OBJECT.
* gkey.c (find_select_closure_callback): Fix = -> == typo.
Tue Mar 10 14:01:47 1998 Miguel de Icaza <miguel@nuclecu.unam.mx> Tue Mar 10 14:01:47 1998 Miguel de Icaza <miguel@nuclecu.unam.mx>
* gscreen.c (x_adjust_top_file): We no longer adjust the top * gscreen.c (x_adjust_top_file): We no longer adjust the top
@ -9,6 +25,12 @@ Tue Mar 10 14:01:47 1998 Miguel de Icaza <miguel@nuclecu.unam.mx>
coords.x and coords.y fields from the DropDataAvailableEvent to coords.x and coords.y fields from the DropDataAvailableEvent to
find out which directory receives the drop. find out which directory receives the drop.
Tue Mar 10 00:10:32 1998 Miguel de Icaza <miguel@nuclecu.unam.mx>
* gscreen.c (panel_drop_data_available): Now drop support uses the
new coords.x and coords.y fields from the DropDataAvailableEvent
to find out which directory receives the drop.
* gwidget.c (x_radio_focus_item): Add support for focusing radio * gwidget.c (x_radio_focus_item): Add support for focusing radio
buttons. buttons.

View File

@ -46,6 +46,8 @@ get_current_index (void)
return i; return i;
} }
printf ("FATAL: current panel is not in the list\n"); printf ("FATAL: current panel is not in the list\n");
g_assert_not_reached ();
return -1; /* keep -Wall happy */
} }
int int

View File

@ -65,7 +65,7 @@ WMenu *menubar_new (int y, int x, int cols, Menu menu [], int items)
g_menubar = gtk_menu_bar_new (); g_menubar = gtk_menu_bar_new ();
gtk_widget_show (g_menubar); gtk_widget_show (g_menubar);
menubar->widget.wdata = g_menubar; menubar->widget.wdata = (unsigned long) g_menubar;
for (i = 0; i < items; i++){ for (i = 0; i < items; i++){
GtkWidget *child; GtkWidget *child;

View File

@ -114,6 +114,10 @@ Dlg_head *message (int error, char *header, char *text, ...)
va_end (args); va_end (args);
query_dialog (header, buffer, error, 1, "&Ok"); query_dialog (header, buffer, error, 1, "&Ok");
/* FIXME: return what? */
return NULL;
} }
int int
@ -126,7 +130,7 @@ translate_gdk_keysym_to_curses (GdkEventKey *event)
return KEY_BACKSPACE; return KEY_BACKSPACE;
case GDK_Tab: case GDK_Tab:
if (event->state & GDK_SHIFT_MASK) if (event->state & GDK_SHIFT_MASK)
return KEY_BACKTAB; return '\t'; /* return KEY_BACKTAB */
return '\t'; return '\t';
case GDK_KP_Enter: case GDK_KP_Enter:
case GDK_Return: case GDK_Return:
@ -233,6 +237,7 @@ translate_gdk_keysym_to_curses (GdkEventKey *event)
} }
} }
return -1;
} }

View File

@ -171,7 +171,7 @@ x_create_input (Dlg_head *h, widget_data parent, WInput *in)
in->widget.wdata = (widget_data) entry; in->widget.wdata = (widget_data) entry;
gtk_entry_set_text (GTK_ENTRY (entry), in->buffer); gtk_entry_set_text (GTK_ENTRY (entry), in->buffer);
gtk_entry_set_position (GTK_ENTRY (entry), in->point); gtk_entry_set_position (GTK_ENTRY (entry), in->point);
gtk_signal_connect (GTK_ENTRY (entry), "button_press_event", gtk_signal_connect (GTK_OBJECT (entry), "button_press_event",
GTK_SIGNAL_FUNC (entry_click), in); GTK_SIGNAL_FUNC (entry_click), in);
return 1; return 1;
} }

View File

@ -1,3 +1,17 @@
1998-03-10 Federico Mena Quintero <federico@nuclecu.unam.mx>
* xslint.c (getch): Added missing "return".
* utilunix.c (init_groups): Added parentheses around
assignment/truth value.
* boxes.c: #include <stdlib.h>
* screen.c (string_inode): Cast fe->buf.st_ino to long to be
consistent with sprintf format.
* main.c (handle_args): Added parentheses around assignment/truth value.
Sat Mar 7 14:33:38 1998 Pavel Roskin <pavel@absolute.spb.su> Sat Mar 7 14:33:38 1998 Pavel Roskin <pavel@absolute.spb.su>
* src/complete.c: obsolete hack for OS/2 and NT removed. * src/complete.c: obsolete hack for OS/2 and NT removed.

View File

@ -23,6 +23,7 @@
#include "tty.h" #include "tty.h"
#include <string.h> #include <string.h>
#include <stdio.h> #include <stdio.h>
#include <stdlib.h>
#include <sys/types.h> #include <sys/types.h>
#include <sys/stat.h> #include <sys/stat.h>
#include <sys/param.h> #include <sys/param.h>

View File

@ -618,6 +618,8 @@ match_file_output:
if (p < q) { if (p < q) {
char *filename_copy = strdup (filename); char *filename_copy = strdup (filename);
/* FIXME: drops is passed from an incompatible pointer type */
exec_extension (filename_copy, r + 1, drops, move_dir, view_at_line_number); exec_extension (filename_copy, r + 1, drops, move_dir, view_at_line_number);
free (filename_copy); free (filename_copy);

View File

@ -2673,7 +2673,7 @@ static void handle_args (int argc, char *argv [])
char buffer[MC_MAXPATHLEN + 2]; char buffer[MC_MAXPATHLEN + 2];
this_dir = strdup (tmp); this_dir = strdup (tmp);
mc_get_current_wd (buffer, sizeof (buffer) - 2); mc_get_current_wd (buffer, sizeof (buffer) - 2);
if (tmp = poptGetArg (optCon)) if ((tmp = poptGetArg (optCon)))
other_dir = strdup (tmp); other_dir = strdup (tmp);
} }
} }

View File

@ -368,7 +368,7 @@ string_inode (file_entry *fe, int len)
{ {
static char buffer [9]; static char buffer [9];
sprintf (buffer, "%ld", fe->buf.st_ino); sprintf (buffer, "%ld", (long) fe->buf.st_ino);
return buffer; return buffer;
} }

View File

@ -90,7 +90,7 @@ void init_groups (void)
return; return;
setgrent (); setgrent ();
while (grp = getgrent ()) while ((grp = getgrent ()))
for (i = 0; grp->gr_mem[i]; i++) for (i = 0; grp->gr_mem[i]; i++)
if (!strcmp (pwd->pw_name,grp->gr_mem[i])) if (!strcmp (pwd->pw_name,grp->gr_mem[i]))
{ {

View File

@ -86,9 +86,10 @@ do_define_key (int code, char *strcap) {}
void void
load_terminfo_keys () {} load_terminfo_keys () {}
int getch () int
getch ()
{ {
getchar (); return getchar ();
} }
void void