mirrors
/
mc
mirror of https://github.com/MidnightCommander/mc
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

1999-04-20 Federico Mena Quintero <federico@nuclecu.unam.mx> 

* gdesktop.c (click_proxy_motion): Terminate rubberbanding if the
	event mask does not contain GDK_BUTTON1_MASK.  There is a race
	condition where we will not get the button release event if we
	manage to grab the server in the button_press handler before the
	window manager proxies the button release to us.
	(perform_release): New function to terminate rubberbanding; this
	used to be in click_proxy_button_release().  Also, update the drag
	selection based on the last known mouse position, not on the
	current one (which is not meaningful if the race condition
	mentioned above kicks in).
	(click_proxy_button_release): Use perform_release().
This commit is contained in:
Miguel de Icaza 1999-04-21 00:22:30 +00:00
parent cfa0644c5e
commit 49061a6fc1
2 changed files with 42 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
gnome/ChangeLog
View File

@ -1,3 +1,17 @@
1999-04-20 Federico Mena Quintero <federico@nuclecu.unam.mx>
* gdesktop.c (click_proxy_motion): Terminate rubberbanding if the
event mask does not contain GDK_BUTTON1_MASK. There is a race
condition where we will not get the button release event if we
manage to grab the server in the button_press handler before the
window manager proxies the button release to us.
(perform_release): New function to terminate rubberbanding; this
used to be in click_proxy_button_release(). Also, update the drag
selection based on the last known mouse position, not on the
current one (which is not meaningful if the race condition
mentioned above kicks in).
(click_proxy_button_release): Use perform_release().
1999-04-19 Federico Mena Quintero <federico@nuclecu.unam.mx>
* gdialogs.c (file_op_context_create_ui): Handle the "close"

37
gnome/gdesktop.c
View File

@ -2649,6 +2649,22 @@ click_proxy_button_press (GtkWidget *widget, GdkEventButton *event, gpointer dat
return FALSE;
}
/* Terminates rubberbanding when the button is released. This is shared by the
* button_release handler and the motion_notify handler.
*/
static void
perform_release (guint32 time)
{
draw_rubberband (click_current_x, click_current_y);
gdk_pointer_ungrab (time);
click_dragging = FALSE;
update_drag_selection (click_current_x, click_current_y);
XUngrabServer (GDK_DISPLAY ());
gdk_flush ();
}
/* Handles button releases on the root window via the click_proxy_gdk_window */
static gint
click_proxy_button_release (GtkWidget *widget, GdkEventButton *event, gpointer data)
@ -2656,15 +2672,7 @@ click_proxy_button_release (GtkWidget *widget, GdkEventButton *event, gpointer d
if (!click_dragging || event->button != 1)
return FALSE;
draw_rubberband (click_current_x, click_current_y);
gdk_pointer_ungrab (event->time);
click_dragging = FALSE;
update_drag_selection (event->x, event->y);
XUngrabServer (GDK_DISPLAY ());
gdk_flush ();
perform_release (event->time);
return TRUE;
}
@ -2675,6 +2683,17 @@ click_proxy_motion (GtkWidget *widget, GdkEventMotion *event, gpointer data)
if (!click_dragging)
return FALSE;
/* There exists the following race condition. If in the button_press
* handler we manage to grab the server before the window manager can
* proxy the button release to us, then we wil not get the release
* event. So we have to check the event mask and fake a release by
* hand.
*/
if (!(event->state & GDK_BUTTON1_MASK)) {
perform_release (event->time);
return TRUE;
}
draw_rubberband (click_current_x, click_current_y);
draw_rubberband (event->x, event->y);
update_drag_selection (event->x, event->y);